All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacopo Mondi <jacopo@jmondi.org>
To: slongerbeam@gmail.com
Cc: laurent.pinchart@ideasonboard.com, sakari.ailus@iki.fi,
	hverkuil-cisco@xs4all.nl, mirela.rabulea@nxp.com,
	xavier.roumegue@oss.nxp.com, tomi.valkeinen@ideasonboard.com,
	hugues.fruchet@st.com, prabhakar.mahadev-lad.rj@bp.renesas.com,
	aford173@gmail.com, festevam@gmail.com,
	eugen.hristev@microchip.com, jbrunet@baylibre.com,
	mchehab@kernel.org, linux-media@vger.kernel.org,
	Jacopo Mondi <jacopo@jmondi.org>
Subject: [PATCH v2 16/23] media: ov5640: Implement init_cfg
Date: Thu, 10 Feb 2022 12:10:01 +0100	[thread overview]
Message-ID: <20220210111004.152859-4-jacopo@jmondi.org> (raw)
In-Reply-To: <20220210110458.152494-1-jacopo@jmondi.org>

Implement the init_cfg pad operation to initialize the subdev state
format to the default one.

Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/media/i2c/ov5640.c | 34 ++++++++++++++++++++++++----------
 1 file changed, 24 insertions(+), 10 deletions(-)

diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index dd7ff1bb580f..8b90fab26d16 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -390,6 +390,18 @@ static inline bool ov5640_is_csi2(struct ov5640_dev *sensor)
  * over i2c.
  */
 /* YUV422 UYVY VGA@30fps */
+
+static const struct v4l2_mbus_framefmt ov5640_default_fmt = {
+	.code = MEDIA_BUS_FMT_UYVY8_2X8,
+	.width = 640,
+	.height = 480,
+	.colorspace = V4L2_COLORSPACE_SRGB,
+	.ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(V4L2_COLORSPACE_SRGB),
+	.quantization = V4L2_QUANTIZATION_FULL_RANGE,
+	.xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(V4L2_COLORSPACE_SRGB),
+	.field = V4L2_FIELD_NONE,
+};
+
 static const struct reg_value ov5640_init_setting[] = {
 	{0x3103, 0x11, 0, 0}, {0x3008, 0x82, 0, 5}, {0x3008, 0x42, 0, 0},
 	{0x3103, 0x03, 0, 0}, {0x3630, 0x36, 0, 0},
@@ -3367,6 +3379,16 @@ static int ov5640_s_stream(struct v4l2_subdev *sd, int enable)
 	return ret;
 }
 
+static int ov5640_init_cfg(struct v4l2_subdev *sd,
+			   struct v4l2_subdev_state *state)
+{
+	struct v4l2_mbus_framefmt *fmt = v4l2_subdev_get_try_format(sd, state, 0);
+
+	*fmt = ov5640_default_fmt;
+
+	return 0;
+}
+
 static const struct v4l2_subdev_core_ops ov5640_core_ops = {
 	.s_power = ov5640_s_power,
 	.log_status = v4l2_ctrl_subdev_log_status,
@@ -3381,6 +3403,7 @@ static const struct v4l2_subdev_video_ops ov5640_video_ops = {
 };
 
 static const struct v4l2_subdev_pad_ops ov5640_pad_ops = {
+	.init_cfg = ov5640_init_cfg,
 	.enum_mbus_code = ov5640_enum_mbus_code,
 	.get_fmt = ov5640_get_fmt,
 	.set_fmt = ov5640_set_fmt,
@@ -3439,7 +3462,6 @@ static int ov5640_probe(struct i2c_client *client)
 	struct device *dev = &client->dev;
 	struct fwnode_handle *endpoint;
 	struct ov5640_dev *sensor;
-	struct v4l2_mbus_framefmt *fmt;
 	u32 rotation;
 	int ret;
 
@@ -3453,15 +3475,7 @@ static int ov5640_probe(struct i2c_client *client)
 	 * default init sequence initialize sensor to
 	 * YUV422 UYVY VGA@30fps
 	 */
-	fmt = &sensor->fmt;
-	fmt->code = MEDIA_BUS_FMT_UYVY8_2X8;
-	fmt->colorspace = V4L2_COLORSPACE_SRGB;
-	fmt->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(fmt->colorspace);
-	fmt->quantization = V4L2_QUANTIZATION_FULL_RANGE;
-	fmt->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(fmt->colorspace);
-	fmt->width = 640;
-	fmt->height = 480;
-	fmt->field = V4L2_FIELD_NONE;
+	sensor->fmt = ov5640_default_fmt;
 	sensor->frame_interval.numerator = 1;
 	sensor->frame_interval.denominator = ov5640_framerates[OV5640_30_FPS];
 	sensor->current_fr = OV5640_30_FPS;
-- 
2.35.0


  parent reply	other threads:[~2022-02-10 11:09 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 11:04 [PATCH v2 00/23] media: ov5640: Rework the clock tree programming for MIPI Jacopo Mondi
2022-02-10 11:04 ` [PATCH v2 01/23] media: ov5640: Add pixel rate to modes Jacopo Mondi
2022-02-20 11:53   ` Laurent Pinchart
2022-02-21 20:14     ` Adam Ford
2022-02-22  7:48       ` Jacopo Mondi
2022-02-22 19:08         ` Adam Ford
2022-02-10 11:04 ` [PATCH v2 02/23] media: ov5604: Re-arrange modes definition Jacopo Mondi
2022-02-10 11:04 ` [PATCH v2 03/23] media: ov5640: Add ov5640_is_csi2() function Jacopo Mondi
2022-02-10 11:04 ` [PATCH v2 04/23] media: ov5640: Associate bpp with formats Jacopo Mondi
2022-02-10 11:04 ` [PATCH v2 05/23] media: ov5640: Add LINK_FREQ control Jacopo Mondi
2022-02-20 11:55   ` Laurent Pinchart
2022-02-10 11:04 ` [PATCH v2 06/23] media: ov5640: Update pixel_rate and link_freq Jacopo Mondi
2022-02-10 11:04 ` [PATCH v2 07/23] media: ov5640: Rework CSI-2 clock tree Jacopo Mondi
2022-02-20 12:17   ` Laurent Pinchart
2022-02-21 11:39     ` Jacopo Mondi
2022-02-21 12:12       ` Laurent Pinchart
2022-02-10 11:04 ` [PATCH v2 08/23] media: ov5640: Rework timings programming Jacopo Mondi
2022-02-20 12:44   ` Laurent Pinchart
2022-02-10 11:04 ` [PATCH v2 09/23] media: ov5640: Fix 720x480 in RGB888 mode Jacopo Mondi
2022-02-20 12:50   ` Laurent Pinchart
2022-02-10 11:04 ` [PATCH v2 10/23] media: ov5640: Rework analog crop rectangles Jacopo Mondi
2022-02-11  9:34   ` [v2.1] " Jacopo Mondi
2022-02-20 12:56     ` Laurent Pinchart
2022-02-10 11:04 ` [PATCH v2 11/23] media: ov5640: Re-sort per-mode register tables Jacopo Mondi
2022-02-20 12:52   ` Laurent Pinchart
2022-02-20 12:59     ` Laurent Pinchart
2022-02-10 11:04 ` [PATCH v2 12/23] media: ov5640: Remove ov5640_mode_init_data Jacopo Mondi
2022-02-20 12:58   ` Laurent Pinchart
2022-02-10 11:09 ` [PATCH v2 13/23] media: ov5640: Add HBLANK control Jacopo Mondi
2022-02-10 11:09 ` [PATCH v2 14/23] media: ov5640: Add VBLANK control Jacopo Mondi
2022-02-20 13:01   ` Laurent Pinchart
2022-02-10 11:10 ` [PATCH v2 15/23] media: ov5640: Fix durations to comply with FPS Jacopo Mondi
2022-02-20 13:03   ` Laurent Pinchart
2022-02-10 11:10 ` Jacopo Mondi [this message]
2022-02-10 11:10 ` [PATCH v2 17/23] media: ov5640: Implement get_selection Jacopo Mondi
2022-02-20 13:06   ` Laurent Pinchart
2022-02-10 11:10 ` [PATCH v2 18/23] media: ov5640: Limit frame_interval to DVP mode only Jacopo Mondi
2022-02-10 11:10 ` [PATCH v2 19/23] media: ov5640: Register device properties Jacopo Mondi
2022-02-10 11:10 ` [PATCH v2 20/23] media: ov5640: Add RGB565_1X16 format Jacopo Mondi
2022-02-20 13:07   ` Laurent Pinchart
2022-02-10 11:10 ` [PATCH v2 21/23] media: ov5640: Add RGB888/BGR888 formats Jacopo Mondi
2022-02-20 13:13   ` Laurent Pinchart
2022-02-10 11:10 ` [PATCH v2 22/23] media: ov5640: Restrict sizes to mbus code Jacopo Mondi
2022-02-20 13:16   ` Laurent Pinchart
2022-02-21 12:42     ` Jacopo Mondi
2022-02-10 11:10 ` [PATCH v2 23/23] media: ov5640: Adjust format to bpp in s_fmt Jacopo Mondi
2022-02-10 12:03 ` [PATCH v2 00/23] media: ov5640: Rework the clock tree programming for MIPI Tomi Valkeinen
2022-02-10 12:10   ` Tomi Valkeinen
2022-02-10 13:00 ` Tomi Valkeinen
2022-02-10 17:11   ` Jacopo Mondi
2022-02-11  7:55     ` Tomi Valkeinen
2022-02-11  8:01       ` Tomi Valkeinen
2022-02-11  9:36   ` Jacopo Mondi
2022-02-11 10:09 ` Eugen.Hristev
2022-02-11 11:25   ` Jacopo Mondi
2022-02-14 14:06     ` Eugen.Hristev
2022-02-14 14:38       ` Jacopo Mondi
2022-02-14 15:08         ` Eugen.Hristev
2022-02-14 18:56           ` Jacopo Mondi
2022-02-17 14:25             ` Eugen.Hristev
2022-02-21  8:51               ` Jacopo Mondi
2022-02-21  9:04                 ` Eugen.Hristev
2022-02-21 11:18                   ` Jacopo Mondi
2022-02-21 13:31                   ` Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220210111004.152859-4-jacopo@jmondi.org \
    --to=jacopo@jmondi.org \
    --cc=aford173@gmail.com \
    --cc=eugen.hristev@microchip.com \
    --cc=festevam@gmail.com \
    --cc=hugues.fruchet@st.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jbrunet@baylibre.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mirela.rabulea@nxp.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=sakari.ailus@iki.fi \
    --cc=slongerbeam@gmail.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=xavier.roumegue@oss.nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.