All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: Steve Longerbeam <slongerbeam@gmail.com>,
	sakari.ailus@iki.fi, hverkuil-cisco@xs4all.nl,
	mirela.rabulea@nxp.com, xavier.roumegue@oss.nxp.com,
	tomi.valkeinen@ideasonboard.com, hugues.fruchet@st.com,
	prabhakar.mahadev-lad.rj@bp.renesas.com, aford173@gmail.com,
	festevam@gmail.com, Eugen.Hristev@microchip.com,
	jbrunet@baylibre.com, Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v2 11/23] media: ov5640: Re-sort per-mode register tables
Date: Sun, 20 Feb 2022 14:52:36 +0200	[thread overview]
Message-ID: <YhI5lI+bA3aYPW/v@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220210110458.152494-12-jacopo@jmondi.org>

Hi Jacopo,

Thank you for the patch.

On Thu, Feb 10, 2022 at 12:04:46PM +0100, Jacopo Mondi wrote:
> The per-mode register tables are not sorted by size. Fix it.
> 
> Cosmetic change only.
> 
> Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/i2c/ov5640.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
> index 72b78201f089..17835e71665a 100644
> --- a/drivers/media/i2c/ov5640.c
> +++ b/drivers/media/i2c/ov5640.c
> @@ -462,7 +462,7 @@ static const struct reg_value ov5640_init_setting_30fps_VGA[] = {
>  	{0x3a1f, 0x14, 0, 0}, {0x3008, 0x02, 0, 0}, {0x3c00, 0x04, 0, 300},
>  };
>  
> -static const struct reg_value ov5640_setting_VGA_640_480[] = {
> +static const struct reg_value ov5640_setting_QQVGA_160_120[] = {
>  	{0x3c07, 0x08, 0, 0},
>  	{0x3c09, 0x1c, 0, 0}, {0x3c0a, 0x9c, 0, 0}, {0x3c0b, 0x40, 0, 0},
>  	{0x3814, 0x31, 0, 0},
> @@ -473,11 +473,10 @@ static const struct reg_value ov5640_setting_VGA_640_480[] = {
>  	{0x3a0a, 0x00, 0, 0}, {0x3a0b, 0xf6, 0, 0}, {0x3a0e, 0x03, 0, 0},
>  	{0x3a0d, 0x04, 0, 0}, {0x3a14, 0x03, 0, 0}, {0x3a15, 0xd8, 0, 0},
>  	{0x4001, 0x02, 0, 0}, {0x4004, 0x02, 0, 0},
> -	{0x4407, 0x04, 0, 0}, {0x460b, 0x35, 0, 0}, {0x460c, 0x22, 0, 0},
> -	{0x3824, 0x02, 0, 0}, {0x5001, 0xa3, 0, 0},
> +	{0x4407, 0x04, 0, 0}, {0x5001, 0xa3, 0, 0},
>  };
>  
> -static const struct reg_value ov5640_setting_XGA_1024_768[] = {
> +static const struct reg_value ov5640_setting_QCIF_176_144[] = {
>  	{0x3c07, 0x08, 0, 0},
>  	{0x3c09, 0x1c, 0, 0}, {0x3c0a, 0x9c, 0, 0}, {0x3c0b, 0x40, 0, 0},
>  	{0x3814, 0x31, 0, 0},
> @@ -507,7 +506,7 @@ static const struct reg_value ov5640_setting_QVGA_320_240[] = {
>  	{0x3824, 0x02, 0, 0}, {0x5001, 0xa3, 0, 0},
>  };
>  
> -static const struct reg_value ov5640_setting_QQVGA_160_120[] = {
> +static const struct reg_value ov5640_setting_VGA_640_480[] = {
>  	{0x3c07, 0x08, 0, 0},
>  	{0x3c09, 0x1c, 0, 0}, {0x3c0a, 0x9c, 0, 0}, {0x3c0b, 0x40, 0, 0},
>  	{0x3814, 0x31, 0, 0},
> @@ -518,10 +517,11 @@ static const struct reg_value ov5640_setting_QQVGA_160_120[] = {
>  	{0x3a0a, 0x00, 0, 0}, {0x3a0b, 0xf6, 0, 0}, {0x3a0e, 0x03, 0, 0},
>  	{0x3a0d, 0x04, 0, 0}, {0x3a14, 0x03, 0, 0}, {0x3a15, 0xd8, 0, 0},
>  	{0x4001, 0x02, 0, 0}, {0x4004, 0x02, 0, 0},
> -	{0x4407, 0x04, 0, 0}, {0x5001, 0xa3, 0, 0},
> +	{0x4407, 0x04, 0, 0}, {0x460b, 0x35, 0, 0}, {0x460c, 0x22, 0, 0},
> +	{0x3824, 0x02, 0, 0}, {0x5001, 0xa3, 0, 0},
>  };
>  
> -static const struct reg_value ov5640_setting_QCIF_176_144[] = {
> +static const struct reg_value ov5640_setting_NTSC_720_480[] = {
>  	{0x3c07, 0x08, 0, 0},
>  	{0x3c09, 0x1c, 0, 0}, {0x3c0a, 0x9c, 0, 0}, {0x3c0b, 0x40, 0, 0},
>  	{0x3814, 0x31, 0, 0},
> @@ -536,7 +536,7 @@ static const struct reg_value ov5640_setting_QCIF_176_144[] = {
>  	{0x3824, 0x02, 0, 0}, {0x5001, 0xa3, 0, 0},
>  };
>  
> -static const struct reg_value ov5640_setting_NTSC_720_480[] = {
> +static const struct reg_value ov5640_setting_PAL_720_576[] = {
>  	{0x3c07, 0x08, 0, 0},
>  	{0x3c09, 0x1c, 0, 0}, {0x3c0a, 0x9c, 0, 0}, {0x3c0b, 0x40, 0, 0},
>  	{0x3814, 0x31, 0, 0},
> @@ -551,7 +551,7 @@ static const struct reg_value ov5640_setting_NTSC_720_480[] = {
>  	{0x3824, 0x02, 0, 0}, {0x5001, 0xa3, 0, 0},
>  };
>  
> -static const struct reg_value ov5640_setting_PAL_720_576[] = {
> +static const struct reg_value ov5640_setting_XGA_1024_768[] = {
>  	{0x3c07, 0x08, 0, 0},
>  	{0x3c09, 0x1c, 0, 0}, {0x3c0a, 0x9c, 0, 0}, {0x3c0b, 0x40, 0, 0},
>  	{0x3814, 0x31, 0, 0},

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2022-02-20 12:52 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 11:04 [PATCH v2 00/23] media: ov5640: Rework the clock tree programming for MIPI Jacopo Mondi
2022-02-10 11:04 ` [PATCH v2 01/23] media: ov5640: Add pixel rate to modes Jacopo Mondi
2022-02-20 11:53   ` Laurent Pinchart
2022-02-21 20:14     ` Adam Ford
2022-02-22  7:48       ` Jacopo Mondi
2022-02-22 19:08         ` Adam Ford
2022-02-10 11:04 ` [PATCH v2 02/23] media: ov5604: Re-arrange modes definition Jacopo Mondi
2022-02-10 11:04 ` [PATCH v2 03/23] media: ov5640: Add ov5640_is_csi2() function Jacopo Mondi
2022-02-10 11:04 ` [PATCH v2 04/23] media: ov5640: Associate bpp with formats Jacopo Mondi
2022-02-10 11:04 ` [PATCH v2 05/23] media: ov5640: Add LINK_FREQ control Jacopo Mondi
2022-02-20 11:55   ` Laurent Pinchart
2022-02-10 11:04 ` [PATCH v2 06/23] media: ov5640: Update pixel_rate and link_freq Jacopo Mondi
2022-02-10 11:04 ` [PATCH v2 07/23] media: ov5640: Rework CSI-2 clock tree Jacopo Mondi
2022-02-20 12:17   ` Laurent Pinchart
2022-02-21 11:39     ` Jacopo Mondi
2022-02-21 12:12       ` Laurent Pinchart
2022-02-10 11:04 ` [PATCH v2 08/23] media: ov5640: Rework timings programming Jacopo Mondi
2022-02-20 12:44   ` Laurent Pinchart
2022-02-10 11:04 ` [PATCH v2 09/23] media: ov5640: Fix 720x480 in RGB888 mode Jacopo Mondi
2022-02-20 12:50   ` Laurent Pinchart
2022-02-10 11:04 ` [PATCH v2 10/23] media: ov5640: Rework analog crop rectangles Jacopo Mondi
2022-02-11  9:34   ` [v2.1] " Jacopo Mondi
2022-02-20 12:56     ` Laurent Pinchart
2022-02-10 11:04 ` [PATCH v2 11/23] media: ov5640: Re-sort per-mode register tables Jacopo Mondi
2022-02-20 12:52   ` Laurent Pinchart [this message]
2022-02-20 12:59     ` Laurent Pinchart
2022-02-10 11:04 ` [PATCH v2 12/23] media: ov5640: Remove ov5640_mode_init_data Jacopo Mondi
2022-02-20 12:58   ` Laurent Pinchart
2022-02-10 11:09 ` [PATCH v2 13/23] media: ov5640: Add HBLANK control Jacopo Mondi
2022-02-10 11:09 ` [PATCH v2 14/23] media: ov5640: Add VBLANK control Jacopo Mondi
2022-02-20 13:01   ` Laurent Pinchart
2022-02-10 11:10 ` [PATCH v2 15/23] media: ov5640: Fix durations to comply with FPS Jacopo Mondi
2022-02-20 13:03   ` Laurent Pinchart
2022-02-10 11:10 ` [PATCH v2 16/23] media: ov5640: Implement init_cfg Jacopo Mondi
2022-02-10 11:10 ` [PATCH v2 17/23] media: ov5640: Implement get_selection Jacopo Mondi
2022-02-20 13:06   ` Laurent Pinchart
2022-02-10 11:10 ` [PATCH v2 18/23] media: ov5640: Limit frame_interval to DVP mode only Jacopo Mondi
2022-02-10 11:10 ` [PATCH v2 19/23] media: ov5640: Register device properties Jacopo Mondi
2022-02-10 11:10 ` [PATCH v2 20/23] media: ov5640: Add RGB565_1X16 format Jacopo Mondi
2022-02-20 13:07   ` Laurent Pinchart
2022-02-10 11:10 ` [PATCH v2 21/23] media: ov5640: Add RGB888/BGR888 formats Jacopo Mondi
2022-02-20 13:13   ` Laurent Pinchart
2022-02-10 11:10 ` [PATCH v2 22/23] media: ov5640: Restrict sizes to mbus code Jacopo Mondi
2022-02-20 13:16   ` Laurent Pinchart
2022-02-21 12:42     ` Jacopo Mondi
2022-02-10 11:10 ` [PATCH v2 23/23] media: ov5640: Adjust format to bpp in s_fmt Jacopo Mondi
2022-02-10 12:03 ` [PATCH v2 00/23] media: ov5640: Rework the clock tree programming for MIPI Tomi Valkeinen
2022-02-10 12:10   ` Tomi Valkeinen
2022-02-10 13:00 ` Tomi Valkeinen
2022-02-10 17:11   ` Jacopo Mondi
2022-02-11  7:55     ` Tomi Valkeinen
2022-02-11  8:01       ` Tomi Valkeinen
2022-02-11  9:36   ` Jacopo Mondi
2022-02-11 10:09 ` Eugen.Hristev
2022-02-11 11:25   ` Jacopo Mondi
2022-02-14 14:06     ` Eugen.Hristev
2022-02-14 14:38       ` Jacopo Mondi
2022-02-14 15:08         ` Eugen.Hristev
2022-02-14 18:56           ` Jacopo Mondi
2022-02-17 14:25             ` Eugen.Hristev
2022-02-21  8:51               ` Jacopo Mondi
2022-02-21  9:04                 ` Eugen.Hristev
2022-02-21 11:18                   ` Jacopo Mondi
2022-02-21 13:31                   ` Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhI5lI+bA3aYPW/v@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=aford173@gmail.com \
    --cc=festevam@gmail.com \
    --cc=hugues.fruchet@st.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jacopo@jmondi.org \
    --cc=jbrunet@baylibre.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mirela.rabulea@nxp.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=sakari.ailus@iki.fi \
    --cc=slongerbeam@gmail.com \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=xavier.roumegue@oss.nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.