From: Yury Norov <yury.norov@gmail.com> To: "Yury Norov" <yury.norov@gmail.com>, "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>, "Rasmus Villemoes" <linux@rasmusvillemoes.dk>, "Andrew Morton" <akpm@linux-foundation.org>, "Michał Mirosław" <mirq-linux@rere.qmqm.pl>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Peter Zijlstra" <peterz@infradead.org>, "David Laight" <David.Laight@aculab.com>, "Joe Perches" <joe@perches.com>, "Dennis Zhou" <dennis@kernel.org>, "Emil Renner Berthing" <kernel@esmil.dk>, "Nicholas Piggin" <npiggin@gmail.com>, "Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>, "Alexey Klimov" <aklimov@redhat.com>, linux-kernel@vger.kernel.org, "Andy Gross" <agross@kernel.org>, "Bjorn Andersson" <bjorn.andersson@linaro.org>, "Rafael J. Wysocki" <rafael@kernel.org>, "Viresh Kumar" <viresh.kumar@linaro.org>, "Sudeep Holla" <sudeep.holla@arm.com>, "Cristian Marussi" <cristian.marussi@arm.com>, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 17/49] cpufreq: replace cpumask_weight with cpumask_empty where appropriate Date: Thu, 10 Feb 2022 14:49:01 -0800 [thread overview] Message-ID: <20220210224933.379149-18-yury.norov@gmail.com> (raw) In-Reply-To: <20220210224933.379149-1-yury.norov@gmail.com> drivers/cpufreq calls cpumask_weight() to check if any bit of a given cpumask is set. We can do it more efficiently with cpumask_empty() because cpumask_empty() stops traversing the cpumask as soon as it finds first set bit, while cpumask_weight() counts all bits unconditionally. Signed-off-by: Yury Norov <yury.norov@gmail.com> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> (for SCMI cpufreq driver) --- drivers/cpufreq/qcom-cpufreq-hw.c | 2 +- drivers/cpufreq/scmi-cpufreq.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c index 05f3d7876e44..95a0c57ab5bb 100644 --- a/drivers/cpufreq/qcom-cpufreq-hw.c +++ b/drivers/cpufreq/qcom-cpufreq-hw.c @@ -482,7 +482,7 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy) } qcom_get_related_cpus(index, policy->cpus); - if (!cpumask_weight(policy->cpus)) { + if (cpumask_empty(policy->cpus)) { dev_err(dev, "Domain-%d failed to get related CPUs\n", index); ret = -ENOENT; goto error; diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 1e0cd4d165f0..919fa6e3f462 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -154,7 +154,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy) * table and opp-shared. */ ret = dev_pm_opp_of_get_sharing_cpus(cpu_dev, priv->opp_shared_cpus); - if (ret || !cpumask_weight(priv->opp_shared_cpus)) { + if (ret || cpumask_empty(priv->opp_shared_cpus)) { /* * Either opp-table is not set or no opp-shared was found. * Use the CPU mask from SCMI to designate CPUs sharing an OPP -- 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Yury Norov <yury.norov@gmail.com> To: "Yury Norov" <yury.norov@gmail.com>, "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>, "Rasmus Villemoes" <linux@rasmusvillemoes.dk>, "Andrew Morton" <akpm@linux-foundation.org>, "Michał Mirosław" <mirq-linux@rere.qmqm.pl>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, "Peter Zijlstra" <peterz@infradead.org>, "David Laight" <David.Laight@aculab.com>, "Joe Perches" <joe@perches.com>, "Dennis Zhou" <dennis@kernel.org>, "Emil Renner Berthing" <kernel@esmil.dk>, "Nicholas Piggin" <npiggin@gmail.com>, "Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>, "Alexey Klimov" <aklimov@redhat.com>, linux-kernel@vger.kernel.org, "Andy Gross" <agross@kernel.org>, "Bjorn Andersson" <bjorn.andersson@linaro.org>, "Rafael J. Wysocki" <rafael@kernel.org>, "Viresh Kumar" <viresh.kumar@linaro.org>, "Sudeep Holla" <sudeep.holla@arm.com>, "Cristian Marussi" <cristian.marussi@arm.com>, linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 17/49] cpufreq: replace cpumask_weight with cpumask_empty where appropriate Date: Thu, 10 Feb 2022 14:49:01 -0800 [thread overview] Message-ID: <20220210224933.379149-18-yury.norov@gmail.com> (raw) In-Reply-To: <20220210224933.379149-1-yury.norov@gmail.com> drivers/cpufreq calls cpumask_weight() to check if any bit of a given cpumask is set. We can do it more efficiently with cpumask_empty() because cpumask_empty() stops traversing the cpumask as soon as it finds first set bit, while cpumask_weight() counts all bits unconditionally. Signed-off-by: Yury Norov <yury.norov@gmail.com> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> (for SCMI cpufreq driver) --- drivers/cpufreq/qcom-cpufreq-hw.c | 2 +- drivers/cpufreq/scmi-cpufreq.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c index 05f3d7876e44..95a0c57ab5bb 100644 --- a/drivers/cpufreq/qcom-cpufreq-hw.c +++ b/drivers/cpufreq/qcom-cpufreq-hw.c @@ -482,7 +482,7 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy) } qcom_get_related_cpus(index, policy->cpus); - if (!cpumask_weight(policy->cpus)) { + if (cpumask_empty(policy->cpus)) { dev_err(dev, "Domain-%d failed to get related CPUs\n", index); ret = -ENOENT; goto error; diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 1e0cd4d165f0..919fa6e3f462 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -154,7 +154,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy) * table and opp-shared. */ ret = dev_pm_opp_of_get_sharing_cpus(cpu_dev, priv->opp_shared_cpus); - if (ret || !cpumask_weight(priv->opp_shared_cpus)) { + if (ret || cpumask_empty(priv->opp_shared_cpus)) { /* * Either opp-table is not set or no opp-shared was found. * Use the CPU mask from SCMI to designate CPUs sharing an OPP -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-10 23:29 UTC|newest] Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-10 22:48 [PATCH v4 00/49] bitmap: optimize bitmap_weight() usage Yury Norov 2022-02-10 22:48 ` [PATCH 01/49] net: dsa: don't use bitmap_weight() in b53_arl_read() Yury Norov 2022-02-10 22:48 ` [PATCH 02/49] net: systemport: don't use bitmap_weight() in bcm_sysport_rule_set() Yury Norov 2022-02-10 22:48 ` [PATCH 03/49] net: mellanox: fix open-coded for_each_set_bit() Yury Norov 2022-02-11 9:01 ` David Laight 2022-02-10 22:48 ` [PATCH 04/49] iio: fix opencoded for_each_set_bit() Yury Norov 2022-02-11 8:45 ` Andy Shevchenko 2022-02-11 17:17 ` Christophe JAILLET 2022-06-04 15:41 ` Jonathan Cameron 2022-06-11 13:50 ` Jonathan Cameron 2022-02-10 22:48 ` [RFC PATCH 05/49] qed: rework qed_rdma_bmap_free() Yury Norov 2022-02-11 8:48 ` Andy Shevchenko 2022-02-10 22:48 ` [PATCH 06/49] nds32: perf: replace bitmap_weight with bitmap_empty where appropriate Yury Norov 2022-02-10 22:48 ` [PATCH 07/49] KVM: x86: " Yury Norov 2022-02-11 16:34 ` Sean Christopherson 2022-02-11 17:13 ` Christophe JAILLET 2022-02-11 17:19 ` Sean Christopherson 2022-02-11 17:47 ` Yury Norov 2022-02-10 22:48 ` [PATCH 08/49] drm: " Yury Norov 2022-02-11 2:11 ` Dmitry Baryshkov 2022-02-11 2:11 ` Dmitry Baryshkov 2022-02-10 22:48 ` [PATCH 09/49] ice: replace bitmap_weight with bitmap_empty Yury Norov 2022-02-10 22:48 ` [Intel-wired-lan] " Yury Norov 2022-02-10 22:48 ` [PATCH 10/49] octeontx2-pf: replace bitmap_weight with bitmap_empty where appropriate Yury Norov 2022-02-10 22:48 ` [PATCH 11/49] qed: replace bitmap_weight with bitmap_empty in qed_roce_stop() Yury Norov 2022-02-10 22:48 ` [PATCH 12/49] perf: replace bitmap_weight with bitmap_empty where appropriate Yury Norov 2022-02-10 22:48 ` Yury Norov 2022-02-11 10:25 ` Mark Rutland 2022-02-11 10:25 ` Mark Rutland 2022-02-11 17:59 ` Yury Norov 2022-02-11 17:59 ` Yury Norov 2022-02-11 17:27 ` Christophe JAILLET 2022-02-11 17:27 ` Christophe JAILLET 2022-02-11 23:23 ` Yury Norov 2022-02-11 23:23 ` Yury Norov 2022-02-10 22:48 ` [PATCH 13/49] perf tools: " Yury Norov 2022-02-10 22:48 ` [PATCH 14/49] arch/alpha: replace cpumask_weight with cpumask_empty " Yury Norov 2022-02-10 22:48 ` Yury Norov 2022-02-10 22:48 ` [PATCH 15/49] arch/ia64: " Yury Norov 2022-02-10 22:48 ` Yury Norov 2022-02-10 22:49 ` [PATCH 16/49] arch/x86: " Yury Norov 2022-02-10 22:49 ` [Nouveau] " Yury Norov 2022-04-10 20:42 ` [tip: x86/cleanups] x86: Replace cpumask_weight() with cpumask_empty() " tip-bot2 for Yury Norov 2022-02-10 22:49 ` Yury Norov [this message] 2022-02-10 22:49 ` [PATCH 17/49] cpufreq: replace cpumask_weight with cpumask_empty " Yury Norov 2022-02-11 4:30 ` Viresh Kumar 2022-02-11 4:30 ` Viresh Kumar 2022-02-11 5:17 ` Yury Norov 2022-02-11 5:17 ` Yury Norov 2022-02-10 22:49 ` [PATCH 18/49] drm/i915/pmu: " Yury Norov 2022-02-10 22:49 ` [Intel-gfx] " Yury Norov 2022-02-10 22:49 ` [PATCH 19/49] RDMA/hfi: " Yury Norov 2022-02-11 19:10 ` Jason Gunthorpe 2022-02-10 22:49 ` [PATCH 20/49] irq: mips: " Yury Norov 2022-04-10 20:34 ` [tip: irq/core] irqchip/bmips: Replace cpumask_weight() with cpumask_empty() tip-bot2 for Yury Norov 2022-02-10 22:49 ` [PATCH 21/49] genirq/affinity: replace cpumask_weight with cpumask_empty where appropriate Yury Norov 2022-04-10 20:27 ` [tip: irq/core] genirq/affinity: Replace cpumask_weight() with cpumask_empty() " tip-bot2 for Yury Norov [not found] ` <573841649622719@mail.yandex.com> 2022-04-10 21:17 ` Yury Norov 2022-02-10 22:49 ` [PATCH 22/49] sched: replace cpumask_weight with cpumask_empty " Yury Norov 2022-02-11 10:19 ` Peter Zijlstra 2022-02-11 14:19 ` Yury Norov 2022-02-17 18:56 ` [tip: sched/core] " tip-bot2 for Yury Norov 2022-02-10 22:49 ` [PATCH 23/49] clocksource: replace cpumask_weight with cpumask_empty in clocksource.c Yury Norov 2022-04-10 20:35 ` [tip: timers/core] clocksource: Replace cpumask_weight() with cpumask_empty() tip-bot2 for Yury Norov 2022-02-10 22:49 ` [PATCH 24/49] mm/vmstat: replace cpumask_weight with cpumask_empty where appropriate Yury Norov 2022-02-11 10:39 ` Mike Rapoport 2022-02-10 22:49 ` [PATCH 25/49] arch/x86: replace nodes_weight with nodes_empty " Yury Norov 2022-04-10 20:42 ` [tip: x86/cleanups] x86/mm: Replace nodes_weight() with nodes_empty() " tip-bot2 for Yury Norov 2022-02-10 22:49 ` [PATCH 26/49] bitmap: add bitmap_weight_{cmp, eq, gt, ge, lt, le} functions Yury Norov 2022-02-10 22:49 ` [PATCH 27/49] arch/x86: replace bitmap_weight with bitmap_weight_{eq,gt,ge,lt,le} where appropriate Yury Norov 2022-02-10 22:49 ` [PATCH 28/49] iio: replace bitmap_weight() with bitmap_weight_{eq,gt} " Yury Norov 2022-02-10 22:49 ` [Intel-wired-lan] [PATCH 28/49] iio: replace bitmap_weight() with bitmap_weight_{eq, gt} " Yury Norov 2022-02-10 22:49 ` [PATCH 29/49] memstick: replace bitmap_weight with bitmap_weight_eq " Yury Norov 2022-02-17 15:39 ` Ulf Hansson 2022-02-17 16:55 ` Yury Norov 2022-02-22 15:49 ` Ulf Hansson 2022-02-10 22:49 ` [PATCH 30/49] ixgbe: replace bitmap_weight with bitmap_weight_eq Yury Norov 2022-02-10 22:49 ` [Intel-wired-lan] " Yury Norov 2022-02-10 22:49 ` [PATCH 31/49] octeontx2-pf: replace bitmap_weight with bitmap_weight_{eq,gt} Yury Norov 2022-02-10 22:49 ` [PATCH 32/49] mlx4: replace bitmap_weight with bitmap_weight_{eq,gt,ge,lt,le} Yury Norov 2022-02-10 22:49 ` [PATCH 33/49] perf: replace bitmap_weight with bitmap_weight_eq for ThunderX2 Yury Norov 2022-02-10 22:49 ` Yury Norov 2022-02-11 10:30 ` Mark Rutland 2022-02-11 10:30 ` Mark Rutland 2022-02-10 22:49 ` [PATCH 34/49] media: tegra-video: replace bitmap_weight with bitmap_weight_le Yury Norov 2022-04-28 7:31 ` Hans Verkuil 2022-02-10 22:49 ` [PATCH 35/49] cpumask: add cpumask_weight_{eq,gt,ge,lt,le} Yury Norov 2022-02-10 22:49 ` [PATCH 36/49] arch/ia64: replace cpumask_weight with cpumask_weight_eq in mm/tlb.c Yury Norov 2022-02-10 22:49 ` Yury Norov 2022-02-10 22:49 ` [PATCH 37/49] arch/mips: replace cpumask_weight with cpumask_weight_{eq, ...} where appropriate Yury Norov 2022-02-10 22:49 ` [PATCH 38/49] arch/powerpc: " Yury Norov 2022-02-11 4:10 ` Michael Ellerman 2022-02-10 22:49 ` [PATCH 39/49] arch/s390: replace cpumask_weight with cpumask_weight_eq " Yury Norov 2022-02-11 6:54 ` Sven Schnelle 2022-02-11 23:40 ` Yury Norov 2022-02-10 22:49 ` [PATCH 40/49] firmware: pcsi: replace cpumask_weight with cpumask_weight_eq Yury Norov 2022-02-10 22:49 ` Yury Norov 2022-02-11 9:45 ` Sudeep Holla 2022-02-11 9:45 ` Sudeep Holla 2022-02-11 10:32 ` Mark Rutland 2022-02-11 10:32 ` Mark Rutland 2022-02-10 22:49 ` [PATCH 41/49] RDMA/hfi1: replace cpumask_weight with cpumask_weight_{eq, ...} where appropriate Yury Norov 2022-02-11 19:11 ` Jason Gunthorpe 2022-02-10 22:49 ` [PATCH 42/49] scsi: lpfc: replace cpumask_weight with cpumask_weight_gt Yury Norov 2022-02-10 22:49 ` [PATCH 43/49] soc/qman: replace cpumask_weight with cpumask_weight_lt Yury Norov 2022-02-10 22:49 ` Yury Norov 2022-02-10 22:49 ` [PATCH 44/49] nodemask: add nodemask_weight_{eq,gt,ge,lt,le} Yury Norov 2022-02-10 22:49 ` [PATCH 45/49] ACPI: replace nodes__weight with nodes_weight_ge for numa Yury Norov 2022-02-14 19:18 ` Rafael J. Wysocki 2022-02-14 19:34 ` Yury Norov 2022-02-14 19:45 ` Rafael J. Wysocki 2022-02-14 19:55 ` Yury Norov 2022-02-10 22:49 ` [PATCH 46/49] mm/mempolicy: replace nodes_weight with nodes_weight_eq Yury Norov 2022-02-11 10:40 ` Mike Rapoport 2022-02-11 17:44 ` Christophe JAILLET 2022-02-11 19:47 ` Yury Norov 2022-02-10 22:49 ` [PATCH 47/49] nodemask: add num_node_state_eq() Yury Norov 2022-02-11 10:41 ` Mike Rapoport 2022-02-10 22:49 ` [PATCH 48/49] tools: bitmap: sync bitmap_weight Yury Norov 2022-02-10 22:49 ` [PATCH 49/49] MAINTAINERS: add cpumask and nodemask files to BITMAP_API Yury Norov 2022-02-15 23:18 ` [PATCH v4 00/49] bitmap: optimize bitmap_weight() usage Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220210224933.379149-18-yury.norov@gmail.com \ --to=yury.norov@gmail.com \ --cc=David.Laight@aculab.com \ --cc=agross@kernel.org \ --cc=aklimov@redhat.com \ --cc=akpm@linux-foundation.org \ --cc=andriy.shevchenko@linux.intel.com \ --cc=bjorn.andersson@linaro.org \ --cc=cristian.marussi@arm.com \ --cc=dennis@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=joe@perches.com \ --cc=kernel@esmil.dk \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux@rasmusvillemoes.dk \ --cc=matti.vaittinen@fi.rohmeurope.com \ --cc=mirq-linux@rere.qmqm.pl \ --cc=npiggin@gmail.com \ --cc=peterz@infradead.org \ --cc=rafael@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.