All of lore.kernel.org
 help / color / mirror / Atom feed
From: frowand.list@gmail.com
To: Rob Herring <robh+dt@kernel.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
	Brendan Higgins <brendanhiggins@google.com>,
	Anders Roxell <anders.roxell@linaro.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] of: unittest: print pass messages at PR_INFO level
Date: Thu, 10 Feb 2022 17:08:19 -0600	[thread overview]
Message-ID: <20220210230819.3303212-1-frowand.list@gmail.com> (raw)

From: Frank Rowand <frank.rowand@sony.com>

Printing the devicetree unittest pass message for each passed test
creates much console verbosity.  The existing pass messages are
printed at loglevel KERN_DEBUG so they will not print by default.

Change default to print the pass messages at loglevel PR_INFO so
they will print with the default console loglevel.

The test community expects either a pass or a fail message for each
test in a test suite.  The messages are typically post-processed to
report pass/fail results.

Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---

One review comment to similar previous patch "of: unittest: print
pass message as same lovlevel as fail" suggested to also change
the text of the pass message to include "PASS" instead of "pass".
I would rather leave the text unchanged to minimize churn for any
existing users of the message.  It is my intention to change the
pass and fail messages to KTAP version 2 format as soon as that
version of the specification is completed.

 drivers/of/unittest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 70992103c07d..9012e6900965 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -44,7 +44,7 @@ static struct unittest_results {
 		pr_err("FAIL %s():%i " fmt, __func__, __LINE__, ##__VA_ARGS__); \
 	} else { \
 		unittest_results.passed++; \
-		pr_debug("pass %s():%i\n", __func__, __LINE__); \
+		pr_info("pass %s():%i\n", __func__, __LINE__); \
 	} \
 	failed; \
 })
-- 
Frank Rowand <frank.rowand@sony.com>


             reply	other threads:[~2022-02-10 23:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 23:08 frowand.list [this message]
2022-02-11 11:29 ` [PATCH 1/1] of: unittest: print pass messages at PR_INFO level Naresh Kamboju
2022-02-15 19:59 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220210230819.3303212-1-frowand.list@gmail.com \
    --to=frowand.list@gmail.com \
    --cc=anders.roxell@linaro.org \
    --cc=brendanhiggins@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naresh.kamboju@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.