* [PATCH 1/1] of: unittest: print pass messages at PR_INFO level
@ 2022-02-10 23:08 frowand.list
2022-02-11 11:29 ` Naresh Kamboju
2022-02-15 19:59 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: frowand.list @ 2022-02-10 23:08 UTC (permalink / raw)
To: Rob Herring
Cc: Naresh Kamboju, Brendan Higgins, Anders Roxell, devicetree, linux-kernel
From: Frank Rowand <frank.rowand@sony.com>
Printing the devicetree unittest pass message for each passed test
creates much console verbosity. The existing pass messages are
printed at loglevel KERN_DEBUG so they will not print by default.
Change default to print the pass messages at loglevel PR_INFO so
they will print with the default console loglevel.
The test community expects either a pass or a fail message for each
test in a test suite. The messages are typically post-processed to
report pass/fail results.
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
---
One review comment to similar previous patch "of: unittest: print
pass message as same lovlevel as fail" suggested to also change
the text of the pass message to include "PASS" instead of "pass".
I would rather leave the text unchanged to minimize churn for any
existing users of the message. It is my intention to change the
pass and fail messages to KTAP version 2 format as soon as that
version of the specification is completed.
drivers/of/unittest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 70992103c07d..9012e6900965 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -44,7 +44,7 @@ static struct unittest_results {
pr_err("FAIL %s():%i " fmt, __func__, __LINE__, ##__VA_ARGS__); \
} else { \
unittest_results.passed++; \
- pr_debug("pass %s():%i\n", __func__, __LINE__); \
+ pr_info("pass %s():%i\n", __func__, __LINE__); \
} \
failed; \
})
--
Frank Rowand <frank.rowand@sony.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] of: unittest: print pass messages at PR_INFO level
2022-02-10 23:08 [PATCH 1/1] of: unittest: print pass messages at PR_INFO level frowand.list
@ 2022-02-11 11:29 ` Naresh Kamboju
2022-02-15 19:59 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Naresh Kamboju @ 2022-02-11 11:29 UTC (permalink / raw)
To: frowand.list
Cc: Rob Herring, Brendan Higgins, Anders Roxell, devicetree, linux-kernel
On Fri, 11 Feb 2022 at 04:38, <frowand.list@gmail.com> wrote:
>
> From: Frank Rowand <frank.rowand@sony.com>
>
> Printing the devicetree unittest pass message for each passed test
> creates much console verbosity. The existing pass messages are
> printed at loglevel KERN_DEBUG so they will not print by default.
>
> Change default to print the pass messages at loglevel PR_INFO so
> they will print with the default console loglevel.
>
> The test community expects either a pass or a fail message for each
> test in a test suite. The messages are typically post-processed to
> report pass/fail results.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
Test log link,
https://lkft.validation.linaro.org/scheduler/job/4529628#L1697
> ---
>
> One review comment to similar previous patch "of: unittest: print
> pass message as same lovlevel as fail" suggested to also change
> the text of the pass message to include "PASS" instead of "pass".
> I would rather leave the text unchanged to minimize churn for any
> existing users of the message. It is my intention to change the
> pass and fail messages to KTAP version 2 format as soon as that
> version of the specification is completed.
>
> drivers/of/unittest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> index 70992103c07d..9012e6900965 100644
> --- a/drivers/of/unittest.c
> +++ b/drivers/of/unittest.c
> @@ -44,7 +44,7 @@ static struct unittest_results {
> pr_err("FAIL %s():%i " fmt, __func__, __LINE__, ##__VA_ARGS__); \
> } else { \
> unittest_results.passed++; \
> - pr_debug("pass %s():%i\n", __func__, __LINE__); \
> + pr_info("pass %s():%i\n", __func__, __LINE__); \
> } \
> failed; \
> })
> --
> Frank Rowand <frank.rowand@sony.com>
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] of: unittest: print pass messages at PR_INFO level
2022-02-10 23:08 [PATCH 1/1] of: unittest: print pass messages at PR_INFO level frowand.list
2022-02-11 11:29 ` Naresh Kamboju
@ 2022-02-15 19:59 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-02-15 19:59 UTC (permalink / raw)
To: frowand.list
Cc: Anders Roxell, devicetree, Brendan Higgins, Naresh Kamboju,
Rob Herring, linux-kernel
On Thu, 10 Feb 2022 17:08:19 -0600, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> Printing the devicetree unittest pass message for each passed test
> creates much console verbosity. The existing pass messages are
> printed at loglevel KERN_DEBUG so they will not print by default.
>
> Change default to print the pass messages at loglevel PR_INFO so
> they will print with the default console loglevel.
>
> The test community expects either a pass or a fail message for each
> test in a test suite. The messages are typically post-processed to
> report pass/fail results.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---
>
> One review comment to similar previous patch "of: unittest: print
> pass message as same lovlevel as fail" suggested to also change
> the text of the pass message to include "PASS" instead of "pass".
> I would rather leave the text unchanged to minimize churn for any
> existing users of the message. It is my intention to change the
> pass and fail messages to KTAP version 2 format as soon as that
> version of the specification is completed.
>
> drivers/of/unittest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-15 19:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 23:08 [PATCH 1/1] of: unittest: print pass messages at PR_INFO level frowand.list
2022-02-11 11:29 ` Naresh Kamboju
2022-02-15 19:59 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.