* drivers/net/dsa/sja1105/sja1105_main.c:1818 sja1105_fast_age() warn: should '((((1))) << port)' be a 64 bit type?
@ 2022-02-11 22:35 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-02-11 22:35 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 8120 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vladimir Oltean <vladimir.oltean@nxp.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f1baf68e1383f6ed93eb9cff2866d46562607a43
commit: 5126ec72a094bd3a721941323c48cc80c60139d9 net: dsa: sja1105: add FDB fast ageing support
date: 6 months ago
:::::: branch date: 22 hours ago
:::::: commit date: 6 months ago
config: m68k-randconfig-m031-20220211 (https://download.01.org/0day-ci/archive/20220212/202202120636.L4uDYRCZ-lkp(a)intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:1818 sja1105_fast_age() warn: should '((((1))) << port)' be a 64 bit type?
Old smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:49 sja1105_port_allow_traffic() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:57 sja1105_can_forward() warn: should '((((1))) << to)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:129 sja1105_commit_pvid() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:255 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:267 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:276 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:285 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:291 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:298 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:530 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:531 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:552 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:553 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:676 sja1105_init_l2_forwarding_params() warn: is 'table->entries' large enough for 'struct sja1105_l2_forwarding_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:809 sja1105_init_topology() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:920 sja1105_init_avb_params() warn: is 'table->entries' large enough for 'struct sja1105_avb_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:1387 sja1105_find_static_fdb_entry() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1506 sja1105et_fdb_add() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1508 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1516 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1619 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1629 sja1105pqrs_fdb_add() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1637 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1710 sja1105pqrs_fdb_del() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1779 sja1105_fdb_dump() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1871 sja1105_manage_flood_domains() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1873 sja1105_manage_flood_domains() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2367 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2368 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2372 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2682 sja1105_mgmt_xmit() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2990 sja1105_port_mcast_flood() warn: should '(((1))) << to' be a 64 bit type?
vim +1818 drivers/net/dsa/sja1105/sja1105_main.c
291d1e72b75642 Vladimir Oltean 2019-05-02 1796
5126ec72a094bd Vladimir Oltean 2021-08-08 1797 static void sja1105_fast_age(struct dsa_switch *ds, int port)
5126ec72a094bd Vladimir Oltean 2021-08-08 1798 {
5126ec72a094bd Vladimir Oltean 2021-08-08 1799 struct sja1105_private *priv = ds->priv;
5126ec72a094bd Vladimir Oltean 2021-08-08 1800 int i;
5126ec72a094bd Vladimir Oltean 2021-08-08 1801
5126ec72a094bd Vladimir Oltean 2021-08-08 1802 for (i = 0; i < SJA1105_MAX_L2_LOOKUP_COUNT; i++) {
5126ec72a094bd Vladimir Oltean 2021-08-08 1803 struct sja1105_l2_lookup_entry l2_lookup = {0};
5126ec72a094bd Vladimir Oltean 2021-08-08 1804 u8 macaddr[ETH_ALEN];
5126ec72a094bd Vladimir Oltean 2021-08-08 1805 int rc;
5126ec72a094bd Vladimir Oltean 2021-08-08 1806
5126ec72a094bd Vladimir Oltean 2021-08-08 1807 rc = sja1105_dynamic_config_read(priv, BLK_IDX_L2_LOOKUP,
5126ec72a094bd Vladimir Oltean 2021-08-08 1808 i, &l2_lookup);
5126ec72a094bd Vladimir Oltean 2021-08-08 1809 /* No fdb entry@i, not an issue */
5126ec72a094bd Vladimir Oltean 2021-08-08 1810 if (rc == -ENOENT)
5126ec72a094bd Vladimir Oltean 2021-08-08 1811 continue;
5126ec72a094bd Vladimir Oltean 2021-08-08 1812 if (rc) {
5126ec72a094bd Vladimir Oltean 2021-08-08 1813 dev_err(ds->dev, "Failed to read FDB: %pe\n",
5126ec72a094bd Vladimir Oltean 2021-08-08 1814 ERR_PTR(rc));
5126ec72a094bd Vladimir Oltean 2021-08-08 1815 return;
5126ec72a094bd Vladimir Oltean 2021-08-08 1816 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1817
5126ec72a094bd Vladimir Oltean 2021-08-08 @1818 if (!(l2_lookup.destports & BIT(port)))
5126ec72a094bd Vladimir Oltean 2021-08-08 1819 continue;
5126ec72a094bd Vladimir Oltean 2021-08-08 1820
5126ec72a094bd Vladimir Oltean 2021-08-08 1821 /* Don't delete static FDB entries */
5126ec72a094bd Vladimir Oltean 2021-08-08 1822 if (l2_lookup.lockeds)
5126ec72a094bd Vladimir Oltean 2021-08-08 1823 continue;
5126ec72a094bd Vladimir Oltean 2021-08-08 1824
5126ec72a094bd Vladimir Oltean 2021-08-08 1825 u64_to_ether_addr(l2_lookup.macaddr, macaddr);
5126ec72a094bd Vladimir Oltean 2021-08-08 1826
5126ec72a094bd Vladimir Oltean 2021-08-08 1827 rc = sja1105_fdb_del(ds, port, macaddr, l2_lookup.vlanid);
5126ec72a094bd Vladimir Oltean 2021-08-08 1828 if (rc) {
5126ec72a094bd Vladimir Oltean 2021-08-08 1829 dev_err(ds->dev,
5126ec72a094bd Vladimir Oltean 2021-08-08 1830 "Failed to delete FDB entry %pM vid %lld: %pe\n",
5126ec72a094bd Vladimir Oltean 2021-08-08 1831 macaddr, l2_lookup.vlanid, ERR_PTR(rc));
5126ec72a094bd Vladimir Oltean 2021-08-08 1832 return;
5126ec72a094bd Vladimir Oltean 2021-08-08 1833 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1834 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1835 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1836
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* drivers/net/dsa/sja1105/sja1105_main.c:1818 sja1105_fast_age() warn: should '((((1))) << port)' be a 64 bit type?
@ 2022-05-29 7:28 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-05-29 7:28 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 8081 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Vladimir Oltean <vladimir.oltean@nxp.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9d004b2f4fea97cde123e7f1939b80e77bf2e695
commit: 5126ec72a094bd3a721941323c48cc80c60139d9 net: dsa: sja1105: add FDB fast ageing support
date: 10 months ago
:::::: branch date: 27 hours ago
:::::: commit date: 10 months ago
config: arc-randconfig-m031-20220524 (https://download.01.org/0day-ci/archive/20220529/202205291521.2PGI5RQ6-lkp(a)intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:1818 sja1105_fast_age() warn: should '((((1))) << port)' be a 64 bit type?
Old smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:49 sja1105_port_allow_traffic() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:57 sja1105_can_forward() warn: should '((((1))) << to)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:129 sja1105_commit_pvid() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:255 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:267 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:276 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:285 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:291 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:298 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:530 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:531 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:552 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:553 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:676 sja1105_init_l2_forwarding_params() warn: is 'table->entries' large enough for 'struct sja1105_l2_forwarding_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:809 sja1105_init_topology() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:920 sja1105_init_avb_params() warn: is 'table->entries' large enough for 'struct sja1105_avb_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:1387 sja1105_find_static_fdb_entry() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1506 sja1105et_fdb_add() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1508 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1516 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1619 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1629 sja1105pqrs_fdb_add() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1637 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1710 sja1105pqrs_fdb_del() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1779 sja1105_fdb_dump() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1871 sja1105_manage_flood_domains() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1873 sja1105_manage_flood_domains() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2367 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2368 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2372 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2682 sja1105_mgmt_xmit() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2990 sja1105_port_mcast_flood() warn: should '(((1))) << to' be a 64 bit type?
vim +1818 drivers/net/dsa/sja1105/sja1105_main.c
291d1e72b75642 Vladimir Oltean 2019-05-02 1796
5126ec72a094bd Vladimir Oltean 2021-08-08 1797 static void sja1105_fast_age(struct dsa_switch *ds, int port)
5126ec72a094bd Vladimir Oltean 2021-08-08 1798 {
5126ec72a094bd Vladimir Oltean 2021-08-08 1799 struct sja1105_private *priv = ds->priv;
5126ec72a094bd Vladimir Oltean 2021-08-08 1800 int i;
5126ec72a094bd Vladimir Oltean 2021-08-08 1801
5126ec72a094bd Vladimir Oltean 2021-08-08 1802 for (i = 0; i < SJA1105_MAX_L2_LOOKUP_COUNT; i++) {
5126ec72a094bd Vladimir Oltean 2021-08-08 1803 struct sja1105_l2_lookup_entry l2_lookup = {0};
5126ec72a094bd Vladimir Oltean 2021-08-08 1804 u8 macaddr[ETH_ALEN];
5126ec72a094bd Vladimir Oltean 2021-08-08 1805 int rc;
5126ec72a094bd Vladimir Oltean 2021-08-08 1806
5126ec72a094bd Vladimir Oltean 2021-08-08 1807 rc = sja1105_dynamic_config_read(priv, BLK_IDX_L2_LOOKUP,
5126ec72a094bd Vladimir Oltean 2021-08-08 1808 i, &l2_lookup);
5126ec72a094bd Vladimir Oltean 2021-08-08 1809 /* No fdb entry@i, not an issue */
5126ec72a094bd Vladimir Oltean 2021-08-08 1810 if (rc == -ENOENT)
5126ec72a094bd Vladimir Oltean 2021-08-08 1811 continue;
5126ec72a094bd Vladimir Oltean 2021-08-08 1812 if (rc) {
5126ec72a094bd Vladimir Oltean 2021-08-08 1813 dev_err(ds->dev, "Failed to read FDB: %pe\n",
5126ec72a094bd Vladimir Oltean 2021-08-08 1814 ERR_PTR(rc));
5126ec72a094bd Vladimir Oltean 2021-08-08 1815 return;
5126ec72a094bd Vladimir Oltean 2021-08-08 1816 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1817
5126ec72a094bd Vladimir Oltean 2021-08-08 @1818 if (!(l2_lookup.destports & BIT(port)))
5126ec72a094bd Vladimir Oltean 2021-08-08 1819 continue;
5126ec72a094bd Vladimir Oltean 2021-08-08 1820
5126ec72a094bd Vladimir Oltean 2021-08-08 1821 /* Don't delete static FDB entries */
5126ec72a094bd Vladimir Oltean 2021-08-08 1822 if (l2_lookup.lockeds)
5126ec72a094bd Vladimir Oltean 2021-08-08 1823 continue;
5126ec72a094bd Vladimir Oltean 2021-08-08 1824
5126ec72a094bd Vladimir Oltean 2021-08-08 1825 u64_to_ether_addr(l2_lookup.macaddr, macaddr);
5126ec72a094bd Vladimir Oltean 2021-08-08 1826
5126ec72a094bd Vladimir Oltean 2021-08-08 1827 rc = sja1105_fdb_del(ds, port, macaddr, l2_lookup.vlanid);
5126ec72a094bd Vladimir Oltean 2021-08-08 1828 if (rc) {
5126ec72a094bd Vladimir Oltean 2021-08-08 1829 dev_err(ds->dev,
5126ec72a094bd Vladimir Oltean 2021-08-08 1830 "Failed to delete FDB entry %pM vid %lld: %pe\n",
5126ec72a094bd Vladimir Oltean 2021-08-08 1831 macaddr, l2_lookup.vlanid, ERR_PTR(rc));
5126ec72a094bd Vladimir Oltean 2021-08-08 1832 return;
5126ec72a094bd Vladimir Oltean 2021-08-08 1833 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1834 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1835 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1836
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 4+ messages in thread
* drivers/net/dsa/sja1105/sja1105_main.c:1818 sja1105_fast_age() warn: should '((((1))) << port)' be a 64 bit type?
@ 2021-11-16 2:27 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-11-16 2:27 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 8050 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vladimir Oltean <vladimir.oltean@nxp.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 8ab774587903771821b59471cc723bba6d893942
commit: 5126ec72a094bd3a721941323c48cc80c60139d9 net: dsa: sja1105: add FDB fast ageing support
date: 3 months ago
:::::: branch date: 23 hours ago
:::::: commit date: 3 months ago
config: i386-randconfig-m021-20211022 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:1818 sja1105_fast_age() warn: should '((((1))) << port)' be a 64 bit type?
Old smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:49 sja1105_port_allow_traffic() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:57 sja1105_can_forward() warn: should '((((1))) << to)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:129 sja1105_commit_pvid() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:255 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:267 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:276 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:285 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:291 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:298 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:530 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:531 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:552 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:553 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:676 sja1105_init_l2_forwarding_params() warn: is 'table->entries' large enough for 'struct sja1105_l2_forwarding_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:809 sja1105_init_topology() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:920 sja1105_init_avb_params() warn: is 'table->entries' large enough for 'struct sja1105_avb_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:1387 sja1105_find_static_fdb_entry() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1506 sja1105et_fdb_add() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1508 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1516 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1619 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1629 sja1105pqrs_fdb_add() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1637 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1710 sja1105pqrs_fdb_del() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1779 sja1105_fdb_dump() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1871 sja1105_manage_flood_domains() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1873 sja1105_manage_flood_domains() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2367 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2368 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2372 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2682 sja1105_mgmt_xmit() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2990 sja1105_port_mcast_flood() warn: should '(((1))) << to' be a 64 bit type?
vim +1818 drivers/net/dsa/sja1105/sja1105_main.c
291d1e72b75642 Vladimir Oltean 2019-05-02 1796
5126ec72a094bd Vladimir Oltean 2021-08-08 1797 static void sja1105_fast_age(struct dsa_switch *ds, int port)
5126ec72a094bd Vladimir Oltean 2021-08-08 1798 {
5126ec72a094bd Vladimir Oltean 2021-08-08 1799 struct sja1105_private *priv = ds->priv;
5126ec72a094bd Vladimir Oltean 2021-08-08 1800 int i;
5126ec72a094bd Vladimir Oltean 2021-08-08 1801
5126ec72a094bd Vladimir Oltean 2021-08-08 1802 for (i = 0; i < SJA1105_MAX_L2_LOOKUP_COUNT; i++) {
5126ec72a094bd Vladimir Oltean 2021-08-08 1803 struct sja1105_l2_lookup_entry l2_lookup = {0};
5126ec72a094bd Vladimir Oltean 2021-08-08 1804 u8 macaddr[ETH_ALEN];
5126ec72a094bd Vladimir Oltean 2021-08-08 1805 int rc;
5126ec72a094bd Vladimir Oltean 2021-08-08 1806
5126ec72a094bd Vladimir Oltean 2021-08-08 1807 rc = sja1105_dynamic_config_read(priv, BLK_IDX_L2_LOOKUP,
5126ec72a094bd Vladimir Oltean 2021-08-08 1808 i, &l2_lookup);
5126ec72a094bd Vladimir Oltean 2021-08-08 1809 /* No fdb entry@i, not an issue */
5126ec72a094bd Vladimir Oltean 2021-08-08 1810 if (rc == -ENOENT)
5126ec72a094bd Vladimir Oltean 2021-08-08 1811 continue;
5126ec72a094bd Vladimir Oltean 2021-08-08 1812 if (rc) {
5126ec72a094bd Vladimir Oltean 2021-08-08 1813 dev_err(ds->dev, "Failed to read FDB: %pe\n",
5126ec72a094bd Vladimir Oltean 2021-08-08 1814 ERR_PTR(rc));
5126ec72a094bd Vladimir Oltean 2021-08-08 1815 return;
5126ec72a094bd Vladimir Oltean 2021-08-08 1816 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1817
5126ec72a094bd Vladimir Oltean 2021-08-08 @1818 if (!(l2_lookup.destports & BIT(port)))
5126ec72a094bd Vladimir Oltean 2021-08-08 1819 continue;
5126ec72a094bd Vladimir Oltean 2021-08-08 1820
5126ec72a094bd Vladimir Oltean 2021-08-08 1821 /* Don't delete static FDB entries */
5126ec72a094bd Vladimir Oltean 2021-08-08 1822 if (l2_lookup.lockeds)
5126ec72a094bd Vladimir Oltean 2021-08-08 1823 continue;
5126ec72a094bd Vladimir Oltean 2021-08-08 1824
5126ec72a094bd Vladimir Oltean 2021-08-08 1825 u64_to_ether_addr(l2_lookup.macaddr, macaddr);
5126ec72a094bd Vladimir Oltean 2021-08-08 1826
5126ec72a094bd Vladimir Oltean 2021-08-08 1827 rc = sja1105_fdb_del(ds, port, macaddr, l2_lookup.vlanid);
5126ec72a094bd Vladimir Oltean 2021-08-08 1828 if (rc) {
5126ec72a094bd Vladimir Oltean 2021-08-08 1829 dev_err(ds->dev,
5126ec72a094bd Vladimir Oltean 2021-08-08 1830 "Failed to delete FDB entry %pM vid %lld: %pe\n",
5126ec72a094bd Vladimir Oltean 2021-08-08 1831 macaddr, l2_lookup.vlanid, ERR_PTR(rc));
5126ec72a094bd Vladimir Oltean 2021-08-08 1832 return;
5126ec72a094bd Vladimir Oltean 2021-08-08 1833 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1834 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1835 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1836
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36080 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* drivers/net/dsa/sja1105/sja1105_main.c:1818 sja1105_fast_age() warn: should '((((1))) << port)' be a 64 bit type?
@ 2021-11-08 23:50 kernel test robot
0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2021-11-08 23:50 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 8049 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Vladimir Oltean <vladimir.oltean@nxp.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d2f38a3c6507b2520101f9a3807ed98f1bdc545a
commit: 5126ec72a094bd3a721941323c48cc80c60139d9 net: dsa: sja1105: add FDB fast ageing support
date: 3 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 3 months ago
config: i386-randconfig-m021-20211022 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:1818 sja1105_fast_age() warn: should '((((1))) << port)' be a 64 bit type?
Old smatch warnings:
drivers/net/dsa/sja1105/sja1105_main.c:49 sja1105_port_allow_traffic() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:57 sja1105_can_forward() warn: should '((((1))) << to)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:129 sja1105_commit_pvid() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:255 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:267 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:276 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:285 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:291 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:298 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:530 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:531 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:552 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:553 sja1105_init_l2_forwarding() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:676 sja1105_init_l2_forwarding_params() warn: is 'table->entries' large enough for 'struct sja1105_l2_forwarding_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:809 sja1105_init_topology() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:920 sja1105_init_avb_params() warn: is 'table->entries' large enough for 'struct sja1105_avb_params_entry'? 0
drivers/net/dsa/sja1105/sja1105_main.c:1387 sja1105_find_static_fdb_entry() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1506 sja1105et_fdb_add() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1508 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1516 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1619 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1629 sja1105pqrs_fdb_add() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1637 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1710 sja1105pqrs_fdb_del() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1779 sja1105_fdb_dump() warn: should '((((1))) << port)' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1871 sja1105_manage_flood_domains() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:1873 sja1105_manage_flood_domains() warn: should '(((1))) << to' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2367 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2368 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2372 sja1105_vlan_add() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2682 sja1105_mgmt_xmit() warn: should '(((1))) << port' be a 64 bit type?
drivers/net/dsa/sja1105/sja1105_main.c:2990 sja1105_port_mcast_flood() warn: should '(((1))) << to' be a 64 bit type?
vim +1818 drivers/net/dsa/sja1105/sja1105_main.c
291d1e72b75642 Vladimir Oltean 2019-05-02 1796
5126ec72a094bd Vladimir Oltean 2021-08-08 1797 static void sja1105_fast_age(struct dsa_switch *ds, int port)
5126ec72a094bd Vladimir Oltean 2021-08-08 1798 {
5126ec72a094bd Vladimir Oltean 2021-08-08 1799 struct sja1105_private *priv = ds->priv;
5126ec72a094bd Vladimir Oltean 2021-08-08 1800 int i;
5126ec72a094bd Vladimir Oltean 2021-08-08 1801
5126ec72a094bd Vladimir Oltean 2021-08-08 1802 for (i = 0; i < SJA1105_MAX_L2_LOOKUP_COUNT; i++) {
5126ec72a094bd Vladimir Oltean 2021-08-08 1803 struct sja1105_l2_lookup_entry l2_lookup = {0};
5126ec72a094bd Vladimir Oltean 2021-08-08 1804 u8 macaddr[ETH_ALEN];
5126ec72a094bd Vladimir Oltean 2021-08-08 1805 int rc;
5126ec72a094bd Vladimir Oltean 2021-08-08 1806
5126ec72a094bd Vladimir Oltean 2021-08-08 1807 rc = sja1105_dynamic_config_read(priv, BLK_IDX_L2_LOOKUP,
5126ec72a094bd Vladimir Oltean 2021-08-08 1808 i, &l2_lookup);
5126ec72a094bd Vladimir Oltean 2021-08-08 1809 /* No fdb entry@i, not an issue */
5126ec72a094bd Vladimir Oltean 2021-08-08 1810 if (rc == -ENOENT)
5126ec72a094bd Vladimir Oltean 2021-08-08 1811 continue;
5126ec72a094bd Vladimir Oltean 2021-08-08 1812 if (rc) {
5126ec72a094bd Vladimir Oltean 2021-08-08 1813 dev_err(ds->dev, "Failed to read FDB: %pe\n",
5126ec72a094bd Vladimir Oltean 2021-08-08 1814 ERR_PTR(rc));
5126ec72a094bd Vladimir Oltean 2021-08-08 1815 return;
5126ec72a094bd Vladimir Oltean 2021-08-08 1816 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1817
5126ec72a094bd Vladimir Oltean 2021-08-08 @1818 if (!(l2_lookup.destports & BIT(port)))
5126ec72a094bd Vladimir Oltean 2021-08-08 1819 continue;
5126ec72a094bd Vladimir Oltean 2021-08-08 1820
5126ec72a094bd Vladimir Oltean 2021-08-08 1821 /* Don't delete static FDB entries */
5126ec72a094bd Vladimir Oltean 2021-08-08 1822 if (l2_lookup.lockeds)
5126ec72a094bd Vladimir Oltean 2021-08-08 1823 continue;
5126ec72a094bd Vladimir Oltean 2021-08-08 1824
5126ec72a094bd Vladimir Oltean 2021-08-08 1825 u64_to_ether_addr(l2_lookup.macaddr, macaddr);
5126ec72a094bd Vladimir Oltean 2021-08-08 1826
5126ec72a094bd Vladimir Oltean 2021-08-08 1827 rc = sja1105_fdb_del(ds, port, macaddr, l2_lookup.vlanid);
5126ec72a094bd Vladimir Oltean 2021-08-08 1828 if (rc) {
5126ec72a094bd Vladimir Oltean 2021-08-08 1829 dev_err(ds->dev,
5126ec72a094bd Vladimir Oltean 2021-08-08 1830 "Failed to delete FDB entry %pM vid %lld: %pe\n",
5126ec72a094bd Vladimir Oltean 2021-08-08 1831 macaddr, l2_lookup.vlanid, ERR_PTR(rc));
5126ec72a094bd Vladimir Oltean 2021-08-08 1832 return;
5126ec72a094bd Vladimir Oltean 2021-08-08 1833 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1834 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1835 }
5126ec72a094bd Vladimir Oltean 2021-08-08 1836
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36038 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-29 7:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-11 22:35 drivers/net/dsa/sja1105/sja1105_main.c:1818 sja1105_fast_age() warn: should '((((1))) << port)' be a 64 bit type? kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2022-05-29 7:28 kernel test robot
2021-11-16 2:27 kernel test robot
2021-11-08 23:50 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.