[PATCH BlueZ] adapter: battery provider for non-LE controllers

[PATCH BlueZ] adapter: battery provider for non-LE controllers

[Daniel Trnka]

Enable battery provider dbus interface BatteryProviderManager1 for
non-LE controllers, so external clients like pipewire can provide
battery information for bluetooth headsets on non-LE controllers.
---
 src/adapter.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/adapter.c b/src/adapter.c
index eef50f67a..2071cf8db 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -8976,6 +8976,11 @@ static int adapter_register(struct btd_adapter *adapter)
 		agent_unref(agent);
 	}
 
+	if (g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL) {
+		adapter->battery_provider_manager =
+			btd_battery_provider_manager_create(adapter);
+	}
+
 	/* Don't start GATT database and advertising managers on
 	 * non-LE controllers.
 	 */
@@ -9010,11 +9015,6 @@ static int adapter_register(struct btd_adapter *adapter)
 		}
 	}
 
-	if (g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL) {
-		adapter->battery_provider_manager =
-			btd_battery_provider_manager_create(adapter);
-	}
-
 	db = btd_gatt_database_get_db(adapter->database);
 	adapter->db_id = gatt_db_register(db, services_modified,
 							services_modified,
-- 
2.35.1

RE: [BlueZ] adapter: battery provider for non-LE controllers

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=613710

---Test result---

Test Summary:
CheckPatch                    PASS      0.58 seconds
GitLint                       PASS      0.41 seconds
Prep - Setup ELL              PASS      48.76 seconds
Build - Prep                  PASS      0.59 seconds
Build - Configure             PASS      9.52 seconds
Build - Make                  PASS      1713.11 seconds
Make Check                    PASS      11.99 seconds
Make Check w/Valgrind         PASS      520.57 seconds
Make Distcheck                PASS      267.76 seconds
Build w/ext ELL - Configure   PASS      9.52 seconds
Build w/ext ELL - Make        PASS      1682.08 seconds
Incremental Build with patchesPASS      0.00 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] adapter: battery provider for non-LE controllers

[Sonny Sasaka]

Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>

On Sat, Feb 12, 2022 at 12:48 AM Daniel Trnka <daniel.trnka@gmail.com> wrote:
>
> Enable battery provider dbus interface BatteryProviderManager1 for
> non-LE controllers, so external clients like pipewire can provide
> battery information for bluetooth headsets on non-LE controllers.
> ---
>  src/adapter.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index eef50f67a..2071cf8db 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -8976,6 +8976,11 @@ static int adapter_register(struct btd_adapter *adapter)
>                 agent_unref(agent);
>         }
>
> +       if (g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL) {
> +               adapter->battery_provider_manager =
> +                       btd_battery_provider_manager_create(adapter);
> +       }
> +
>         /* Don't start GATT database and advertising managers on
>          * non-LE controllers.
>          */
> @@ -9010,11 +9015,6 @@ static int adapter_register(struct btd_adapter *adapter)
>                 }
>         }
>
> -       if (g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL) {
> -               adapter->battery_provider_manager =
> -                       btd_battery_provider_manager_create(adapter);
> -       }
> -
>         db = btd_gatt_database_get_db(adapter->database);
>         adapter->db_id = gatt_db_register(db, services_modified,
>                                                         services_modified,
> --
> 2.35.1
>