* [xilinx-xlnx:xlnx_rebase_v5.15 541/923] drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923.
@ 2022-02-12 12:00 kernel test robot
2022-02-12 11:53 ` [PATCH] iio: adc: fix for_each_child.cocci warnings kernel test robot
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2022-02-12 12:00 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Rajnikant Bhojani <rajnikant.bhojani@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
CC: Shubhrajyoti Datta <shubhraj@xilinx.com>
CC: "Jean-Francois Dagenais" <jeff.dagenais@gmail.com>
CC: Olivier Dugas <dugaso@sonatest.com>
CC: Manish Narani <mnarani@xilinx.com>
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head: 966124532656bc95d781abf57531e4cd4f962237
commit: d073b83d3f8f3ba83c59f7502371b1cf9eb35e92 [541/923] iio: adc: Add Xilinx AMS driver
:::::: branch date: 2 days ago
:::::: commit date: 11 days ago
config: alpha-randconfig-c024-20220208 (https://download.01.org/0day-ci/archive/20220212/202202121936.2BAWavkM-lkp(a)intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923.
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] iio: adc: fix for_each_child.cocci warnings
2022-02-12 12:00 [xilinx-xlnx:xlnx_rebase_v5.15 541/923] drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923 kernel test robot
@ 2022-02-12 11:53 ` kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-02-12 11:53 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1821 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Rajnikant Bhojani <rajnikant.bhojani@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
CC: Shubhrajyoti Datta <shubhraj@xilinx.com>
CC: "Jean-Francois Dagenais" <jeff.dagenais@gmail.com>
CC: Olivier Dugas <dugaso@sonatest.com>
CC: Manish Narani <mnarani@xilinx.com>
CC: Jonathan Cameron <jic23@kernel.org>
CC: "Lars-Peter Clausen" <lars@metafoo.de>
CC: linux-iio(a)vger.kernel.org
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp@intel.com>
drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923.
Semantic patch information:
False positives can be due to function calls within the for_each
loop that may encapsulate an of_node_put.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Rajnikant Bhojani <rajnikant.bhojani@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head: 966124532656bc95d781abf57531e4cd4f962237
commit: d073b83d3f8f3ba83c59f7502371b1cf9eb35e92 [541/923] iio: adc: Add Xilinx AMS driver
:::::: branch date: 2 days ago
:::::: commit date: 11 days ago
Please take the patch only if it's a positive warning. Thanks!
xilinx-ams.c | 1 +
1 file changed, 1 insertion(+)
--- a/drivers/iio/adc/xilinx-ams.c
+++ b/drivers/iio/adc/xilinx-ams.c
@@ -920,6 +920,7 @@ static int ams_parse_dt(struct iio_dev *
ams_channels + num_channels);
if (ret < 0) {
kfree(ams_channels);
+ of_node_put(child_node);
return ret;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* [xilinx-xlnx:xlnx_rebase_v5.15 541/923] drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923.
@ 2022-02-14 12:34 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-02-14 12:34 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]
CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Rajnikant Bhojani <rajnikant.bhojani@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
CC: Shubhrajyoti Datta <shubhraj@xilinx.com>
CC: "Jean-Francois Dagenais" <jeff.dagenais@gmail.com>
CC: Olivier Dugas <dugaso@sonatest.com>
CC: Manish Narani <mnarani@xilinx.com>
tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head: 966124532656bc95d781abf57531e4cd4f962237
commit: d073b83d3f8f3ba83c59f7502371b1cf9eb35e92 [541/923] iio: adc: Add Xilinx AMS driver
:::::: branch date: 4 days ago
:::::: commit date: 13 days ago
config: alpha-randconfig-c024-20220208 (https://download.01.org/0day-ci/archive/20220214/202202142056.7QsyMcEo-lkp(a)intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923.
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-14 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-12 12:00 [xilinx-xlnx:xlnx_rebase_v5.15 541/923] drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923 kernel test robot
2022-02-12 11:53 ` [PATCH] iio: adc: fix for_each_child.cocci warnings kernel test robot
2022-02-14 12:34 [xilinx-xlnx:xlnx_rebase_v5.15 541/923] drivers/iio/adc/xilinx-ams.c:917:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before return around line 923 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.