All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm: xlnx: sdi: fix for_each_child.cocci warnings
  2022-02-13  5:44 [xilinx-xlnx:xlnx_rebase_v5.15 635/923] drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1325 kernel test robot
@ 2022-02-13  5:40 ` kernel test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2022-02-13  5:40 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Saurabh Sengar <saurabh.singh@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: dri-devel(a)lists.freedesktop.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1325.
drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1333.


Semantic patch information:
 False positives can be due to function calls within the for_each
 loop that may encapsulate an of_node_put.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Saurabh Sengar <saurabh.singh@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   966124532656bc95d781abf57531e4cd4f962237
commit: eedc9b61ce549e6a1af512cc21dfd7fa487d0823 [635/923] drm: xlnx: sdi: Adding sdi-tx driver
:::::: branch date: 3 days ago
:::::: commit date: 12 days ago

Please take the patch only if it's a positive warning. Thanks!

 xlnx_sdi.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/gpu/drm/xlnx/xlnx_sdi.c
+++ b/drivers/gpu/drm/xlnx/xlnx_sdi.c
@@ -1322,6 +1322,7 @@ static int xlnx_sdi_probe(struct platfor
 			dev_err(dev, "No remote port at %s\n", port->name);
 			of_node_put(endpoint);
 			ret = -EINVAL;
+			of_node_put(port);
 			goto err_disable_vidin_clk;
 		}
 
@@ -1330,6 +1331,7 @@ static int xlnx_sdi_probe(struct platfor
 		ret = of_property_read_u32(port, "reg", &index);
 		if (ret) {
 			dev_err(dev, "reg property not present - %d\n", ret);
+			of_node_put(port);
 			goto err_disable_vidin_clk;
 		}
 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [xilinx-xlnx:xlnx_rebase_v5.15 635/923] drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1325.
@ 2022-02-13  5:44 kernel test robot
  2022-02-13  5:40 ` [PATCH] drm: xlnx: sdi: fix for_each_child.cocci warnings kernel test robot
  0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2022-02-13  5:44 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Saurabh Sengar <saurabh.singh@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   966124532656bc95d781abf57531e4cd4f962237
commit: eedc9b61ce549e6a1af512cc21dfd7fa487d0823 [635/923] drm: xlnx: sdi: Adding sdi-tx driver
:::::: branch date: 3 days ago
:::::: commit date: 12 days ago
config: alpha-randconfig-c024-20220208 (https://download.01.org/0day-ci/archive/20220213/202202131335.2EfKfFom-lkp(a)intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1325.
   drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1333.

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] drm: xlnx: sdi: fix for_each_child.cocci warnings
  2022-06-28 13:18 [xilinx-xlnx:xlnx_rebase_v5.15_LTS 635/1197] drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1325 kernel test robot
@ 2022-06-28 13:01 ` kernel test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2022-06-28 13:01 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2122 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-arm-kernel(a)lists.infradead.org
TO: Saurabh Sengar <saurabh.singh@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: dri-devel(a)lists.freedesktop.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1325.
drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1333.


Semantic patch information:
 False positives can be due to function calls within the for_each
 loop that may encapsulate an of_node_put.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Saurabh Sengar <saurabh.singh@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15_LTS
head:   1e67f149fb5eb4f5eb4e0d4f69194eac6d2497d7
commit: eedc9b61ce549e6a1af512cc21dfd7fa487d0823 [635/1197] drm: xlnx: sdi: Adding sdi-tx driver
:::::: branch date: 8 days ago
:::::: commit date: 5 months ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/gpu/drm/xlnx/xlnx_sdi.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/gpu/drm/xlnx/xlnx_sdi.c
+++ b/drivers/gpu/drm/xlnx/xlnx_sdi.c
@@ -1322,6 +1322,7 @@ static int xlnx_sdi_probe(struct platfor
 			dev_err(dev, "No remote port at %s\n", port->name);
 			of_node_put(endpoint);
 			ret = -EINVAL;
+			of_node_put(port);
 			goto err_disable_vidin_clk;
 		}
 
@@ -1330,6 +1331,7 @@ static int xlnx_sdi_probe(struct platfor
 		ret = of_property_read_u32(port, "reg", &index);
 		if (ret) {
 			dev_err(dev, "reg property not present - %d\n", ret);
+			of_node_put(port);
 			goto err_disable_vidin_clk;
 		}
 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] drm: xlnx: sdi: fix for_each_child.cocci warnings
  2022-02-10  3:03 [xilinx-xlnx:xlnx_rebase_v5.15 635/907] drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1325 kernel test robot
@ 2022-02-10  2:58 ` kernel test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2022-02-10  2:58 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2074 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Saurabh Sengar <saurabh.singh@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: dri-devel(a)lists.freedesktop.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1325.
drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1333.


Semantic patch information:
 False positives can be due to function calls within the for_each
 loop that may encapsulate an of_node_put.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

CC: Saurabh Sengar <saurabh.singh@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15
head:   423a108a01e05e84b59a4c4885c16bf3cd8c90c7
commit: eedc9b61ce549e6a1af512cc21dfd7fa487d0823 [635/907] drm: xlnx: sdi: Adding sdi-tx driver
:::::: branch date: 17 hours ago
:::::: commit date: 9 days ago

Please take the patch only if it's a positive warning. Thanks!

 xlnx_sdi.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/gpu/drm/xlnx/xlnx_sdi.c
+++ b/drivers/gpu/drm/xlnx/xlnx_sdi.c
@@ -1322,6 +1322,7 @@ static int xlnx_sdi_probe(struct platfor
 			dev_err(dev, "No remote port at %s\n", port->name);
 			of_node_put(endpoint);
 			ret = -EINVAL;
+			of_node_put(port);
 			goto err_disable_vidin_clk;
 		}
 
@@ -1330,6 +1331,7 @@ static int xlnx_sdi_probe(struct platfor
 		ret = of_property_read_u32(port, "reg", &index);
 		if (ret) {
 			dev_err(dev, "reg property not present - %d\n", ret);
+			of_node_put(port);
 			goto err_disable_vidin_clk;
 		}
 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] drm: xlnx: sdi: fix for_each_child.cocci warnings
  2021-07-14 17:03 [xlnx:xlnx_rebase_v5.10 478/1756] drivers/gpu/drm/xlnx/xlnx_sdi.c:1098:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1112 kernel test robot
@ 2021-07-14 17:03 ` kernel test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2021-07-14 17:03 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2145 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-arm-kernel(a)lists.infradead.org
TO: Vishal Sagar <vishal.sagar@xilinx.com>
CC: Michal Simek <monstr@monstr.eu>
CC: Hyun Kwon <hyun.kwon@xilinx.com>
CC: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: dri-devel(a)lists.freedesktop.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/xlnx/xlnx_sdi.c:1098:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1112.
drivers/gpu/drm/xlnx/xlnx_sdi.c:1098:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1120.


Semantic patch information:
 False positives can be due to function calls within the for_each
 loop that may encapsulate an of_node_put.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: a43ca56eb122 ("drm: xlnx: sdi: Add clock framework support")
CC: Vishal Sagar <vishal.sagar@xilinx.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.10
head:   f6f032f82f0a13def702a0154df535db88f43391
commit: a43ca56eb1228aed11dd81e74a8138684ca3bac9 [478/1756] drm: xlnx: sdi: Add clock framework support
:::::: branch date: 9 hours ago
:::::: commit date: 7 weeks ago

Please take the patch only if it's a positive warning. Thanks!

 xlnx_sdi.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/gpu/drm/xlnx/xlnx_sdi.c
+++ b/drivers/gpu/drm/xlnx/xlnx_sdi.c
@@ -1109,6 +1109,7 @@ static int xlnx_sdi_probe(struct platfor
 			dev_err(dev, "No remote port at %s\n", port->name);
 			of_node_put(endpoint);
 			ret = -EINVAL;
+			of_node_put(port);
 			goto err_disable_vidin_clk;
 		}
 
@@ -1117,6 +1118,7 @@ static int xlnx_sdi_probe(struct platfor
 		ret = of_property_read_u32(port, "reg", &index);
 		if (ret) {
 			dev_err(dev, "reg property not present - %d\n", ret);
+			of_node_put(port);
 			goto err_disable_vidin_clk;
 		}
 

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-28 13:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-13  5:44 [xilinx-xlnx:xlnx_rebase_v5.15 635/923] drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1325 kernel test robot
2022-02-13  5:40 ` [PATCH] drm: xlnx: sdi: fix for_each_child.cocci warnings kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2022-06-28 13:18 [xilinx-xlnx:xlnx_rebase_v5.15_LTS 635/1197] drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1325 kernel test robot
2022-06-28 13:01 ` [PATCH] drm: xlnx: sdi: fix for_each_child.cocci warnings kernel test robot
2022-02-10  3:03 [xilinx-xlnx:xlnx_rebase_v5.15 635/907] drivers/gpu/drm/xlnx/xlnx_sdi.c:1311:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1325 kernel test robot
2022-02-10  2:58 ` [PATCH] drm: xlnx: sdi: fix for_each_child.cocci warnings kernel test robot
2021-07-14 17:03 [xlnx:xlnx_rebase_v5.10 478/1756] drivers/gpu/drm/xlnx/xlnx_sdi.c:1098:1-23: WARNING: Function "for_each_child_of_node" should have of_node_put() before goto around lines 1112 kernel test robot
2021-07-14 17:03 ` [PATCH] drm: xlnx: sdi: fix for_each_child.cocci warnings kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.