* [PATCH] i2c: brcmstb: fix support for DSL and CM variants
@ 2022-02-15 7:27 ` Rafał Miłecki
0 siblings, 0 replies; 6+ messages in thread
From: Rafał Miłecki @ 2022-02-15 7:27 UTC (permalink / raw)
To: Wolfram Sang
Cc: Kamal Dasu, Florian Fainelli, linux-i2c, linux-arm-kernel,
bcm-kernel-feedback-list, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
DSL and CM (Cable Modem) support 8 B max transfer size and have a custom
DT binding for that reason. This driver was checking for a wrong
"compatible" however which resulted in an incorrect setup.
Fixes: e2e5a2c61837 ("i2c: brcmstb: Adding support for CM and DSL SoCs")
Cc: Kamal Dasu <kdasu.kdev@gmail.com>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/i2c/busses/i2c-brcmstb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcmstb.c
index 490ee3962645..b00f35c0b066 100644
--- a/drivers/i2c/busses/i2c-brcmstb.c
+++ b/drivers/i2c/busses/i2c-brcmstb.c
@@ -673,7 +673,7 @@ static int brcmstb_i2c_probe(struct platform_device *pdev)
/* set the data in/out register size for compatible SoCs */
if (of_device_is_compatible(dev->device->of_node,
- "brcmstb,brcmper-i2c"))
+ "brcm,brcmper-i2c"))
dev->data_regsz = sizeof(u8);
else
dev->data_regsz = sizeof(u32);
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] i2c: brcmstb: fix support for DSL and CM variants
@ 2022-02-15 7:27 ` Rafał Miłecki
0 siblings, 0 replies; 6+ messages in thread
From: Rafał Miłecki @ 2022-02-15 7:27 UTC (permalink / raw)
To: Wolfram Sang
Cc: Kamal Dasu, Florian Fainelli, linux-i2c, linux-arm-kernel,
bcm-kernel-feedback-list, Rafał Miłecki
From: Rafał Miłecki <rafal@milecki.pl>
DSL and CM (Cable Modem) support 8 B max transfer size and have a custom
DT binding for that reason. This driver was checking for a wrong
"compatible" however which resulted in an incorrect setup.
Fixes: e2e5a2c61837 ("i2c: brcmstb: Adding support for CM and DSL SoCs")
Cc: Kamal Dasu <kdasu.kdev@gmail.com>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
drivers/i2c/busses/i2c-brcmstb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcmstb.c
index 490ee3962645..b00f35c0b066 100644
--- a/drivers/i2c/busses/i2c-brcmstb.c
+++ b/drivers/i2c/busses/i2c-brcmstb.c
@@ -673,7 +673,7 @@ static int brcmstb_i2c_probe(struct platform_device *pdev)
/* set the data in/out register size for compatible SoCs */
if (of_device_is_compatible(dev->device->of_node,
- "brcmstb,brcmper-i2c"))
+ "brcm,brcmper-i2c"))
dev->data_regsz = sizeof(u8);
else
dev->data_regsz = sizeof(u32);
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: brcmstb: fix support for DSL and CM variants
2022-02-15 7:27 ` Rafał Miłecki
@ 2022-02-15 16:10 ` Florian Fainelli
-1 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2022-02-15 16:10 UTC (permalink / raw)
To: Rafał Miłecki, Wolfram Sang
Cc: Kamal Dasu, Florian Fainelli, linux-i2c, linux-arm-kernel,
bcm-kernel-feedback-list, Rafał Miłecki
On 2/14/2022 11:27 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> DSL and CM (Cable Modem) support 8 B max transfer size and have a custom
> DT binding for that reason. This driver was checking for a wrong
> "compatible" however which resulted in an incorrect setup.
>
> Fixes: e2e5a2c61837 ("i2c: brcmstb: Adding support for CM and DSL SoCs")
> Cc: Kamal Dasu <kdasu.kdev@gmail.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: brcmstb: fix support for DSL and CM variants
@ 2022-02-15 16:10 ` Florian Fainelli
0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2022-02-15 16:10 UTC (permalink / raw)
To: Rafał Miłecki, Wolfram Sang
Cc: Kamal Dasu, Florian Fainelli, linux-i2c, linux-arm-kernel,
bcm-kernel-feedback-list, Rafał Miłecki
On 2/14/2022 11:27 PM, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> DSL and CM (Cable Modem) support 8 B max transfer size and have a custom
> DT binding for that reason. This driver was checking for a wrong
> "compatible" however which resulted in an incorrect setup.
>
> Fixes: e2e5a2c61837 ("i2c: brcmstb: Adding support for CM and DSL SoCs")
> Cc: Kamal Dasu <kdasu.kdev@gmail.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: brcmstb: fix support for DSL and CM variants
2022-02-15 7:27 ` Rafał Miłecki
@ 2022-02-18 9:41 ` Wolfram Sang
-1 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2022-02-18 9:41 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Kamal Dasu, Florian Fainelli, linux-i2c, linux-arm-kernel,
bcm-kernel-feedback-list, Rafał Miłecki
[-- Attachment #1: Type: text/plain, Size: 531 bytes --]
On Tue, Feb 15, 2022 at 08:27:35AM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> DSL and CM (Cable Modem) support 8 B max transfer size and have a custom
> DT binding for that reason. This driver was checking for a wrong
> "compatible" however which resulted in an incorrect setup.
>
> Fixes: e2e5a2c61837 ("i2c: brcmstb: Adding support for CM and DSL SoCs")
> Cc: Kamal Dasu <kdasu.kdev@gmail.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i2c: brcmstb: fix support for DSL and CM variants
@ 2022-02-18 9:41 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2022-02-18 9:41 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Kamal Dasu, Florian Fainelli, linux-i2c, linux-arm-kernel,
bcm-kernel-feedback-list, Rafał Miłecki
[-- Attachment #1.1: Type: text/plain, Size: 531 bytes --]
On Tue, Feb 15, 2022 at 08:27:35AM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> DSL and CM (Cable Modem) support 8 B max transfer size and have a custom
> DT binding for that reason. This driver was checking for a wrong
> "compatible" however which resulted in an incorrect setup.
>
> Fixes: e2e5a2c61837 ("i2c: brcmstb: Adding support for CM and DSL SoCs")
> Cc: Kamal Dasu <kdasu.kdev@gmail.com>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Applied to for-current, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-18 9:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15 7:27 [PATCH] i2c: brcmstb: fix support for DSL and CM variants Rafał Miłecki
2022-02-15 7:27 ` Rafał Miłecki
2022-02-15 16:10 ` Florian Fainelli
2022-02-15 16:10 ` Florian Fainelli
2022-02-18 9:41 ` Wolfram Sang
2022-02-18 9:41 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.