From: Geert Uytterhoeven <geert@linux-m68k.org> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Helge Deller <deller@gmx.de>, Javier Martinez Canillas <javierm@redhat.com> Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org> Subject: [PATCH 4/8] drm/client: Use actual bpp when allocating frame buffers Date: Tue, 15 Feb 2022 17:52:22 +0100 [thread overview] Message-ID: <20220215165226.2738568-5-geert@linux-m68k.org> (raw) In-Reply-To: <20220215165226.2738568-1-geert@linux-m68k.org> When allocating a frame buffer, the number of bits per pixel needed is derived from the deprecated drm_format_info.cpp[] field. While this works for formats using less than 8 bits per pixel, it does lead to a large overallocation. Reduce memory consumption by using the actual number of bits per pixel instead. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/gpu/drm/drm_client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c index ce45e380f4a2028f..c6a279e3de95591a 100644 --- a/drivers/gpu/drm/drm_client.c +++ b/drivers/gpu/drm/drm_client.c @@ -264,7 +264,7 @@ drm_client_buffer_create(struct drm_client_dev *client, u32 width, u32 height, u dumb_args.width = width; dumb_args.height = height; - dumb_args.bpp = info->cpp[0] * 8; + dumb_args.bpp = drm_format_info_bpp(info, 0); ret = drm_mode_create_dumb(dev, &dumb_args, client->file); if (ret) goto err_delete; @@ -372,7 +372,7 @@ static int drm_client_buffer_addfb(struct drm_client_buffer *buffer, int ret; info = drm_format_info(format); - fb_req.bpp = info->cpp[0] * 8; + fb_req.bpp = drm_format_info_bpp(info, 0); fb_req.depth = info->depth; fb_req.width = width; fb_req.height = height; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org> To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Helge Deller <deller@gmx.de>, Javier Martinez Canillas <javierm@redhat.com> Cc: linux-fbdev@vger.kernel.org, Geert Uytterhoeven <geert@linux-m68k.org>, linux-m68k@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/8] drm/client: Use actual bpp when allocating frame buffers Date: Tue, 15 Feb 2022 17:52:22 +0100 [thread overview] Message-ID: <20220215165226.2738568-5-geert@linux-m68k.org> (raw) In-Reply-To: <20220215165226.2738568-1-geert@linux-m68k.org> When allocating a frame buffer, the number of bits per pixel needed is derived from the deprecated drm_format_info.cpp[] field. While this works for formats using less than 8 bits per pixel, it does lead to a large overallocation. Reduce memory consumption by using the actual number of bits per pixel instead. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- drivers/gpu/drm/drm_client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c index ce45e380f4a2028f..c6a279e3de95591a 100644 --- a/drivers/gpu/drm/drm_client.c +++ b/drivers/gpu/drm/drm_client.c @@ -264,7 +264,7 @@ drm_client_buffer_create(struct drm_client_dev *client, u32 width, u32 height, u dumb_args.width = width; dumb_args.height = height; - dumb_args.bpp = info->cpp[0] * 8; + dumb_args.bpp = drm_format_info_bpp(info, 0); ret = drm_mode_create_dumb(dev, &dumb_args, client->file); if (ret) goto err_delete; @@ -372,7 +372,7 @@ static int drm_client_buffer_addfb(struct drm_client_buffer *buffer, int ret; info = drm_format_info(format); - fb_req.bpp = info->cpp[0] * 8; + fb_req.bpp = drm_format_info_bpp(info, 0); fb_req.depth = info->depth; fb_req.width = width; fb_req.height = height; -- 2.25.1
next prev parent reply other threads:[~2022-02-15 16:52 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-15 16:52 [PATCH 0/8] drm: Add support for low-color frame buffer formats Geert Uytterhoeven 2022-02-15 16:52 ` Geert Uytterhoeven 2022-02-15 16:52 ` [PATCH 1/8] drm/fourcc: Add DRM_FORMAT_C[124] Geert Uytterhoeven 2022-02-15 16:52 ` Geert Uytterhoeven 2022-02-17 9:46 ` Pekka Paalanen 2022-02-17 9:46 ` Pekka Paalanen 2022-02-15 16:52 ` [PATCH 2/8] drm/fb-helper: Add support for DRM_FORMAT_C[124] Geert Uytterhoeven 2022-02-15 16:52 ` Geert Uytterhoeven 2022-02-17 14:57 ` Thomas Zimmermann 2022-02-17 14:57 ` Thomas Zimmermann 2022-02-17 16:12 ` Geert Uytterhoeven 2022-02-17 16:12 ` Geert Uytterhoeven 2022-02-17 16:18 ` Simon Ser 2022-02-17 16:18 ` Simon Ser 2022-02-17 17:21 ` Geert Uytterhoeven 2022-02-17 17:21 ` Geert Uytterhoeven 2022-02-17 20:34 ` Sam Ravnborg 2022-02-17 20:34 ` Sam Ravnborg 2022-02-18 8:14 ` Thomas Zimmermann 2022-02-18 8:14 ` Thomas Zimmermann 2022-02-18 8:53 ` Geert Uytterhoeven 2022-02-18 8:53 ` Geert Uytterhoeven 2022-02-15 16:52 ` [PATCH 3/8] drm/fourcc: Add drm_format_info_bpp() helper Geert Uytterhoeven 2022-02-15 16:52 ` Geert Uytterhoeven 2022-02-15 16:52 ` Geert Uytterhoeven [this message] 2022-02-15 16:52 ` [PATCH 4/8] drm/client: Use actual bpp when allocating frame buffers Geert Uytterhoeven 2022-02-17 14:58 ` Thomas Zimmermann 2022-02-17 14:58 ` Thomas Zimmermann 2022-02-15 16:52 ` [PATCH 5/8] drm/framebuffer: Use actual bpp for DRM_IOCTL_MODE_GETFB Geert Uytterhoeven 2022-02-15 16:52 ` Geert Uytterhoeven 2022-02-15 16:52 ` [PATCH 6/8] drm/gem-fb-helper: Use actual bpp for size calculations Geert Uytterhoeven 2022-02-15 16:52 ` Geert Uytterhoeven 2022-02-15 16:52 ` [PATCH 7/8] drm/fourcc: Add DRM_FORMAT_R[124] Geert Uytterhoeven 2022-02-15 16:52 ` Geert Uytterhoeven 2022-02-17 10:02 ` Pekka Paalanen 2022-02-17 10:02 ` Pekka Paalanen 2022-02-15 16:52 ` [PATCH 8/8] drm/fourcc: Add DRM_FORMAT_D1 Geert Uytterhoeven 2022-02-15 16:52 ` Geert Uytterhoeven 2022-02-17 10:10 ` Pekka Paalanen 2022-02-17 10:10 ` Pekka Paalanen 2022-02-17 10:42 ` Geert Uytterhoeven 2022-02-17 10:42 ` Geert Uytterhoeven 2022-02-17 14:28 ` Pekka Paalanen 2022-02-17 14:28 ` Pekka Paalanen 2022-02-17 14:35 ` Michel Dänzer 2022-02-17 14:35 ` Michel Dänzer 2022-02-17 20:36 ` Sam Ravnborg 2022-02-17 20:36 ` Sam Ravnborg 2022-02-17 10:11 ` Simon Ser 2022-02-17 10:11 ` Simon Ser 2022-02-17 20:37 ` [PATCH 0/8] drm: Add support for low-color frame buffer formats Sam Ravnborg 2022-02-17 20:37 ` Sam Ravnborg 2022-02-18 8:56 ` Thomas Zimmermann 2022-02-18 8:56 ` Thomas Zimmermann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220215165226.2738568-5-geert@linux-m68k.org \ --to=geert@linux-m68k.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=deller@gmx.de \ --cc=dri-devel@lists.freedesktop.org \ --cc=javierm@redhat.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-m68k@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.