[PATCH BlueZ] player: Fix Track being emitted with empty metadata

[PATCH BlueZ] player: Fix Track being emitted with empty metadata

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This sometimes causes the Track to be schedule while some metadata are
still pending.

Fixes: https://github.com/bluez/bluez/issues/291
---
 profiles/audio/player.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/profiles/audio/player.c b/profiles/audio/player.c
index d34b39168..687614b49 100644
--- a/profiles/audio/player.c
+++ b/profiles/audio/player.c
@@ -1308,9 +1308,14 @@ void media_player_set_duration(struct media_player *mp, uint32_t duration)
 
 	g_hash_table_replace(mp->track, g_strdup("Duration"), value);
 
-	g_dbus_emit_property_changed(btd_get_dbus_connection(),
+	/* If metadata is pending wait for it */
+	if (mp->process_id)
+		return;
+
+	g_dbus_emit_property_changed_full(btd_get_dbus_connection(),
 					mp->path, MEDIA_PLAYER_INTERFACE,
-					"Track");
+					"Track",
+					G_DBUS_PROPERTY_CHANGED_FLAG_FLUSH);
 }
 
 void media_player_set_position(struct media_player *mp, uint32_t position)
-- 
2.34.1

RE: [BlueZ] player: Fix Track being emitted with empty metadata

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=614694

---Test result---

Test Summary:
CheckPatch                    PASS      1.49 seconds
GitLint                       PASS      1.04 seconds
Prep - Setup ELL              PASS      40.19 seconds
Build - Prep                  PASS      0.72 seconds
Build - Configure             PASS      8.18 seconds
Build - Make                  PASS      1459.78 seconds
Make Check                    PASS      11.98 seconds
Make Check w/Valgrind         PASS      440.43 seconds
Make Distcheck                PASS      222.25 seconds
Build w/ext ELL - Configure   PASS      8.25 seconds
Build w/ext ELL - Make        PASS      1366.77 seconds
Incremental Build with patchesPASS      0.00 seconds



---
Regards,
Linux Bluetooth