All of lore.kernel.org
 help / color / mirror / Atom feed
* + tools-vm-page_owner-filter-out-pid-and-timestamp.patch added to -mm tree
@ 2022-02-15 22:00 Andrew Morton
  2022-02-20  4:18 ` Muchun Song
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Morton @ 2022-02-15 22:00 UTC (permalink / raw)
  To: mm-commits, vbabka, lmark, iamjoonsoo.kim, georgi.djakov,
	songmuchun, akpm


The patch titled
     Subject: tools/vm/page_owner: filter out pid and timestamp
has been added to the -mm tree.  Its filename is
     tools-vm-page_owner-filter-out-pid-and-timestamp.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/tools-vm-page_owner-filter-out-pid-and-timestamp.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/tools-vm-page_owner-filter-out-pid-and-timestamp.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Muchun Song <songmuchun@bytedance.com>
Subject: tools/vm/page_owner: filter out pid and timestamp

Commit 9cc7e96aa846 ("mm/page_owner: record timestamp and pid") introduces
timestamp and pid for page owner.  However, it is hard to aggregate the
stack since those are specific (especially timestamp).  Filter out those
information when aggregating.

Link: https://lkml.kernel.org/r/20220215134045.12004-1-songmuchun@bytedance.com
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Cc: Liam Mark <lmark@codeaurora.org>
Cc: Georgi Djakov <georgi.djakov@linaro.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 tools/vm/page_owner_sort.c |    6 ++++++
 1 file changed, 6 insertions(+)

--- a/tools/vm/page_owner_sort.c~tools-vm-page_owner-filter-out-pid-and-timestamp
+++ a/tools/vm/page_owner_sort.c
@@ -50,6 +50,12 @@ int read_block(char *buf, int buf_size,
 			return curr - buf;
 		if (!strncmp(curr, "PFN", 3))
 			continue;
+		if (!strncmp(curr, "Page allocated via order", 24)) {
+			char *end = strstr(curr, ", pid ");
+
+			if (end)
+				memcpy(end, "\n", 2);
+		}
 		curr += strlen(curr);
 	}
 
_

Patches currently in -mm which might be from songmuchun@bytedance.com are

tools-vm-page_owner-filter-out-pid-and-timestamp.patch
mm-thp-fix-wrong-cache-flush-in-remove_migration_pmd.patch
mm-fix-missing-cache-flush-for-all-tail-pages-of-compound-page.patch
mm-hugetlb-fix-missing-cache-flush-in-copy_huge_page_from_user.patch
mm-hugetlb-fix-missing-cache-flush-in-hugetlb_mcopy_atomic_pte.patch
mm-shmem-fix-missing-cache-flush-in-shmem_mfill_atomic_pte.patch
mm-userfaultfd-fix-missing-cache-flush-in-mcopy_atomic_pte-and-__mcopy_atomic.patch
mm-replace-multiple-dcache-flush-with-flush_dcache_folio.patch
mm-hugetlb-free-the-2nd-vmemmap-page-associated-with-each-hugetlb-page.patch
mm-hugetlb-replace-hugetlb_free_vmemmap_enabled-with-a-static_key.patch
mm-sparsemem-use-page-table-lock-to-protect-kernel-pmd-operations.patch
selftests-vm-add-a-hugetlb-test-case.patch
mm-sparsemem-move-vmemmap-related-to-hugetlb-to-config_hugetlb_page_free_vmemmap.patch


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: + tools-vm-page_owner-filter-out-pid-and-timestamp.patch added to -mm tree
  2022-02-15 22:00 + tools-vm-page_owner-filter-out-pid-and-timestamp.patch added to -mm tree Andrew Morton
@ 2022-02-20  4:18 ` Muchun Song
  0 siblings, 0 replies; 2+ messages in thread
From: Muchun Song @ 2022-02-20  4:18 UTC (permalink / raw)
  To: Andrew Morton
  Cc: mm-commits, Vlastimil Babka, lmark, Joonsoo Kim, georgi.djakov

On Wed, Feb 16, 2022 at 6:00 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
>
> The patch titled
>      Subject: tools/vm/page_owner: filter out pid and timestamp
> has been added to the -mm tree.  Its filename is
>      tools-vm-page_owner-filter-out-pid-and-timestamp.patch
>
> This patch should soon appear at
>     https://ozlabs.org/~akpm/mmots/broken-out/tools-vm-page_owner-filter-out-pid-and-timestamp.patch
> and later at
>     https://ozlabs.org/~akpm/mmotm/broken-out/tools-vm-page_owner-filter-out-pid-and-timestamp.patch
>
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
>
> ------------------------------------------------------
> From: Muchun Song <songmuchun@bytedance.com>
> Subject: tools/vm/page_owner: filter out pid and timestamp
>
> Commit 9cc7e96aa846 ("mm/page_owner: record timestamp and pid") introduces
> timestamp and pid for page owner.  However, it is hard to aggregate the
> stack since those are specific (especially timestamp).  Filter out those
> information when aggregating.
>
> Link: https://lkml.kernel.org/r/20220215134045.12004-1-songmuchun@bytedance.com
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> Cc: Liam Mark <lmark@codeaurora.org>
> Cc: Georgi Djakov <georgi.djakov@linaro.org>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---

Hi Andrew,

I confirmed this patch could be dropped since this issue is fixed in
Yinan's patch [1].  My patch is based on linux 5.17-rc4, so I didn't
notice that it was already fixed in the next branch but not the Linus
tree.  My bad.

[1] https://lore.kernel.org/lkml/f0a8099b-3c60-3e34-078a-be3c1280ca61@gmail.com/T/

Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-20  4:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15 22:00 + tools-vm-page_owner-filter-out-pid-and-timestamp.patch added to -mm tree Andrew Morton
2022-02-20  4:18 ` Muchun Song

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.