[PATCH] nvme: explicitly set non-error for directives

[PATCH] nvme: explicitly set non-error for directives

[Keith Busch]

Stream directives is an optional feature. It is not an error if a
controller doesn't support as many as the kernel can optionally use.
Explicitly set the non-error return value on this condition with a
comment explaining why.

Note, the return value was already 0 in this condition, so the setting
is redundant. This patch should just silence bots that falsely believe
the condition contains an error omission.

Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 drivers/nvme/host/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 79005ea1a33e..fda837ce67ce 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -777,6 +777,8 @@ static int nvme_configure_directives(struct nvme_ctrl *ctrl)
 	if (ctrl->nssa < BLK_MAX_WRITE_HINTS - 1) {
 		dev_info(ctrl->device, "too few streams (%u) available\n",
 					ctrl->nssa);
+		/* this condition is not an error: streams are optional */
+		ret = 0;
 		goto out_disable_stream;
 	}
 
-- 
2.25.4

Re: [PATCH] nvme: explicitly set non-error for directives

[Chaitanya Kulkarni]

On 2/15/22 07:03, Keith Busch wrote:
> Stream directives is an optional feature. It is not an error if a
> controller doesn't support as many as the kernel can optionally use.
> Explicitly set the non-error return value on this condition with a
> comment explaining why.
> 
> Note, the return value was already 0 in this condition, so the setting
> is redundant. This patch should just silence bots that falsely believe
> the condition contains an error omission.
> 
> Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Signed-off-by: Keith Busch <kbusch@kernel.org>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

Re: [PATCH] nvme: explicitly set non-error for directives

[Christoph Hellwig]

Thanks,

applied to nvme-5.18.