* [PATCH 0/3] staging: r8188eu: three trivial cleanups
@ 2022-02-16 8:16 Martin Kaiser
2022-02-16 8:16 ` [PATCH 1/3] staging: r8188eu: evt_allocated_buf is not used Martin Kaiser
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Martin Kaiser @ 2022-02-16 8:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel, Martin Kaiser
This set removes an unused struct and two unused variables.
Martin Kaiser (3):
staging: r8188eu: evt_allocated_buf is not used
staging: r8188eu: evt_done_cnt is set but not used
staging: r8188eu: struct usb_suspend_parm is not used
drivers/staging/r8188eu/core/rtw_cmd.c | 1 -
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 --
drivers/staging/r8188eu/include/rtw_cmd.h | 14 --------------
3 files changed, 17 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] staging: r8188eu: evt_allocated_buf is not used
2022-02-16 8:16 [PATCH 0/3] staging: r8188eu: three trivial cleanups Martin Kaiser
@ 2022-02-16 8:16 ` Martin Kaiser
2022-02-16 8:16 ` [PATCH 2/3] staging: r8188eu: evt_done_cnt is set but " Martin Kaiser
2022-02-16 8:16 ` [PATCH 3/3] staging: r8188eu: struct usb_suspend_parm is " Martin Kaiser
2 siblings, 0 replies; 4+ messages in thread
From: Martin Kaiser @ 2022-02-16 8:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel, Martin Kaiser
evt_allocated_buf in struct evt_priv is not used. Remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/include/rtw_cmd.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/r8188eu/include/rtw_cmd.h b/drivers/staging/r8188eu/include/rtw_cmd.h
index 60cecdd4ee0e..6ca141b04344 100644
--- a/drivers/staging/r8188eu/include/rtw_cmd.h
+++ b/drivers/staging/r8188eu/include/rtw_cmd.h
@@ -55,7 +55,6 @@ struct evt_priv {
#define C2H_QUEUE_MAX_LEN 10
atomic_t event_seq;
u8 *evt_buf; /* shall be non-paged, and 4 bytes aligned */
- u8 *evt_allocated_buf;
u32 evt_done_cnt;
};
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/3] staging: r8188eu: evt_done_cnt is set but not used
2022-02-16 8:16 [PATCH 0/3] staging: r8188eu: three trivial cleanups Martin Kaiser
2022-02-16 8:16 ` [PATCH 1/3] staging: r8188eu: evt_allocated_buf is not used Martin Kaiser
@ 2022-02-16 8:16 ` Martin Kaiser
2022-02-16 8:16 ` [PATCH 3/3] staging: r8188eu: struct usb_suspend_parm is " Martin Kaiser
2 siblings, 0 replies; 4+ messages in thread
From: Martin Kaiser @ 2022-02-16 8:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel, Martin Kaiser
evt_done_cnt in struct evt_priv is set but not used. Remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_cmd.c | 1 -
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 --
drivers/staging/r8188eu/include/rtw_cmd.h | 1 -
3 files changed, 4 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
index c7e8602d2097..ae7d620bc4a0 100644
--- a/drivers/staging/r8188eu/core/rtw_cmd.c
+++ b/drivers/staging/r8188eu/core/rtw_cmd.c
@@ -65,7 +65,6 @@ static int _rtw_init_evt_priv(struct evt_priv *pevtpriv)
/* allocate DMA-able/Non-Page memory for cmd_buf and rsp_buf */
atomic_set(&pevtpriv->event_seq, 0);
- pevtpriv->evt_done_cnt = 0;
INIT_WORK(&pevtpriv->c2h_wk, c2h_wk_callback);
pevtpriv->c2h_wk_alive = false;
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index ceca6751cdee..5e1f3a197dcb 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -7967,8 +7967,6 @@ u8 mlme_evt_hdl(struct adapter *padapter, unsigned char *pbuf)
if (peventbuf) {
event_callback = wlanevents[evt_code].event_callback;
event_callback(padapter, (u8 *)peventbuf);
-
- pevt_priv->evt_done_cnt++;
}
_abort_event_:
diff --git a/drivers/staging/r8188eu/include/rtw_cmd.h b/drivers/staging/r8188eu/include/rtw_cmd.h
index 6ca141b04344..39273f9775cb 100644
--- a/drivers/staging/r8188eu/include/rtw_cmd.h
+++ b/drivers/staging/r8188eu/include/rtw_cmd.h
@@ -55,7 +55,6 @@ struct evt_priv {
#define C2H_QUEUE_MAX_LEN 10
atomic_t event_seq;
u8 *evt_buf; /* shall be non-paged, and 4 bytes aligned */
- u32 evt_done_cnt;
};
#define init_h2fwcmd_w_parm_no_rsp(pcmd, pparm, code) \
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] staging: r8188eu: struct usb_suspend_parm is not used
2022-02-16 8:16 [PATCH 0/3] staging: r8188eu: three trivial cleanups Martin Kaiser
2022-02-16 8:16 ` [PATCH 1/3] staging: r8188eu: evt_allocated_buf is not used Martin Kaiser
2022-02-16 8:16 ` [PATCH 2/3] staging: r8188eu: evt_done_cnt is set but " Martin Kaiser
@ 2022-02-16 8:16 ` Martin Kaiser
2 siblings, 0 replies; 4+ messages in thread
From: Martin Kaiser @ 2022-02-16 8:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel, Martin Kaiser
struct usb_suspend_parm is not used. Remove it.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/include/rtw_cmd.h | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/r8188eu/include/rtw_cmd.h b/drivers/staging/r8188eu/include/rtw_cmd.h
index 39273f9775cb..54643927054f 100644
--- a/drivers/staging/r8188eu/include/rtw_cmd.h
+++ b/drivers/staging/r8188eu/include/rtw_cmd.h
@@ -122,18 +122,6 @@ enum RFINTFS {
HWPI,
};
-/*
-Caller Mode: Infra, Ad-HoC(C)
-
-Notes: To enter USB suspend mode
-
-Command Mode
-
-*/
-struct usb_suspend_parm {
- u32 action;/* 1: sleep, 0:resume */
-};
-
/*
Caller Mode: Infra, Ad-HoC
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-16 8:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 8:16 [PATCH 0/3] staging: r8188eu: three trivial cleanups Martin Kaiser
2022-02-16 8:16 ` [PATCH 1/3] staging: r8188eu: evt_allocated_buf is not used Martin Kaiser
2022-02-16 8:16 ` [PATCH 2/3] staging: r8188eu: evt_done_cnt is set but " Martin Kaiser
2022-02-16 8:16 ` [PATCH 3/3] staging: r8188eu: struct usb_suspend_parm is " Martin Kaiser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.