* [PATCH] drm/mode: Improve drm_mode_fb_cmd2 documentation
@ 2022-02-16 8:41 Geert Uytterhoeven
2022-02-16 18:49 ` Sam Ravnborg
2022-02-17 8:59 ` Simon Ser
0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2022-02-16 8:41 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter
Cc: Geert Uytterhoeven, dri-devel
Fix various grammar mistakes in the kerneldoc comments documenting the
drm_mode_fb_cmd2 structure:
- s/is/are/,
- s/8 bit/8-bit/.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
include/uapi/drm/drm_mode.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
index e1e351682872ebb3..5cea483c7be7a29e 100644
--- a/include/uapi/drm/drm_mode.h
+++ b/include/uapi/drm/drm_mode.h
@@ -673,12 +673,12 @@ struct drm_mode_fb_cmd2 {
/*
* In case of planar formats, this ioctl allows up to 4
* buffer objects with offsets and pitches per plane.
- * The pitch and offset order is dictated by the fourcc,
+ * The pitch and offset order are dictated by the fourcc,
* e.g. NV12 (https://fourcc.org/yuv.php#NV12) is described as:
*
- * YUV 4:2:0 image with a plane of 8 bit Y samples
+ * YUV 4:2:0 image with a plane of 8-bit Y samples
* followed by an interleaved U/V plane containing
- * 8 bit 2x2 subsampled colour difference samples.
+ * 8-bit 2x2 subsampled colour difference samples.
*
* So it would consist of Y as offsets[0] and UV as
* offsets[1]. Note that offsets[0] will generally
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/mode: Improve drm_mode_fb_cmd2 documentation
2022-02-16 8:41 [PATCH] drm/mode: Improve drm_mode_fb_cmd2 documentation Geert Uytterhoeven
@ 2022-02-16 18:49 ` Sam Ravnborg
2022-02-17 8:59 ` Simon Ser
1 sibling, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2022-02-16 18:49 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Thomas Zimmermann, David Airlie, dri-devel
On Wed, Feb 16, 2022 at 09:41:36AM +0100, Geert Uytterhoeven wrote:
> Fix various grammar mistakes in the kerneldoc comments documenting the
> drm_mode_fb_cmd2 structure:
> - s/is/are/,
> - s/8 bit/8-bit/.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/mode: Improve drm_mode_fb_cmd2 documentation
2022-02-16 8:41 [PATCH] drm/mode: Improve drm_mode_fb_cmd2 documentation Geert Uytterhoeven
2022-02-16 18:49 ` Sam Ravnborg
@ 2022-02-17 8:59 ` Simon Ser
1 sibling, 0 replies; 4+ messages in thread
From: Simon Ser @ 2022-02-17 8:59 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Thomas Zimmermann, David Airlie, dri-devel
drm-misc-next has changed this doc comment. Can you rebase your changes?
Any any case, r-b me.
[1]: https://cgit.freedesktop.org/drm/drm-misc/commit/?id=a3574119826d9a4ef807fb973cf5150c3b90da43
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/mode: Improve drm_mode_fb_cmd2 documentation
@ 2022-02-16 8:41 Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2022-02-16 8:41 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter
Cc: Geert Uytterhoeven, dri-devel
Fix various grammar mistakes in the kerneldoc comments documenting the
drm_mode_fb_cmd2 structure:
- s/is/are/,
- s/8 bit/8-bit/.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
include/uapi/drm/drm_mode.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
index e1e351682872ebb3..5cea483c7be7a29e 100644
--- a/include/uapi/drm/drm_mode.h
+++ b/include/uapi/drm/drm_mode.h
@@ -673,12 +673,12 @@ struct drm_mode_fb_cmd2 {
/*
* In case of planar formats, this ioctl allows up to 4
* buffer objects with offsets and pitches per plane.
- * The pitch and offset order is dictated by the fourcc,
+ * The pitch and offset order are dictated by the fourcc,
* e.g. NV12 (https://fourcc.org/yuv.php#NV12) is described as:
*
- * YUV 4:2:0 image with a plane of 8 bit Y samples
+ * YUV 4:2:0 image with a plane of 8-bit Y samples
* followed by an interleaved U/V plane containing
- * 8 bit 2x2 subsampled colour difference samples.
+ * 8-bit 2x2 subsampled colour difference samples.
*
* So it would consist of Y as offsets[0] and UV as
* offsets[1]. Note that offsets[0] will generally
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-17 8:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 8:41 [PATCH] drm/mode: Improve drm_mode_fb_cmd2 documentation Geert Uytterhoeven
2022-02-16 18:49 ` Sam Ravnborg
2022-02-17 8:59 ` Simon Ser
-- strict thread matches above, loose matches on Subject: below --
2022-02-16 8:41 Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.