* [PATCH] uapi: wireless: Replace zero-length array with flexible-array member
@ 2022-02-16 19:53 Gustavo A. R. Silva
2022-02-16 20:36 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2022-02-16 19:53 UTC (permalink / raw)
To: linux-kernel, Gustavo A. R. Silva, linux-hardening, ; +Cc: Johannes Berg
There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use “flexible array members”[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].
[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
Link: https://github.com/KSPP/linux/issues/78
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
include/uapi/linux/wireless.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/wireless.h b/include/uapi/linux/wireless.h
index 08967b3f19c8..3c2ad5fae17f 100644
--- a/include/uapi/linux/wireless.h
+++ b/include/uapi/linux/wireless.h
@@ -835,7 +835,7 @@ struct iw_encode_ext {
* individual keys */
__u16 alg; /* IW_ENCODE_ALG_* */
__u16 key_len;
- __u8 key[0];
+ __u8 key[];
};
/* SIOCSIWMLME data */
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] uapi: wireless: Replace zero-length array with flexible-array member
2022-02-16 19:53 [PATCH] uapi: wireless: Replace zero-length array with flexible-array member Gustavo A. R. Silva
@ 2022-02-16 20:36 ` Kees Cook
2022-03-26 0:42 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Kees Cook @ 2022-02-16 20:36 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: linux-kernel, linux-hardening,
On Wed, Feb 16, 2022 at 01:53:06PM -0600, Gustavo A. R. Silva wrote:
> There is a regular need in the kernel to provide a way to declare
> having a dynamically sized set of trailing elements in a structure.
> Kernel code should always use “flexible array members”[1] for these
> cases. The older style of one-element or zero-length arrays should
> no longer be used[2].
>
> [1] https://en.wikipedia.org/wiki/Flexible_array_member
> [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
>
> Link: https://github.com/KSPP/linux/issues/78
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
This UAPI change should be fine for any compiler that understood the
older "[0]" syntax.
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] uapi: wireless: Replace zero-length array with flexible-array member
2022-02-16 20:36 ` Kees Cook
@ 2022-03-26 0:42 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2022-03-26 0:42 UTC (permalink / raw)
To: Kees Cook; +Cc: linux-kernel, linux-hardening, Johannes Berg
On Wed, Feb 16, 2022 at 12:36:27PM -0800, Kees Cook wrote:
> On Wed, Feb 16, 2022 at 01:53:06PM -0600, Gustavo A. R. Silva wrote:
> > There is a regular need in the kernel to provide a way to declare
> > having a dynamically sized set of trailing elements in a structure.
> > Kernel code should always use “flexible array members”[1] for these
> > cases. The older style of one-element or zero-length arrays should
> > no longer be used[2].
> >
> > [1] https://en.wikipedia.org/wiki/Flexible_array_member
> > [2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
> >
> > Link: https://github.com/KSPP/linux/issues/78
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> This UAPI change should be fine for any compiler that understood the
> older "[0]" syntax.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Hi all,
Friendly ping: can someone take this, please?
...I can take this in my -next tree in the meantime.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-26 0:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16 19:53 [PATCH] uapi: wireless: Replace zero-length array with flexible-array member Gustavo A. R. Silva
2022-02-16 20:36 ` Kees Cook
2022-03-26 0:42 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.