Re: [PATCH 2 4/9] serial: sc16is7xx: remove redundant check in rs485_config

From: Lukas Wunner <lukas@wunner.de>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
	u.kleine-koenig@pengutronix.de, linux@armlinux.org.uk,
	richard.genoud@gmail.com, nicolas.ferre@microchip.com,
	alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 2 4/9] serial: sc16is7xx: remove redundant check in rs485_config
Date: Thu, 17 Feb 2022 12:47:32 +0100	[thread overview]
Message-ID: <20220217114732.GB7826@wunner.de> (raw)
In-Reply-To: <20220216001803.637-5-LinoSanfilippo@gmx.de>

On Wed, Feb 16, 2022 at 01:17:58AM +0100, Lino Sanfilippo wrote:
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -959,16 +959,6 @@ static int sc16is7xx_config_rs485(struct uart_port *port,
>  	struct sc16is7xx_one *one = to_sc16is7xx_one(port, port);
>  
>  	if (rs485->flags & SER_RS485_ENABLED) {
> -		bool rts_during_rx, rts_during_tx;
> -
> -		rts_during_rx = rs485->flags & SER_RS485_RTS_AFTER_SEND;
> -		rts_during_tx = rs485->flags & SER_RS485_RTS_ON_SEND;
> -
> -		if (rts_during_rx == rts_during_tx)
> -			dev_err(port->dev,
> -				"unsupported RTS signalling on_send:%d after_send:%d - exactly one of RS485 RTS flags should be set\n",
> -				rts_during_tx, rts_during_rx);
> -

Hm, patch 1 in this series doesn't emit such a message, so unlike now,
users will no longer be warned that they passed in nonsensical settings...