All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	alexandre.belloni@bootlin.com, mcoquelin.stm32@gmail.com,
	richard.genoud@gmail.com, festevam@gmail.com,
	s.hauer@pengutronix.de, linux@armlinux.org.uk,
	nicolas.ferre@microchip.com, alexandre.torgue@foss.st.com,
	ludovic.desroches@microchip.com, lukas@wunner.de,
	linux-imx@nxp.com, kernel@pengutronix.de,
	linux-serial@vger.kernel.org, shawnguo@kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2 7/9] serial: imx: remove redundant assignment in rs485_config
Date: Wed, 16 Feb 2022 18:43:19 +0100	[thread overview]
Message-ID: <20220216174319.rajioisll5b5pfpe@pengutronix.de> (raw)
In-Reply-To: <20220216001803.637-8-LinoSanfilippo@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

On Wed, Feb 16, 2022 at 01:18:01AM +0100, Lino Sanfilippo wrote:
> In uart_set_rs485_config() the serial core already assigns the passed
> serial_rs485 struct to the uart port.
> 
> So remove the assignment in the drivers rs485_config() function to avoid
> reduncancy.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: alexandre.belloni@bootlin.com, festevam@gmail.com,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de,
	richard.genoud@gmail.com, gregkh@linuxfoundation.org,
	s.hauer@pengutronix.de, linux@armlinux.org.uk,
	alexandre.torgue@foss.st.com, ludovic.desroches@microchip.com,
	lukas@wunner.de, linux-imx@nxp.com, mcoquelin.stm32@gmail.com,
	linux-serial@vger.kernel.org, shawnguo@kernel.org,
	jirislaby@kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2 7/9] serial: imx: remove redundant assignment in rs485_config
Date: Wed, 16 Feb 2022 18:43:19 +0100	[thread overview]
Message-ID: <20220216174319.rajioisll5b5pfpe@pengutronix.de> (raw)
In-Reply-To: <20220216001803.637-8-LinoSanfilippo@gmx.de>


[-- Attachment #1.1: Type: text/plain, Size: 572 bytes --]

On Wed, Feb 16, 2022 at 01:18:01AM +0100, Lino Sanfilippo wrote:
> In uart_set_rs485_config() the serial core already assigns the passed
> serial_rs485 struct to the uart port.
> 
> So remove the assignment in the drivers rs485_config() function to avoid
> reduncancy.
> 
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-02-16 17:43 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16  0:17 Move RS485 implementation from drivers to serial core Lino Sanfilippo
2022-02-16  0:17 ` Lino Sanfilippo
2022-02-16  0:17 ` [PATCH 2 1/9] serial: core: move RS485 configuration tasks from drivers into core Lino Sanfilippo
2022-02-16  0:17   ` Lino Sanfilippo
2022-02-17 11:33   ` Lukas Wunner
2022-02-17 21:36     ` Lino Sanfilippo
2022-02-17 21:36       ` Lino Sanfilippo
2022-02-21 18:39   ` Greg KH
2022-02-21 18:39     ` Greg KH
2022-02-21 23:19     ` Lino Sanfilippo
2022-02-21 23:19       ` Lino Sanfilippo
2022-02-16  0:17 ` [PATCH 2 2/9] serial: amba-pl011: remove redundant code in rs485_config Lino Sanfilippo
2022-02-16  0:17   ` Lino Sanfilippo
2022-02-16  0:17 ` [PATCH 2 3/9] serial: stm32: " Lino Sanfilippo
2022-02-16  0:17   ` Lino Sanfilippo
2022-02-16  0:17 ` [PATCH 2 4/9] serial: sc16is7xx: remove redundant check " Lino Sanfilippo
2022-02-16  0:17   ` Lino Sanfilippo
2022-02-17 11:47   ` Lukas Wunner
2022-02-17 22:11     ` Lino Sanfilippo
2022-02-17 22:11       ` Lino Sanfilippo
2022-02-16  0:17 ` [PATCH 2 5/9] serial: omap: remove redundant code " Lino Sanfilippo
2022-02-16  0:17   ` Lino Sanfilippo
2022-02-16  0:18 ` [PATCH 2 6/9] serial: max310: remove redundant memset " Lino Sanfilippo
2022-02-16  0:18   ` Lino Sanfilippo
2022-02-16  0:18 ` [PATCH 2 7/9] serial: imx: remove redundant assignment " Lino Sanfilippo
2022-02-16  0:18   ` Lino Sanfilippo
2022-02-16 17:43   ` Uwe Kleine-König [this message]
2022-02-16 17:43     ` Uwe Kleine-König
2022-02-16  0:18 ` [PATCH 2 8/9] serial: fsl_lpuart: remove redundant code in rs485_config functions Lino Sanfilippo
2022-02-16  0:18   ` Lino Sanfilippo
2022-02-16  0:18 ` [PATCH 2 9/9] serial: atmel: remove redundant assignment in rs485_config Lino Sanfilippo
2022-02-16  0:18   ` Lino Sanfilippo
2022-02-17  9:22   ` Richard Genoud
2022-02-17  9:22     ` Richard Genoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220216174319.rajioisll5b5pfpe@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=LinoSanfilippo@gmx.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux@armlinux.org.uk \
    --cc=ludovic.desroches@microchip.com \
    --cc=lukas@wunner.de \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=richard.genoud@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.