All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gunter Grau <gunter.grau@philips.com>
To: xenomai@xenomai.org
Subject: [PATCH] ipipe: Fix ipipe level irq end
Date: Thu, 17 Feb 2022 15:12:35 +0100	[thread overview]
Message-ID: <20220217141235.868386-1-gunter.grau@philips.com> (raw)
In-Reply-To: <0b1ec490-5d7b-3ca7-7b2a-952db122d50d@siemens.com>

The following commit in the vanilla kernel introduced
a check for the cached interrupt mask flag in mask_irq():

bf22ff45bed6 ("genirq: Avoid unnecessary low level irq function calls")

This means if the flag is not serviced correctly
the real bit in the hardware interrupt controller may not be
cleared or set.
The __ipipe_end_level_irq() function does not follow this rule.
It unmasks the bit in the hardware without setting the cached flags
accordingly. So after the first level interrupt is finished the
mask cache has a wrong state. If now the next interrupt fires,
the mask_irq() function will not really mask the interrupt in
the hardware which causes a interrupt storm after reenabeling
the hard irqs.
The fix now also updates the shadow flag correctly.

Signed-off-by: Gunter Grau <gunter.grau@philips.com>
---
 kernel/irq/chip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 7c03e2931189..ff9a8b3f33db 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -988,6 +988,7 @@ void __ipipe_ack_level_irq(struct irq_desc *desc)
 void __ipipe_end_level_irq(struct irq_desc *desc)
 {
        desc->irq_data.chip->irq_unmask(&desc->irq_data);
+       irq_state_clr_masked(desc);
 }

 void __ipipe_ack_fasteoi_irq(struct irq_desc *desc)
--
2.25.1


________________________________
The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended recipient, you are hereby notified that any use, forwarding, dissemination, or reproduction of this message is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.


  reply	other threads:[~2022-02-17 14:12 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 15:33 Issue with linux threaded level triggered interrupts Gunter Grau
2022-02-10 15:33 ` [PATCH] ipipe: Fix ipipe level irq end Gunter Grau
2022-02-10 15:37   ` Greg Gallagher
2022-02-10 15:53   ` Jan Kiszka
2022-02-16 21:03   ` Jan Kiszka
2022-02-17  8:48     ` Gunter Grau
2022-02-17  9:15       ` Jan Kiszka
2022-02-17 12:16         ` Grau, Gunter
2022-02-17 12:36           ` Jan Kiszka
2022-02-17 14:11         ` Greg Gallagher
2022-02-17 15:12           ` Jan Kiszka
2022-02-17 15:13             ` Greg Gallagher
2022-08-11 13:05               ` Grau, Gunter
2022-08-15  6:19                 ` Jan Kiszka
2022-08-15  9:13                   ` Grau, Gunter
2022-08-15  9:34                     ` Philippe Gerum
2022-08-15 10:27                     ` [[I-PIPE PATCH]] ipipe: noarch: Fix ipipe level end interrupt Gunter Grau
2022-08-15 11:56                       ` Jan Kiszka
2022-08-15 12:31                         ` Grau, Gunter
2022-08-15 13:54                           ` Jan Kiszka
2022-08-15 15:24                             ` Grau, Gunter
2022-08-16  6:23                               ` Jan Kiszka
2022-08-17 16:09                                 ` Grau, Gunter
2022-09-02  7:48                                 ` Bezdeka, Florian
2022-02-17 14:05       ` [PATCH] ipipe: Fix ipipe level irq end Jan Kiszka
2022-02-17 14:08         ` Jan Kiszka
2022-02-17 14:12           ` Gunter Grau [this message]
2022-02-10 15:39 ` Issue with linux threaded level triggered interrupts Greg Gallagher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220217141235.868386-1-gunter.grau@philips.com \
    --to=gunter.grau@philips.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.