All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Peter Geis <pgwipeout@gmail.com>,
	Sandy Huang <hjc@rock-chips.com>,
	linux-rockchip@lists.infradead.org,
	Michael Riesch <michael.riesch@wolfvision.net>,
	kernel@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 09/23] drm/rockchip: dw_hdmi: Add support for hclk
Date: Thu, 17 Feb 2022 16:00:41 +0100	[thread overview]
Message-ID: <20220217150041.GS18637@pengutronix.de> (raw)
In-Reply-To: <cd66c9da-15c2-54e1-8016-8d951926eaa2@gmail.com>

On Thu, Feb 17, 2022 at 03:35:08PM +0300, Dmitry Osipenko wrote:
> 17.02.2022 11:29, Sascha Hauer пишет:
> > The rk3568 HDMI has an additional clock that needs to be enabled for the
> > HDMI controller to work. The purpose of that clock is not clear. It is
> > named "hclk" in the downstream driver, so use the same name.
> 
> Have you checked that DSI works without the enabled hclk? I'd expect the
> whole VOP to be clock-gated.

No, I haven't checked that.

I am not sure where you aiming at. The HCLK_VOP is supplied to the vop2
as well and the vop2 driver also enables this clock. Still, when the
HDMI registers are accessed before the vop2 driver enables HCLK_VOP then
the system hangs, so the HDMI needs it also.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: devicetree@vger.kernel.org,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	kernel@pengutronix.de, Sandy Huang <hjc@rock-chips.com>,
	dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	Michael Riesch <michael.riesch@wolfvision.net>,
	Peter Geis <pgwipeout@gmail.com>,
	Andy Yan <andy.yan@rock-chips.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 09/23] drm/rockchip: dw_hdmi: Add support for hclk
Date: Thu, 17 Feb 2022 16:00:41 +0100	[thread overview]
Message-ID: <20220217150041.GS18637@pengutronix.de> (raw)
In-Reply-To: <cd66c9da-15c2-54e1-8016-8d951926eaa2@gmail.com>

On Thu, Feb 17, 2022 at 03:35:08PM +0300, Dmitry Osipenko wrote:
> 17.02.2022 11:29, Sascha Hauer пишет:
> > The rk3568 HDMI has an additional clock that needs to be enabled for the
> > HDMI controller to work. The purpose of that clock is not clear. It is
> > named "hclk" in the downstream driver, so use the same name.
> 
> Have you checked that DSI works without the enabled hclk? I'd expect the
> whole VOP to be clock-gated.

No, I haven't checked that.

I am not sure where you aiming at. The HCLK_VOP is supplied to the vop2
as well and the vop2 driver also enables this clock. Still, when the
HDMI registers are accessed before the vop2 driver enables HCLK_VOP then
the system hangs, so the HDMI needs it also.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Peter Geis <pgwipeout@gmail.com>,
	Sandy Huang <hjc@rock-chips.com>,
	linux-rockchip@lists.infradead.org,
	Michael Riesch <michael.riesch@wolfvision.net>,
	kernel@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 09/23] drm/rockchip: dw_hdmi: Add support for hclk
Date: Thu, 17 Feb 2022 16:00:41 +0100	[thread overview]
Message-ID: <20220217150041.GS18637@pengutronix.de> (raw)
In-Reply-To: <cd66c9da-15c2-54e1-8016-8d951926eaa2@gmail.com>

On Thu, Feb 17, 2022 at 03:35:08PM +0300, Dmitry Osipenko wrote:
> 17.02.2022 11:29, Sascha Hauer пишет:
> > The rk3568 HDMI has an additional clock that needs to be enabled for the
> > HDMI controller to work. The purpose of that clock is not clear. It is
> > named "hclk" in the downstream driver, so use the same name.
> 
> Have you checked that DSI works without the enabled hclk? I'd expect the
> whole VOP to be clock-gated.

No, I haven't checked that.

I am not sure where you aiming at. The HCLK_VOP is supplied to the vop2
as well and the vop2 driver also enables this clock. Still, when the
HDMI registers are accessed before the vop2 driver enables HCLK_VOP then
the system hangs, so the HDMI needs it also.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	Benjamin Gaignard <benjamin.gaignard@collabora.com>,
	Peter Geis <pgwipeout@gmail.com>,
	Sandy Huang <hjc@rock-chips.com>,
	linux-rockchip@lists.infradead.org,
	Michael Riesch <michael.riesch@wolfvision.net>,
	kernel@pengutronix.de, Andy Yan <andy.yan@rock-chips.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 09/23] drm/rockchip: dw_hdmi: Add support for hclk
Date: Thu, 17 Feb 2022 16:00:41 +0100	[thread overview]
Message-ID: <20220217150041.GS18637@pengutronix.de> (raw)
In-Reply-To: <cd66c9da-15c2-54e1-8016-8d951926eaa2@gmail.com>

On Thu, Feb 17, 2022 at 03:35:08PM +0300, Dmitry Osipenko wrote:
> 17.02.2022 11:29, Sascha Hauer пишет:
> > The rk3568 HDMI has an additional clock that needs to be enabled for the
> > HDMI controller to work. The purpose of that clock is not clear. It is
> > named "hclk" in the downstream driver, so use the same name.
> 
> Have you checked that DSI works without the enabled hclk? I'd expect the
> whole VOP to be clock-gated.

No, I haven't checked that.

I am not sure where you aiming at. The HCLK_VOP is supplied to the vop2
as well and the vop2 driver also enables this clock. Still, when the
HDMI registers are accessed before the vop2 driver enables HCLK_VOP then
the system hangs, so the HDMI needs it also.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-02-17 15:00 UTC|newest]

Thread overview: 201+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17  8:29 [PATCH v6 00/23] drm/rockchip: RK356x VOP2 support Sascha Hauer
2022-02-17  8:29 ` Sascha Hauer
2022-02-17  8:29 ` Sascha Hauer
2022-02-17  8:29 ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 01/23] drm/rockchip: Embed drm_encoder into rockchip_decoder Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 02/23] drm/rockchip: dw_hdmi: rename vpll clock to reference clock Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17 13:20   ` Dmitry Osipenko
2022-02-17 13:20     ` Dmitry Osipenko
2022-02-17 13:20     ` Dmitry Osipenko
2022-02-17 13:20     ` Dmitry Osipenko
2022-02-17 13:37     ` Sascha Hauer
2022-02-17 13:37       ` Sascha Hauer
2022-02-17 13:37       ` Sascha Hauer
2022-02-17 13:37       ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 03/23] dt-bindings: display: rockchip: dw-hdmi: use "ref" as clock name Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 04/23] arm64: dts: rockchip: rk3399: rename HDMI ref clock to 'ref' Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 05/23] drm/rockchip: dw_hdmi: add rk3568 support Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 06/23] dt-bindings: display: rockchip: dw-hdmi: Add compatible for rk3568 HDMI Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 07/23] drm/rockchip: dw_hdmi: add regulator support Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17 13:18   ` Dmitry Osipenko
2022-02-17 13:18     ` Dmitry Osipenko
2022-02-17 13:18     ` Dmitry Osipenko
2022-02-17 13:18     ` Dmitry Osipenko
2022-02-17  8:29 ` [PATCH v6 08/23] dt-bindings: display: rockchip: dw-hdmi: Add " Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 09/23] drm/rockchip: dw_hdmi: Add support for hclk Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17 12:35   ` Dmitry Osipenko
2022-02-17 12:35     ` Dmitry Osipenko
2022-02-17 12:35     ` Dmitry Osipenko
2022-02-17 12:35     ` Dmitry Osipenko
2022-02-17 15:00     ` Sascha Hauer [this message]
2022-02-17 15:00       ` Sascha Hauer
2022-02-17 15:00       ` Sascha Hauer
2022-02-17 15:00       ` Sascha Hauer
2022-02-17 16:59       ` Dmitry Osipenko
2022-02-17 16:59         ` Dmitry Osipenko
2022-02-17 16:59         ` Dmitry Osipenko
2022-02-17 16:59         ` Dmitry Osipenko
2022-02-17  8:29 ` [PATCH v6 10/23] dt-bindings: display: rockchip: dw-hdmi: Add additional clock Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 11/23] drm/rockchip: dw_hdmi: Use auto-generated tables Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 12/23] drm/rockchip: dw_hdmi: drop mode_valid hook Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 13/23] drm/rockchip: dw_hdmi: Set cur_ctr to 0 always Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17 14:00   ` Dmitry Osipenko
2022-02-17 14:00     ` Dmitry Osipenko
2022-02-17 14:00     ` Dmitry Osipenko
2022-02-17 14:00     ` Dmitry Osipenko
2022-02-17 15:12     ` Sascha Hauer
2022-02-17 15:12       ` Sascha Hauer
2022-02-17 15:12       ` Sascha Hauer
2022-02-17 15:12       ` Sascha Hauer
2022-02-17 17:00       ` Dmitry Osipenko
2022-02-17 17:00         ` Dmitry Osipenko
2022-02-17 17:00         ` Dmitry Osipenko
2022-02-17 17:00         ` Dmitry Osipenko
2022-02-17  8:29 ` [PATCH v6 14/23] drm/rockchip: dw_hdmi: add default 594Mhz clk for 4K@60hz Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 15/23] dt-bindings: display: rockchip: dw-hdmi: Make unwedge pinctrl optional Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 16/23] arm64: dts: rockchip: rk356x: Add VOP2 nodes Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 17/23] arm64: dts: rockchip: rk356x: Add HDMI nodes Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-21  8:54   ` Aw: " Frank Wunderlich
2022-02-21  8:54     ` Frank Wunderlich
2022-02-21  8:54     ` Frank Wunderlich
2022-02-21  8:54     ` Frank Wunderlich
2022-02-21  9:53     ` Sascha Hauer
2022-02-21  9:53       ` Sascha Hauer
2022-02-21  9:53       ` Sascha Hauer
2022-02-21  9:53       ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 18/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 19/23] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 20/23] drm/rockchip: Make VOP driver optional Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 21/23] drm: rockchip: Add VOP2 driver Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17 12:00   ` Andy Yan
2022-02-17 12:00     ` Andy Yan
2022-02-17 12:00     ` Andy Yan
2022-02-17 13:58     ` Sascha Hauer
2022-02-17 13:58       ` Sascha Hauer
2022-02-17 13:58       ` Sascha Hauer
2022-02-17 13:58       ` Sascha Hauer
2022-02-17 14:06       ` Heiko Stübner
2022-02-17 14:06         ` Heiko Stübner
2022-02-17 14:06         ` Heiko Stübner
2022-02-17 14:06         ` Heiko Stübner
2022-02-18  3:50         ` Andy Yan
2022-02-18  3:50           ` Andy Yan
2022-02-18  3:50           ` Andy Yan
2022-02-18  3:50           ` Andy Yan
2022-02-18  8:00           ` Sascha Hauer
2022-02-18  8:00             ` Sascha Hauer
2022-02-18  8:00             ` Sascha Hauer
2022-02-18  8:00             ` Sascha Hauer
2022-02-19  7:35             ` Andy Yan
2022-02-19  7:35               ` Andy Yan
2022-02-19  7:35               ` Andy Yan
2022-02-19  7:35               ` Andy Yan
2022-02-24  8:19               ` Sascha Hauer
2022-02-24  8:19                 ` Sascha Hauer
2022-02-24  8:19                 ` Sascha Hauer
2022-02-24  8:19                 ` Sascha Hauer
2022-02-24 10:54                 ` Andy Yan
2022-02-24 10:54                   ` Andy Yan
2022-02-24 10:54                   ` Andy Yan
2022-02-24 10:54                   ` Andy Yan
2022-02-24 12:50                   ` Sascha Hauer
2022-02-24 12:50                     ` Sascha Hauer
2022-02-24 12:50                     ` Sascha Hauer
2022-02-24 12:50                     ` Sascha Hauer
2022-02-17 13:24   ` Dmitry Osipenko
2022-02-17 13:24     ` Dmitry Osipenko
2022-02-17 13:24     ` Dmitry Osipenko
2022-02-17 13:24     ` Dmitry Osipenko
2022-02-24  7:47     ` Sascha Hauer
2022-02-24  7:47       ` Sascha Hauer
2022-02-24  7:47       ` Sascha Hauer
2022-02-24  7:47       ` Sascha Hauer
2022-02-24 14:36       ` Dmitry Osipenko
2022-02-24 14:36         ` Dmitry Osipenko
2022-02-24 14:36         ` Dmitry Osipenko
2022-02-24 14:36         ` Dmitry Osipenko
2022-02-24 14:47         ` Sascha Hauer
2022-02-24 14:47           ` Sascha Hauer
2022-02-24 14:47           ` Sascha Hauer
2022-02-24 14:47           ` Sascha Hauer
2022-02-21 11:51   ` Andy Yan
2022-02-21 11:51     ` Andy Yan
2022-02-21 11:51     ` Andy Yan
2022-02-21 18:18     ` Lucas Stach
2022-02-21 18:18       ` Lucas Stach
2022-02-21 18:18       ` Lucas Stach
2022-02-17  8:29 ` [PATCH v6 22/23] dt-bindings: display: rockchip: Add binding for VOP2 Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29 ` [PATCH v6 23/23] dt-bindings: display: rockchip: dw-hdmi: fix ports description Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-17  8:29   ` Sascha Hauer
2022-02-23 15:55   ` Rob Herring
2022-02-23 15:55     ` Rob Herring
2022-02-23 15:55     ` Rob Herring
2022-02-23 15:55     ` Rob Herring
2022-02-17 10:07 ` [PATCH v6 00/23] drm/rockchip: RK356x VOP2 support Frank Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220217150041.GS18637@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=andy.yan@rock-chips.com \
    --cc=benjamin.gaignard@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hjc@rock-chips.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=michael.riesch@wolfvision.net \
    --cc=pgwipeout@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.