[Buildroot] [PATCH 1/1] package/pcre: don't override PCRE_CONF_OPTS

[Buildroot] [PATCH 1/1] package/pcre: don't override PCRE_CONF_OPTS

[Fabrice Fontaine]

PCRE_CONF_OPTS is wrongly overridden in a conditional since commit
9b28d48012c33b37d33101991fa042f9fc9d76eb

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/pcre/pcre.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/pcre/pcre.mk b/package/pcre/pcre.mk
index c85f6717db..59750c28e7 100644
--- a/package/pcre/pcre.mk
+++ b/package/pcre/pcre.mk
@@ -18,7 +18,7 @@ HOST_PCRE_CONF_OPTS = --enable-unicode-properties
 
 ifneq ($(BR2_INSTALL_LIBSTDCPP),y)
 # pcre will use the host g++ if a cross version isn't available
-PCRE_CONF_OPTS = --disable-cpp
+PCRE_CONF_OPTS += --disable-cpp
 endif
 
 PCRE_CONF_OPTS += --enable-pcre8
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/pcre: don't override PCRE_CONF_OPTS

[Yann E. MORIN]

Fabrice, All,

On 2022-02-17 22:44 +0100, Fabrice Fontaine spake thusly:
> PCRE_CONF_OPTS is wrongly overridden in a conditional since commit
> 9b28d48012c33b37d33101991fa042f9fc9d76eb
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, alogn with your four following similar changes,
thanks.

Note that some of them are not really overrides, as the variables are
not previously set, but for consistency sake, and for robustness agaisnt
future evolutions in those files, this is still better (and correct!) to
use the append assignment in conditional blocks.

Thanks!

Regards,
Yann E. MORIN.

> ---
>  package/pcre/pcre.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/pcre/pcre.mk b/package/pcre/pcre.mk
> index c85f6717db..59750c28e7 100644
> --- a/package/pcre/pcre.mk
> +++ b/package/pcre/pcre.mk
> @@ -18,7 +18,7 @@ HOST_PCRE_CONF_OPTS = --enable-unicode-properties
>  
>  ifneq ($(BR2_INSTALL_LIBSTDCPP),y)
>  # pcre will use the host g++ if a cross version isn't available
> -PCRE_CONF_OPTS = --disable-cpp
> +PCRE_CONF_OPTS += --disable-cpp
>  endif
>  
>  PCRE_CONF_OPTS += --enable-pcre8
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot