* [PATCH] ARM: iop32x: add prototype for iop_enable_cp6()
@ 2022-02-17 22:46 ` Souptick Joarder
0 siblings, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2022-02-17 22:46 UTC (permalink / raw)
To: linux, arnd, ardb
Cc: linux-arm-kernel, linux-kernel, Souptick Joarder (HPE),
kernel test robot
From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
Kernel test robot throws warning ->
arch/arm/mach-iop32x/cp6.c:10:6: warning: no previous prototype
for function 'iop_enable_cp6' [-Wmissing-prototypes]
Adding prototype by including header.
Fixes: 6f5d248d05db ("ARM: iop32x: use GENERIC_IRQ_MULTI_HANDLER")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
---
arch/arm/mach-iop32x/cp6.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-iop32x/cp6.c b/arch/arm/mach-iop32x/cp6.c
index 2882674a1c39..7135a0ac9949 100644
--- a/arch/arm/mach-iop32x/cp6.c
+++ b/arch/arm/mach-iop32x/cp6.c
@@ -7,6 +7,8 @@
#include <asm/traps.h>
#include <asm/ptrace.h>
+#include "iop3xx.h"
+
void iop_enable_cp6(void)
{
u32 temp;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: iop32x: add prototype for iop_enable_cp6()
@ 2022-02-17 22:46 ` Souptick Joarder
0 siblings, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2022-02-17 22:46 UTC (permalink / raw)
To: linux, arnd, ardb
Cc: linux-arm-kernel, linux-kernel, Souptick Joarder (HPE),
kernel test robot
From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
Kernel test robot throws warning ->
arch/arm/mach-iop32x/cp6.c:10:6: warning: no previous prototype
for function 'iop_enable_cp6' [-Wmissing-prototypes]
Adding prototype by including header.
Fixes: 6f5d248d05db ("ARM: iop32x: use GENERIC_IRQ_MULTI_HANDLER")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
---
arch/arm/mach-iop32x/cp6.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-iop32x/cp6.c b/arch/arm/mach-iop32x/cp6.c
index 2882674a1c39..7135a0ac9949 100644
--- a/arch/arm/mach-iop32x/cp6.c
+++ b/arch/arm/mach-iop32x/cp6.c
@@ -7,6 +7,8 @@
#include <asm/traps.h>
#include <asm/ptrace.h>
+#include "iop3xx.h"
+
void iop_enable_cp6(void)
{
u32 temp;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: iop32x: add prototype for iop_enable_cp6()
2022-02-17 22:46 ` Souptick Joarder
@ 2022-03-01 3:14 ` Souptick Joarder
-1 siblings, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2022-03-01 3:14 UTC (permalink / raw)
To: Russell King - ARM Linux, Arnd Bergmann, ardb
Cc: linux-arm-kernel, linux-kernel, kernel test robot
On Fri, Feb 18, 2022 at 4:17 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
>
> Kernel test robot throws warning ->
> arch/arm/mach-iop32x/cp6.c:10:6: warning: no previous prototype
> for function 'iop_enable_cp6' [-Wmissing-prototypes]
>
> Adding prototype by including header.
Any comments on this patch ?
>
> Fixes: 6f5d248d05db ("ARM: iop32x: use GENERIC_IRQ_MULTI_HANDLER")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
> ---
> arch/arm/mach-iop32x/cp6.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-iop32x/cp6.c b/arch/arm/mach-iop32x/cp6.c
> index 2882674a1c39..7135a0ac9949 100644
> --- a/arch/arm/mach-iop32x/cp6.c
> +++ b/arch/arm/mach-iop32x/cp6.c
> @@ -7,6 +7,8 @@
> #include <asm/traps.h>
> #include <asm/ptrace.h>
>
> +#include "iop3xx.h"
> +
> void iop_enable_cp6(void)
> {
> u32 temp;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: iop32x: add prototype for iop_enable_cp6()
@ 2022-03-01 3:14 ` Souptick Joarder
0 siblings, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2022-03-01 3:14 UTC (permalink / raw)
To: Russell King - ARM Linux, Arnd Bergmann, ardb
Cc: linux-arm-kernel, linux-kernel, kernel test robot
On Fri, Feb 18, 2022 at 4:17 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
>
> Kernel test robot throws warning ->
> arch/arm/mach-iop32x/cp6.c:10:6: warning: no previous prototype
> for function 'iop_enable_cp6' [-Wmissing-prototypes]
>
> Adding prototype by including header.
Any comments on this patch ?
>
> Fixes: 6f5d248d05db ("ARM: iop32x: use GENERIC_IRQ_MULTI_HANDLER")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
> ---
> arch/arm/mach-iop32x/cp6.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-iop32x/cp6.c b/arch/arm/mach-iop32x/cp6.c
> index 2882674a1c39..7135a0ac9949 100644
> --- a/arch/arm/mach-iop32x/cp6.c
> +++ b/arch/arm/mach-iop32x/cp6.c
> @@ -7,6 +7,8 @@
> #include <asm/traps.h>
> #include <asm/ptrace.h>
>
> +#include "iop3xx.h"
> +
> void iop_enable_cp6(void)
> {
> u32 temp;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: iop32x: add prototype for iop_enable_cp6()
2022-02-17 22:46 ` Souptick Joarder
@ 2022-03-01 10:24 ` Arnd Bergmann
-1 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2022-03-01 10:24 UTC (permalink / raw)
To: Souptick Joarder
Cc: Russell King - ARM Linux, Arnd Bergmann, Ard Biesheuvel,
Linux ARM, Linux Kernel Mailing List, kernel test robot
On Thu, Feb 17, 2022 at 11:46 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
>
> Kernel test robot throws warning ->
> arch/arm/mach-iop32x/cp6.c:10:6: warning: no previous prototype
> for function 'iop_enable_cp6' [-Wmissing-prototypes]
>
> Adding prototype by including header.
It may be worth mentioning that this only happens with W=1 or V=1 but
not with the
normal build options.
> Fixes: 6f5d248d05db ("ARM: iop32x: use GENERIC_IRQ_MULTI_HANDLER")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Russell, please apply this on top of the arm-vmap-stacks-v6 that contains my
original patch withthe W=1 warning.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: iop32x: add prototype for iop_enable_cp6()
@ 2022-03-01 10:24 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2022-03-01 10:24 UTC (permalink / raw)
To: Souptick Joarder
Cc: Russell King - ARM Linux, Arnd Bergmann, Ard Biesheuvel,
Linux ARM, Linux Kernel Mailing List, kernel test robot
On Thu, Feb 17, 2022 at 11:46 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
>
> Kernel test robot throws warning ->
> arch/arm/mach-iop32x/cp6.c:10:6: warning: no previous prototype
> for function 'iop_enable_cp6' [-Wmissing-prototypes]
>
> Adding prototype by including header.
It may be worth mentioning that this only happens with W=1 or V=1 but
not with the
normal build options.
> Fixes: 6f5d248d05db ("ARM: iop32x: use GENERIC_IRQ_MULTI_HANDLER")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Russell, please apply this on top of the arm-vmap-stacks-v6 that contains my
original patch withthe W=1 warning.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-01 10:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-17 22:46 [PATCH] ARM: iop32x: add prototype for iop_enable_cp6() Souptick Joarder
2022-02-17 22:46 ` Souptick Joarder
2022-03-01 3:14 ` Souptick Joarder
2022-03-01 3:14 ` Souptick Joarder
2022-03-01 10:24 ` Arnd Bergmann
2022-03-01 10:24 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.