* [PATCH] CI: Add gnu grep to alpine containers
@ 2022-02-18 13:17 Andrew Cooper
2022-02-18 14:39 ` Anthony PERARD
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cooper @ 2022-02-18 13:17 UTC (permalink / raw)
To: Xen-devel
Cc: Andrew Cooper, Doug Goldstein, Wei Liu, Anthony PERARD,
Roger Pau Monné,
Stefano Stabellini, Jan Beulich
A forthcoming change is going to want more support than busybox's grep can
provide.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Doug Goldstein <cardoe@cardoe.com>
CC: Wei Liu <wl@xen.org>
CC: Anthony PERARD <anthony.perard@citrix.com>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Jan Beulich <JBeulich@suse.com>
I've already rebuilt the containers and confirmed that the build is still fine.
---
automation/build/alpine/3.12.dockerfile | 1 +
1 file changed, 1 insertion(+)
diff --git a/automation/build/alpine/3.12.dockerfile b/automation/build/alpine/3.12.dockerfile
index 4ee3ddc12e52..4cce7ab926dc 100644
--- a/automation/build/alpine/3.12.dockerfile
+++ b/automation/build/alpine/3.12.dockerfile
@@ -26,6 +26,7 @@ RUN \
# gettext for Xen < 4.13
apk add gettext && \
apk add git && \
+ apk add grep && \
apk add iasl && \
apk add libaio-dev && \
apk add linux-headers && \
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] CI: Add gnu grep to alpine containers
2022-02-18 13:17 [PATCH] CI: Add gnu grep to alpine containers Andrew Cooper
@ 2022-02-18 14:39 ` Anthony PERARD
2022-02-18 16:28 ` Stefano Stabellini
0 siblings, 1 reply; 4+ messages in thread
From: Anthony PERARD @ 2022-02-18 14:39 UTC (permalink / raw)
To: Andrew Cooper
Cc: Xen-devel, Doug Goldstein, Wei Liu, Roger Pau Monné,
Stefano Stabellini, Jan Beulich
On Fri, Feb 18, 2022 at 01:17:40PM +0000, Andrew Cooper wrote:
> A forthcoming change is going to want more support than busybox's grep can
> provide.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Doug Goldstein <cardoe@cardoe.com>
> CC: Wei Liu <wl@xen.org>
> CC: Anthony PERARD <anthony.perard@citrix.com>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Jan Beulich <JBeulich@suse.com>
>
> I've already rebuilt the containers and confirmed that the build is still fine.
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CI: Add gnu grep to alpine containers
2022-02-18 14:39 ` Anthony PERARD
@ 2022-02-18 16:28 ` Stefano Stabellini
2022-02-18 16:31 ` Andrew Cooper
0 siblings, 1 reply; 4+ messages in thread
From: Stefano Stabellini @ 2022-02-18 16:28 UTC (permalink / raw)
To: Anthony PERARD
Cc: Andrew Cooper, Xen-devel, Doug Goldstein, Wei Liu,
Roger Pau Monné,
Stefano Stabellini, Jan Beulich
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
On Fri, 18 Feb 2022, Anthony PERARD wrote:
> On Fri, Feb 18, 2022 at 01:17:40PM +0000, Andrew Cooper wrote:
> > A forthcoming change is going to want more support than busybox's grep can
> > provide.
> >
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > ---
> > CC: Doug Goldstein <cardoe@cardoe.com>
> > CC: Wei Liu <wl@xen.org>
> > CC: Anthony PERARD <anthony.perard@citrix.com>
> > CC: Roger Pau Monné <roger.pau@citrix.com>
> > CC: Stefano Stabellini <sstabellini@kernel.org>
> > CC: Jan Beulich <JBeulich@suse.com>
> >
> > I've already rebuilt the containers and confirmed that the build is still fine.
>
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Good for me too. Out of curiousity, what is that is not working with
busybox's grep? Is it regex?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] CI: Add gnu grep to alpine containers
2022-02-18 16:28 ` Stefano Stabellini
@ 2022-02-18 16:31 ` Andrew Cooper
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cooper @ 2022-02-18 16:31 UTC (permalink / raw)
To: Stefano Stabellini, Anthony PERARD
Cc: Andrew Cooper, Xen-devel, Doug Goldstein, Wei Liu,
Roger Pau Monné,
Jan Beulich
On 18/02/2022 16:28, Stefano Stabellini wrote:
> On Fri, 18 Feb 2022, Anthony PERARD wrote:
>> On Fri, Feb 18, 2022 at 01:17:40PM +0000, Andrew Cooper wrote:
>>> A forthcoming change is going to want more support than busybox's grep can
>>> provide.
>>>
>>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>>> ---
>>> CC: Doug Goldstein <cardoe@cardoe.com>
>>> CC: Wei Liu <wl@xen.org>
>>> CC: Anthony PERARD <anthony.perard@citrix.com>
>>> CC: Roger Pau Monné <roger.pau@citrix.com>
>>> CC: Stefano Stabellini <sstabellini@kernel.org>
>>> CC: Jan Beulich <JBeulich@suse.com>
>>>
>>> I've already rebuilt the containers and confirmed that the build is still fine.
>> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
> Good for me too. Out of curiousity, what is that is not working with
> busybox's grep? Is it regex?
No. Binary searching, which we want to use in a build-time check for
CET-IBT.
https://lore.kernel.org/xen-devel/8c6d9714-7e45-1603-a5ad-d49fc060304e@srcf.net/
~Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-18 16:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-18 13:17 [PATCH] CI: Add gnu grep to alpine containers Andrew Cooper
2022-02-18 14:39 ` Anthony PERARD
2022-02-18 16:28 ` Stefano Stabellini
2022-02-18 16:31 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.