[PATCH 0/2] J721E: Fix bootcmd

[PATCH 0/2] J721E: Fix bootcmd

[Aswath Govindraju]

The following series of patches fix the bootcmd for J721e,
- adds the command 'run boot_rpocs' for booting remote processors
  from U-Boot (As it was earlier)
- removes setting of dorprocboot to 1. Since this should be
  set by the user and not set by default
- Syncs the bootcmd of hs configs with GP.

Aswath Govindraju (2):
  configs: j721e_evm_a72_defconfig: Fix the bootcmd
  configs: j721e_hs_evm_a72_defconfig: Sync up the bootcmd with GP
    configs

 configs/j721e_evm_a72_defconfig    | 2 +-
 configs/j721e_hs_evm_a72_defconfig | 2 +-
 include/configs/j721e_evm.h        | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)

-- 
2.17.1

[PATCH 1/2] configs: j721e_evm_a72_defconfig: Fix the bootcmd

[Aswath Govindraju]

In J721e remote processors are booted from U-Boot by using the command
'boot_rprocs' and the env variable 'dorprocboot'. Remote processors are
booted only when 'dorprocboot' it set to 1. By default this variable is set
to 0, so that it can be enabled through user specific environment files.

Therefore, fix the bootcmd to reflect the same.

Fixes: 5980925e2a5a ("include: configs: j721e_evm: Add support to boot ethfw core in j721e")
Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
 configs/j721e_evm_a72_defconfig | 2 +-
 include/configs/j721e_evm.h     | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/configs/j721e_evm_a72_defconfig b/configs/j721e_evm_a72_defconfig
index b843a84415b1..4d62585b247c 100644
--- a/configs/j721e_evm_a72_defconfig
+++ b/configs/j721e_evm_a72_defconfig
@@ -29,7 +29,7 @@ CONFIG_DISTRO_DEFAULTS=y
 CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
 # CONFIG_USE_SPL_FIT_GENERATOR is not set
-CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd; run init_${boot}; run main_cpsw0_qsgmii_phyinit; run get_kern_${boot}; run get_fdt_${boot}; run get_overlay_${boot}; run run_kern"
+CONFIG_BOOTCOMMAND="run findfdt; run distro_bootcmd; run init_${boot}; run boot_rprocs; run main_cpsw0_qsgmii_phyinit; run get_kern_${boot}; run get_fdt_${boot}; run get_overlay_${boot}; run run_kern"
 CONFIG_LOGLEVEL=7
 CONFIG_SPL_BOARD_INIT=y
 CONFIG_SPL_SYS_MALLOC_SIMPLE=y
diff --git a/include/configs/j721e_evm.h b/include/configs/j721e_evm.h
index e4b167dd219d..2d86b7fbb089 100644
--- a/include/configs/j721e_evm.h
+++ b/include/configs/j721e_evm.h
@@ -124,7 +124,6 @@
 /* Set the default list of remote processors to boot */
 #if defined(CONFIG_TARGET_J721E_A72_EVM) || defined(CONFIG_TARGET_J7200_A72_EVM)
 #define EXTRA_ENV_CONFIG_MAIN_CPSW0_QSGMII_PHY				\
-	"dorprocboot=1\0"						\
 	"do_main_cpsw0_qsgmii_phyinit=1\0"				\
 	"init_main_cpsw0_qsgmii_phy=gpio set gpio@22_17;"		\
 		 "gpio clear gpio@22_16\0"				\
-- 
2.17.1

[PATCH 2/2] configs: j721e_hs_evm_a72_defconfig: Sync up the bootcmd with GP configs

[Aswath Govindraju]

Sync up the bootcmd with GP configs, to initialize the QSGMII phy required
for ethfw.

Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
---
 configs/j721e_hs_evm_a72_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/j721e_hs_evm_a72_defconfig b/configs/j721e_hs_evm_a72_defconfig
index ae184b035878..545746ef7aee 100644
--- a/configs/j721e_hs_evm_a72_defconfig
+++ b/configs/j721e_hs_evm_a72_defconfig
@@ -30,7 +30,7 @@ CONFIG_SPL_LOAD_FIT=y
 CONFIG_SPL_LOAD_FIT_ADDRESS=0x81000000
 CONFIG_SPL_FIT_IMAGE_POST_PROCESS=y
 # CONFIG_USE_SPL_FIT_GENERATOR is not set
-CONFIG_BOOTCOMMAND="run findfdt; run envboot; run init_${boot}; run boot_rprocs; run get_fit_${boot}; run get_overlaystring; run run_fit"
+CONFIG_BOOTCOMMAND="run findfdt; run envboot; run init_${boot}; run boot_rprocs; run main_cpsw0_qsgmii_phyinit; run get_fit_${boot}; run get_overlaystring; run run_fit"
 CONFIG_LOGLEVEL=7
 CONFIG_SPL_BOARD_INIT=y
 CONFIG_SPL_SYS_MALLOC_SIMPLE=y
-- 
2.17.1

Re: [PATCH 0/2] J721E: Fix bootcmd

[Aswath Govindraju]

Hi,

On 18/02/22 6:59 pm, Aswath Govindraju wrote:
> The following series of patches fix the bootcmd for J721e,
> - adds the command 'run boot_rpocs' for booting remote processors
>   from U-Boot (As it was earlier)
> - removes setting of dorprocboot to 1. Since this should be
>   set by the user and not set by default
> - Syncs the bootcmd of hs configs with GP.
> 

Please do not apply this patch as I have found out that there are few
fixes that need to done. I will be posting a v2 of this series soon.

> Aswath Govindraju (2):
>   configs: j721e_evm_a72_defconfig: Fix the bootcmd
>   configs: j721e_hs_evm_a72_defconfig: Sync up the bootcmd with GP
>     configs
> 
>  configs/j721e_evm_a72_defconfig    | 2 +-
>  configs/j721e_hs_evm_a72_defconfig | 2 +-
>  include/configs/j721e_evm.h        | 1 -
>  3 files changed, 2 insertions(+), 3 deletions(-)
> 


-- 
Thanks,
Aswath