* [PATCH 0/2] Minor doc fixes
@ 2022-02-18 14:55 Markus Armbruster
2022-02-18 14:55 ` [PATCH 1/2] keyval: Fix grammar comment to cover downstream prefix Markus Armbruster
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Markus Armbruster @ 2022-02-18 14:55 UTC (permalink / raw)
To: qemu-devel; +Cc: michael.roth, vsementsov
Markus Armbruster (2):
keyval: Fix grammar comment to cover downstream prefix
qapi: Fix stale reference to scripts/qapi.py in a comment
qapi/qapi-util.c | 2 +-
util/keyval.c | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] keyval: Fix grammar comment to cover downstream prefix
2022-02-18 14:55 [PATCH 0/2] Minor doc fixes Markus Armbruster
@ 2022-02-18 14:55 ` Markus Armbruster
2022-02-18 14:55 ` [PATCH 2/2] qapi: Fix stale reference to scripts/qapi.py in a comment Markus Armbruster
2022-02-25 8:50 ` [PATCH 0/2] Minor doc fixes Markus Armbruster
2 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2022-02-18 14:55 UTC (permalink / raw)
To: qemu-devel; +Cc: michael.roth, vsementsov
According to the grammar, a key __com.redhat_foo would be parsed as
two key fragments __com and redhat_foo. It's actually parsed as a
single fragment. Fix the grammar.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
util/keyval.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/util/keyval.c b/util/keyval.c
index 904337c8a1..0cf2e84dc8 100644
--- a/util/keyval.c
+++ b/util/keyval.c
@@ -16,7 +16,9 @@
* key-vals = [ key-val { ',' key-val } [ ',' ] ]
* key-val = key '=' val | help
* key = key-fragment { '.' key-fragment }
- * key-fragment = / [^=,.]+ /
+ * key-fragment = qapi-name | index
+ * qapi-name = '__' / [a-z0-9.-]+ / '_' / [A-Za-z][A-Za-z0-9_-]* /
+ * index = / [0-9]+ /
* val = { / [^,]+ / | ',,' }
* help = 'help' | '?'
*
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] qapi: Fix stale reference to scripts/qapi.py in a comment
2022-02-18 14:55 [PATCH 0/2] Minor doc fixes Markus Armbruster
2022-02-18 14:55 ` [PATCH 1/2] keyval: Fix grammar comment to cover downstream prefix Markus Armbruster
@ 2022-02-18 14:55 ` Markus Armbruster
2022-02-18 17:35 ` Philippe Mathieu-Daudé via
2022-02-25 8:50 ` [PATCH 0/2] Minor doc fixes Markus Armbruster
2 siblings, 1 reply; 6+ messages in thread
From: Markus Armbruster @ 2022-02-18 14:55 UTC (permalink / raw)
To: qemu-devel; +Cc: michael.roth, vsementsov
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qapi/qapi-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/qapi-util.c b/qapi/qapi-util.c
index fda7044539..63596e11c5 100644
--- a/qapi/qapi-util.c
+++ b/qapi/qapi-util.c
@@ -113,7 +113,7 @@ bool qapi_bool_parse(const char *name, const char *value, bool *obj, Error **err
* may contain only letters, digits, hyphen and period.
* The special exception for enumeration names is not implemented.
* See docs/devel/qapi-code-gen.txt for more on QAPI naming rules.
- * Keep this consistent with scripts/qapi.py!
+ * Keep this consistent with scripts/qapi-gen.py!
* If @complete, the parse fails unless it consumes @str completely.
* Return its length on success, -1 on failure.
*/
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Minor doc fixes
2022-02-18 14:55 [PATCH 0/2] Minor doc fixes Markus Armbruster
2022-02-18 14:55 ` [PATCH 1/2] keyval: Fix grammar comment to cover downstream prefix Markus Armbruster
2022-02-18 14:55 ` [PATCH 2/2] qapi: Fix stale reference to scripts/qapi.py in a comment Markus Armbruster
@ 2022-02-25 8:50 ` Markus Armbruster
2 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2022-02-25 8:50 UTC (permalink / raw)
To: qemu-devel; +Cc: michael.roth, vsementsov
Queued.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/2] minor doc fixes
@ 2021-05-09 9:09 Martin Ågren
0 siblings, 0 replies; 6+ messages in thread
From: Martin Ågren @ 2021-05-09 9:09 UTC (permalink / raw)
To: git; +Cc: ZheNing Hu, Taylor Blau
Two small things I noticed while going through the doc-diff between
v2.31.0 and master ("The fourteenth batch").
Martin Ågren (2):
git-repack.txt: remove spurious ")"
pretty-formats.txt: add missing space
Documentation/git-repack.txt | 2 +-
Documentation/pretty-formats.txt | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.31.1.751.gd2f1c929bd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-25 10:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-18 14:55 [PATCH 0/2] Minor doc fixes Markus Armbruster
2022-02-18 14:55 ` [PATCH 1/2] keyval: Fix grammar comment to cover downstream prefix Markus Armbruster
2022-02-18 14:55 ` [PATCH 2/2] qapi: Fix stale reference to scripts/qapi.py in a comment Markus Armbruster
2022-02-18 17:35 ` Philippe Mathieu-Daudé via
2022-02-25 8:50 ` [PATCH 0/2] Minor doc fixes Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2021-05-09 9:09 [PATCH 0/2] minor " Martin Ågren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.