All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: robh+dt@kernel.org, thierry.reding@gmail.com
Cc: sam@ravnborg.org, maxime@cerno.tech,
	dave.stevenson@raspberrypi.com, david@lechnology.com,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Noralf Trønnes" <noralf@tronnes.org>
Subject: [PATCH v4 2/3] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev
Date: Fri, 18 Feb 2022 16:11:09 +0100	[thread overview]
Message-ID: <20220218151110.11316-3-noralf@tronnes.org> (raw)
In-Reply-To: <20220218151110.11316-1-noralf@tronnes.org>

devm_drm_dev_alloc() can't allocate structures that embed a structure
which then again embeds drm_device. Workaround this by adding a
driver_private pointer to struct mipi_dbi_dev which the driver can use for
its additional state.

v3:
- Add documentation

Acked-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 include/drm/drm_mipi_dbi.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/drm/drm_mipi_dbi.h b/include/drm/drm_mipi_dbi.h
index 6fe13cce2670..dad2f187b64b 100644
--- a/include/drm/drm_mipi_dbi.h
+++ b/include/drm/drm_mipi_dbi.h
@@ -130,6 +130,14 @@ struct mipi_dbi_dev {
 	 * @dbi: MIPI DBI interface
 	 */
 	struct mipi_dbi dbi;
+
+	/**
+	 * @driver_private: Driver private data.
+	 *                  Necessary for drivers with private data since devm_drm_dev_alloc()
+	 *                  can't allocate structures that embed a structure which then again
+	 *                  embeds drm_device.
+	 */
+	void *driver_private;
 };
 
 static inline struct mipi_dbi_dev *drm_to_mipi_dbi_dev(struct drm_device *drm)
-- 
2.33.0


WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org>
To: robh+dt@kernel.org, thierry.reding@gmail.com
Cc: devicetree@vger.kernel.org, david@lechnology.com,
	dave.stevenson@raspberrypi.com, dri-devel@lists.freedesktop.org,
	"Noralf Trønnes" <noralf@tronnes.org>,
	maxime@cerno.tech, sam@ravnborg.org
Subject: [PATCH v4 2/3] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev
Date: Fri, 18 Feb 2022 16:11:09 +0100	[thread overview]
Message-ID: <20220218151110.11316-3-noralf@tronnes.org> (raw)
In-Reply-To: <20220218151110.11316-1-noralf@tronnes.org>

devm_drm_dev_alloc() can't allocate structures that embed a structure
which then again embeds drm_device. Workaround this by adding a
driver_private pointer to struct mipi_dbi_dev which the driver can use for
its additional state.

v3:
- Add documentation

Acked-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 include/drm/drm_mipi_dbi.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/drm/drm_mipi_dbi.h b/include/drm/drm_mipi_dbi.h
index 6fe13cce2670..dad2f187b64b 100644
--- a/include/drm/drm_mipi_dbi.h
+++ b/include/drm/drm_mipi_dbi.h
@@ -130,6 +130,14 @@ struct mipi_dbi_dev {
 	 * @dbi: MIPI DBI interface
 	 */
 	struct mipi_dbi dbi;
+
+	/**
+	 * @driver_private: Driver private data.
+	 *                  Necessary for drivers with private data since devm_drm_dev_alloc()
+	 *                  can't allocate structures that embed a structure which then again
+	 *                  embeds drm_device.
+	 */
+	void *driver_private;
 };
 
 static inline struct mipi_dbi_dev *drm_to_mipi_dbi_dev(struct drm_device *drm)
-- 
2.33.0


  parent reply	other threads:[~2022-02-18 15:11 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18 15:11 [PATCH v4 0/3] drm/tiny: Add MIPI DBI compatible SPI driver Noralf Trønnes
2022-02-18 15:11 ` Noralf Trønnes
2022-02-18 15:11 ` [PATCH v4 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels Noralf Trønnes
2022-02-18 15:11   ` Noralf Trønnes
2022-02-19 15:25   ` Sam Ravnborg
2022-02-19 15:25     ` Sam Ravnborg
2022-02-21  2:36   ` Rob Herring
2022-02-21  2:36     ` Rob Herring
2022-02-21 11:31   ` Noralf Trønnes
2022-02-21 11:31     ` Noralf Trønnes
2022-02-22 17:26     ` Rob Herring
2022-02-22 17:26       ` Rob Herring
2022-02-18 15:11 ` Noralf Trønnes [this message]
2022-02-18 15:11   ` [PATCH v4 2/3] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev Noralf Trønnes
2022-02-19 15:25   ` Sam Ravnborg
2022-02-19 15:25     ` Sam Ravnborg
2022-02-18 15:11 ` [PATCH v4 3/3] drm/tiny: Add MIPI DBI compatible SPI driver Noralf Trønnes
2022-02-18 15:11   ` Noralf Trønnes
2022-02-19 22:10   ` Sam Ravnborg
2022-02-19 22:10     ` Sam Ravnborg
2022-02-20 10:04     ` Sam Ravnborg
2022-02-20 14:19       ` Noralf Trønnes
2022-02-20 18:11         ` Noralf Trønnes
2022-02-20 18:11           ` Noralf Trønnes
2022-02-20 19:57           ` Sam Ravnborg
2022-02-20 19:57             ` Sam Ravnborg
2022-02-20 20:34             ` Noralf Trønnes
2022-02-20 20:34               ` Noralf Trønnes
2022-02-20 21:30               ` Sam Ravnborg
2022-02-20 21:30                 ` Sam Ravnborg
2022-02-20 15:59     ` Noralf Trønnes
2022-02-20 15:59       ` Noralf Trønnes
2022-02-20 21:32       ` Sam Ravnborg
2022-02-20 21:32         ` Sam Ravnborg
2022-02-21  9:05         ` Maxime Ripard
2022-02-21  9:05           ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220218151110.11316-3-noralf@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=david@lechnology.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=maxime@cerno.tech \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.