* [PATCH] sched: Fix stale try_invoke_on_locked_down_task comment
@ 2021-12-30 19:36 David Vernet
2022-02-18 15:23 ` David Vernet
0 siblings, 1 reply; 2+ messages in thread
From: David Vernet @ 2021-12-30 19:36 UTC (permalink / raw)
To: linux-kernel, peterz
Cc: mingo, juri.lelli, vincent.guittot, dietmar.eggemann, rostedt,
bsegall, mgorman, bristot, void
In 9b3c4ab3045e, try_invoke_on_locked_down_task() was renamed to
task_call_func(), and several callers, comments, etc were updated to use
the new name and signature. There was one comment in try_to_wake_up() that
was missed, and still refers to the old name. This diff corrects that
comment to refer to the new name.
Fixes: 9b3c4ab3045e ("sched,rcu: Rework try_invoke_on_locked_down_task()")
Signed-off-by: David Vernet <void@manifault.com>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index fe53e510e711..ec78cf2e97f0 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4038,7 +4038,7 @@ try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags)
* Pairs with the LOCK+smp_mb__after_spinlock() on rq->lock in
* __schedule(). See the comment for smp_mb__after_spinlock().
*
- * A similar smb_rmb() lives in try_invoke_on_locked_down_task().
+ * A similar smb_rmb() lives in task_call_func().
*/
smp_rmb();
if (READ_ONCE(p->on_rq) && ttwu_runnable(p, wake_flags))
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] sched: Fix stale try_invoke_on_locked_down_task comment
2021-12-30 19:36 [PATCH] sched: Fix stale try_invoke_on_locked_down_task comment David Vernet
@ 2022-02-18 15:23 ` David Vernet
0 siblings, 0 replies; 2+ messages in thread
From: David Vernet @ 2022-02-18 15:23 UTC (permalink / raw)
To: peterz, linux-kernel
Cc: void, kernel-team, mingo, juri.lelli, vincent.guittot,
dietmar.eggemann, rostedt, bsegall, mgorman, bristot
In 9b3c4ab3045e, try_invoke_on_locked_down_task() was renamed to
task_call_func(), and several callers, comments, etc were updated to use
the new name and signature. There was one comment in try_to_wake_up() that
was missed, and still refers to the old name. This diff corrects that
comment to refer to the new name.
Fixes: 9b3c4ab3045e ("sched,rcu: Rework try_invoke_on_locked_down_task()")
Signed-off-by: David Vernet <void@manifault.com>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 1e08b02e0cd5..d76e3da0d7d6 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4042,7 +4042,7 @@ try_to_wake_up(struct task_struct *p, unsigned int state, int wake_flags)
* Pairs with the LOCK+smp_mb__after_spinlock() on rq->lock in
* __schedule(). See the comment for smp_mb__after_spinlock().
*
- * A similar smb_rmb() lives in try_invoke_on_locked_down_task().
+ * A similar smb_rmb() lives in task_call_func().
*/
smp_rmb();
if (READ_ONCE(p->on_rq) && ttwu_runnable(p, wake_flags))
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-18 15:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-30 19:36 [PATCH] sched: Fix stale try_invoke_on_locked_down_task comment David Vernet
2022-02-18 15:23 ` David Vernet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.