[PATCH 3/3] dpp: check return of aes_siv_encrypt

[PATCH 3/3] dpp: check return of aes_siv_encrypt

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

This was caught by static analysis. As is common this should never
happen in the real world since the only way this can fail (apart from
extreme circumstances like OOM) is if the key size is incorrect, which
it will never be.
---
 src/dpp.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/dpp.c b/src/dpp.c
index f664e490..54662e8f 100644
--- a/src/dpp.c
+++ b/src/dpp.c
@@ -1070,8 +1070,11 @@ static void send_authenticate_response(struct dpp_sm *dpp)
 	 * do not use AAD; in other words, the number of AAD components is set
 	 * to zero.""
 	 */
-	aes_siv_encrypt(dpp->ke, dpp->key_len, wrapped2_plaintext,
-					dpp->key_len + 4, NULL, 0, wrapped2);
+	if (!aes_siv_encrypt(dpp->ke, dpp->key_len, wrapped2_plaintext,
+					dpp->key_len + 4, NULL, 0, wrapped2)) {
+		l_error("Failed to encrypt wrapped data");
+		return;
+	}
 
 	wrapped2_len += 16;
 
-- 
2.34.1

Re: [PATCH 3/3] dpp: check return of aes_siv_encrypt

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

Hi James,

On 2/18/22 13:55, James Prestwood wrote:
> This was caught by static analysis. As is common this should never
> happen in the real world since the only way this can fail (apart from
> extreme circumstances like OOM) is if the key size is incorrect, which
> it will never be.
> ---
>   src/dpp.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 

Applied, thanks.

Regards,
-Denis