[PATCH v2 net-next] net: dm9051: Fix use after free in dm9051_loop_tx()

* [PATCH v2 net-next] net: dm9051: Fix use after free in dm9051_loop_tx()
@ 2022-02-21 10:54 Dan Carpenter
  2022-02-22  5:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-02-21 10:54 UTC (permalink / raw)
  To: David S. Miller, Joseph CHAMG
  Cc: Jakub Kicinski, Joseph CHAMG, netdev, kernel-janitors

This code dereferences "skb" after calling dev_kfree_skb().

Fixes: 2dc95a4d30ed ("net: Add dm9051 driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: Only record successful transfers

 drivers/net/ethernet/davicom/dm9051.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/davicom/dm9051.c b/drivers/net/ethernet/davicom/dm9051.c
index a63d17e669a0..20cdca06d267 100644
--- a/drivers/net/ethernet/davicom/dm9051.c
+++ b/drivers/net/ethernet/davicom/dm9051.c
@@ -845,17 +845,19 @@ static int dm9051_loop_tx(struct board_info *db)
 
 	while (!skb_queue_empty(&db->txq)) {
 		struct sk_buff *skb;
+		unsigned int len;
 
 		skb = skb_dequeue(&db->txq);
 		if (skb) {
 			ntx++;
 			ret = dm9051_single_tx(db, skb->data, skb->len);
+			len = skb->len;
 			dev_kfree_skb(skb);
 			if (ret < 0) {
 				db->bc.tx_err_counter++;
 				return 0;
 			}
-			ndev->stats.tx_bytes += skb->len;
+			ndev->stats.tx_bytes += len;
 			ndev->stats.tx_packets++;
 		}
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread