Re: [RFC PATCH 8/8] arm64: dts: ti: use 'freq-table' in UFS node

From: Nishanth Menon <nm@ti.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	Rob Herring <robh+dt@kernel.org>, Wei Xu <xuwei5@hisilicon.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Chanho Park <chanho61.park@samsung.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Jan Kotas <jank@cadence.com>, <linux-scsi@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>
Subject: Re: [RFC PATCH 8/8] arm64: dts: ti: use 'freq-table' in UFS node
Date: Mon, 21 Feb 2022 07:13:40 -0600	[thread overview]
Message-ID: <20220221131340.q3hjpjevqrfvhggv@specimen> (raw)
In-Reply-To: <20220219184554.44887-1-krzysztof.kozlowski@canonical.com>

On 19:45-20220219, Krzysztof Kozlowski wrote:
> The 'freq-table-hz' property is deprecated by UFS bindings.
> The uint32-array requires also element to be passed within one <> block.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index 599861259a30..c3afef0321ae 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -1257,7 +1257,9 @@ ufs@4e84000 {
>  			compatible = "cdns,ufshc-m31-16nm", "jedec,ufs-2.0";
>  			reg = <0x0 0x4e84000 0x0 0x10000>;
>  			interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> -			freq-table-hz = <250000000 250000000>, <19200000 19200000>, <19200000 19200000>;
> +			freq-table = <250000000 250000000

<min max> is much more readable and less error prone in case of a large
set.

> +				      19200000 19200000
> +				      19200000 19200000>;

are you sure the removal of the tuple adds value?

>  			clocks = <&k3_clks 277 0>, <&k3_clks 277 1>, <&k3_clks 277 1>;
>  			clock-names = "core_clk", "phy_clk", "ref_clk";
>  			dma-coherent;
> -- 
> 2.32.0
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D