All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm: pdu001: Setup pinmux for console UART as early as possible
@ 2022-02-21 13:26 Felix Brack
  2022-02-21 13:34 ` Tom Rini
  2022-02-28 20:47 ` Tom Rini
  0 siblings, 2 replies; 5+ messages in thread
From: Felix Brack @ 2022-02-21 13:26 UTC (permalink / raw)
  To: u-boot; +Cc: Felix Brack, Tom Rini

To make sure we get a working console as soon as possible in the SPL the
UART pins require to be configured earlier. This is especially
true for the pins of UART3, since the PDU001 board uses this UART for
the console by default.

Signed-off-by: Felix Brack <fb@ltec.ch>
---

 board/eets/pdu001/board.c | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/board/eets/pdu001/board.c b/board/eets/pdu001/board.c
index 9f3cfd4f84..4aeb84071b 100644
--- a/board/eets/pdu001/board.c
+++ b/board/eets/pdu001/board.c
@@ -216,6 +216,36 @@ const struct dpll_params *get_dpll_ddr_params(void)
 	return &dpll_ddr;
 }
 
+void set_uart_mux_conf(void)
+{
+	switch (CONFIG_CONS_INDEX) {
+		case 1: {
+			enable_uart0_pin_mux();
+			break;
+		}
+		case 2: {
+			enable_uart1_pin_mux();
+			break;
+		}
+		case 3: {
+			enable_uart2_pin_mux();
+			break;
+		}
+		case 4: {
+			enable_uart3_pin_mux();
+			break;
+		}
+		case 5: {
+			enable_uart4_pin_mux();
+			break;
+		}
+		case 6: {
+			enable_uart5_pin_mux();
+			break;
+		}
+	}
+}
+
 void set_mux_conf_regs(void)
 {
 	/* done first by the ROM and afterwards by the pin controller driver */
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: pdu001: Setup pinmux for console UART as early as possible
  2022-02-21 13:26 [PATCH] arm: pdu001: Setup pinmux for console UART as early as possible Felix Brack
@ 2022-02-21 13:34 ` Tom Rini
  2022-02-21 13:50   ` Felix Brack
  2022-02-28 20:47 ` Tom Rini
  1 sibling, 1 reply; 5+ messages in thread
From: Tom Rini @ 2022-02-21 13:34 UTC (permalink / raw)
  To: Felix Brack; +Cc: u-boot

[-- Attachment #1: Type: text/plain, Size: 620 bytes --]

On Mon, Feb 21, 2022 at 02:26:05PM +0100, Felix Brack wrote:

> To make sure we get a working console as soon as possible in the SPL the
> UART pins require to be configured earlier. This is especially
> true for the pins of UART3, since the PDU001 board uses this UART for
> the console by default.
> 
> Signed-off-by: Felix Brack <fb@ltec.ch>
> ---
> 
>  board/eets/pdu001/board.c | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)

Does this replace
https://patchwork.ozlabs.org/project/uboot/patch/20220215142723.45242-1-fb@ltec.ch/
or go in addition to it?  Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: pdu001: Setup pinmux for console UART as early as possible
  2022-02-21 13:34 ` Tom Rini
@ 2022-02-21 13:50   ` Felix Brack
  2022-02-21 14:09     ` Tom Rini
  0 siblings, 1 reply; 5+ messages in thread
From: Felix Brack @ 2022-02-21 13:50 UTC (permalink / raw)
  To: Tom Rini; +Cc: u-boot

Hi Tom,

On 21.02.22 14:34, Tom Rini wrote:
> On Mon, Feb 21, 2022 at 02:26:05PM +0100, Felix Brack wrote:
> 
>> To make sure we get a working console as soon as possible in the SPL the
>> UART pins require to be configured earlier. This is especially
>> true for the pins of UART3, since the PDU001 board uses this UART for
>> the console by default.
>>
>> Signed-off-by: Felix Brack <fb@ltec.ch>
>> ---
>>
>>  board/eets/pdu001/board.c | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
> 
> Does this replace
> https://patchwork.ozlabs.org/project/uboot/patch/20220215142723.45242-1-fb@ltec.ch/
> or go in addition to it?  Thanks!
> 
No it's not a replacement. It is kind of addition but not related to the
early debugging UART, hence a second patch.

-- 
Regards, Felix


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: pdu001: Setup pinmux for console UART as early as possible
  2022-02-21 13:50   ` Felix Brack
@ 2022-02-21 14:09     ` Tom Rini
  0 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2022-02-21 14:09 UTC (permalink / raw)
  To: Felix Brack; +Cc: u-boot

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

On Mon, Feb 21, 2022 at 02:50:19PM +0100, Felix Brack wrote:
> Hi Tom,
> 
> On 21.02.22 14:34, Tom Rini wrote:
> > On Mon, Feb 21, 2022 at 02:26:05PM +0100, Felix Brack wrote:
> > 
> >> To make sure we get a working console as soon as possible in the SPL the
> >> UART pins require to be configured earlier. This is especially
> >> true for the pins of UART3, since the PDU001 board uses this UART for
> >> the console by default.
> >>
> >> Signed-off-by: Felix Brack <fb@ltec.ch>
> >> ---
> >>
> >>  board/eets/pdu001/board.c | 30 ++++++++++++++++++++++++++++++
> >>  1 file changed, 30 insertions(+)
> > 
> > Does this replace
> > https://patchwork.ozlabs.org/project/uboot/patch/20220215142723.45242-1-fb@ltec.ch/
> > or go in addition to it?  Thanks!
> > 
> No it's not a replacement. It is kind of addition but not related to the
> early debugging UART, hence a second patch.

OK, thanks just confirming.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] arm: pdu001: Setup pinmux for console UART as early as possible
  2022-02-21 13:26 [PATCH] arm: pdu001: Setup pinmux for console UART as early as possible Felix Brack
  2022-02-21 13:34 ` Tom Rini
@ 2022-02-28 20:47 ` Tom Rini
  1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2022-02-28 20:47 UTC (permalink / raw)
  To: Felix Brack; +Cc: u-boot

[-- Attachment #1: Type: text/plain, Size: 402 bytes --]

On Mon, Feb 21, 2022 at 02:26:05PM +0100, Felix Brack wrote:

> To make sure we get a working console as soon as possible in the SPL the
> UART pins require to be configured earlier. This is especially
> true for the pins of UART3, since the PDU001 board uses this UART for
> the console by default.
> 
> Signed-off-by: Felix Brack <fb@ltec.ch>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-02-28 20:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-21 13:26 [PATCH] arm: pdu001: Setup pinmux for console UART as early as possible Felix Brack
2022-02-21 13:34 ` Tom Rini
2022-02-21 13:50   ` Felix Brack
2022-02-21 14:09     ` Tom Rini
2022-02-28 20:47 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.