All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next v3 2/2] net: dsa: OF-ware slave_mii_bus
@ 2022-02-21 20:04 Luiz Angelo Daros de Luca
  2022-02-21 21:52 ` Andrew Lunn
  2022-02-22  3:02 ` Florian Fainelli
  0 siblings, 2 replies; 3+ messages in thread
From: Luiz Angelo Daros de Luca @ 2022-02-21 20:04 UTC (permalink / raw)
  To: netdev
  Cc: andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba,
	Luiz Angelo Daros de Luca

If found, register the DSA internally allocated slave_mii_bus with an OF
"mdio" child object. It can save some drivers from creating their
custom internal MDIO bus.

Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
---
 net/dsa/dsa2.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index e498c927c3d0..2206e2d2a7b3 100644
--- a/net/dsa/dsa2.c
+++ b/net/dsa/dsa2.c
@@ -13,6 +13,7 @@
 #include <linux/slab.h>
 #include <linux/rtnetlink.h>
 #include <linux/of.h>
+#include <linux/of_mdio.h>
 #include <linux/of_net.h>
 #include <net/devlink.h>
 #include <net/sch_generic.h>
@@ -869,6 +870,7 @@ static int dsa_switch_setup_tag_protocol(struct dsa_switch *ds)
 static int dsa_switch_setup(struct dsa_switch *ds)
 {
 	struct dsa_devlink_priv *dl_priv;
+	struct device_node *dn;
 	struct dsa_port *dp;
 	int err;
 
@@ -924,7 +926,10 @@ static int dsa_switch_setup(struct dsa_switch *ds)
 
 		dsa_slave_mii_bus_init(ds);
 
-		err = mdiobus_register(ds->slave_mii_bus);
+		dn = of_get_child_by_name(ds->dev->of_node, "mdio");
+
+		err = of_mdiobus_register(ds->slave_mii_bus, dn);
+		of_node_put(dn);
 		if (err < 0)
 			goto free_slave_mii_bus;
 	}
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next v3 2/2] net: dsa: OF-ware slave_mii_bus
  2022-02-21 20:04 [PATCH net-next v3 2/2] net: dsa: OF-ware slave_mii_bus Luiz Angelo Daros de Luca
@ 2022-02-21 21:52 ` Andrew Lunn
  2022-02-22  3:02 ` Florian Fainelli
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2022-02-21 21:52 UTC (permalink / raw)
  To: Luiz Angelo Daros de Luca
  Cc: netdev, vivien.didelot, f.fainelli, olteanv, davem, kuba

On Mon, Feb 21, 2022 at 05:04:07PM -0300, Luiz Angelo Daros de Luca wrote:
> If found, register the DSA internally allocated slave_mii_bus with an OF
> "mdio" child object. It can save some drivers from creating their
> custom internal MDIO bus.
> 
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next v3 2/2] net: dsa: OF-ware slave_mii_bus
  2022-02-21 20:04 [PATCH net-next v3 2/2] net: dsa: OF-ware slave_mii_bus Luiz Angelo Daros de Luca
  2022-02-21 21:52 ` Andrew Lunn
@ 2022-02-22  3:02 ` Florian Fainelli
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2022-02-22  3:02 UTC (permalink / raw)
  To: Luiz Angelo Daros de Luca, netdev
  Cc: andrew, vivien.didelot, olteanv, davem, kuba



On 2/21/2022 12:04 PM, Luiz Angelo Daros de Luca wrote:
> If found, register the DSA internally allocated slave_mii_bus with an OF
> "mdio" child object. It can save some drivers from creating their
> custom internal MDIO bus.
> 
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-22  3:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-21 20:04 [PATCH net-next v3 2/2] net: dsa: OF-ware slave_mii_bus Luiz Angelo Daros de Luca
2022-02-21 21:52 ` Andrew Lunn
2022-02-22  3:02 ` Florian Fainelli

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.