From: "Maíra Canal" <maira.canal@usp.br> To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, Hawking.Zhang@amd.com, john.clements@amd.com, tao.zhou1@amd.com, YiPeng.Chai@amd.com, luben.tuikov@amd.com, Stanley.Yang@amd.com, Dennis.Li@amd.com, mukul.joshi@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Anthony.Koo@amd.com Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, magalilemes00@gmail.com, mwen@igalia.com, isabbasso@riseup.net, "Maíra Canal" <maira.canal@usp.br> Subject: [PATCH 05/10] drm/amd/display: Remove unused dcn316_smu_set_voltage_via_phyclk function Date: Tue, 22 Feb 2022 10:16:56 -0300 [thread overview] Message-ID: <20220222131701.356117-6-maira.canal@usp.br> (raw) In-Reply-To: <20220222131701.356117-1-maira.canal@usp.br> Remove dcn316_smu_set_voltage_via_phyclk function, which is not used in the codebase. This was pointed by clang with the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_smu.c:171:5: warning: no previous prototype for function 'dcn316_smu_set_voltage_via_phyclk' [-Wmissing-prototypes] int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int requested_phyclk_khz) ^ Signed-off-by: Maíra Canal <maira.canal@usp.br> --- .../amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c index b7f9e1b34c11..fd6497fd2dc5 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c @@ -168,22 +168,6 @@ int dcn316_smu_set_dispclk(struct clk_mgr_internal *clk_mgr, int requested_dispc return actual_dispclk_set_mhz * 1000; } -int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int requested_phyclk_khz) -{ - int actual_phypclk_set_mhz = -1; - - if (!clk_mgr->smu_present && requested_phyclk_khz) - return requested_phyclk_khz; - - /* Unit of SMU msg parameter is Mhz */ - actual_phypclk_set_mhz = dcn316_smu_send_msg_with_param( - clk_mgr, - VBIOSSMC_MSG_SetPhyclkVoltageByFreq, - khz_to_mhz_ceil(requested_phyclk_khz)); - - return actual_phypclk_set_mhz * 1000; -} - int dcn316_smu_set_hard_min_dcfclk(struct clk_mgr_internal *clk_mgr, int requested_dcfclk_khz) { int actual_dcfclk_set_mhz = -1; -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: "Maíra Canal" <maira.canal@usp.br> To: alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, Hawking.Zhang@amd.com, john.clements@amd.com, tao.zhou1@amd.com, YiPeng.Chai@amd.com, luben.tuikov@amd.com, Stanley.Yang@amd.com, Dennis.Li@amd.com, mukul.joshi@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Anthony.Koo@amd.com Cc: magalilemes00@gmail.com, "Maíra Canal" <maira.canal@usp.br>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, mwen@igalia.com, amd-gfx@lists.freedesktop.org, isabbasso@riseup.net Subject: [PATCH 05/10] drm/amd/display: Remove unused dcn316_smu_set_voltage_via_phyclk function Date: Tue, 22 Feb 2022 10:16:56 -0300 [thread overview] Message-ID: <20220222131701.356117-6-maira.canal@usp.br> (raw) In-Reply-To: <20220222131701.356117-1-maira.canal@usp.br> Remove dcn316_smu_set_voltage_via_phyclk function, which is not used in the codebase. This was pointed by clang with the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_smu.c:171:5: warning: no previous prototype for function 'dcn316_smu_set_voltage_via_phyclk' [-Wmissing-prototypes] int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int requested_phyclk_khz) ^ Signed-off-by: Maíra Canal <maira.canal@usp.br> --- .../amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c index b7f9e1b34c11..fd6497fd2dc5 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c @@ -168,22 +168,6 @@ int dcn316_smu_set_dispclk(struct clk_mgr_internal *clk_mgr, int requested_dispc return actual_dispclk_set_mhz * 1000; } -int dcn316_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int requested_phyclk_khz) -{ - int actual_phypclk_set_mhz = -1; - - if (!clk_mgr->smu_present && requested_phyclk_khz) - return requested_phyclk_khz; - - /* Unit of SMU msg parameter is Mhz */ - actual_phypclk_set_mhz = dcn316_smu_send_msg_with_param( - clk_mgr, - VBIOSSMC_MSG_SetPhyclkVoltageByFreq, - khz_to_mhz_ceil(requested_phyclk_khz)); - - return actual_phypclk_set_mhz * 1000; -} - int dcn316_smu_set_hard_min_dcfclk(struct clk_mgr_internal *clk_mgr, int requested_dcfclk_khz) { int actual_dcfclk_set_mhz = -1; -- 2.35.1
next prev parent reply other threads:[~2022-02-22 13:18 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-22 13:16 [PATCH 00/10] Fix multiple compilation warnings Maíra Canal 2022-02-22 13:16 ` Maíra Canal 2022-02-22 13:16 ` [PATCH 01/10] drm/amdgpu: Change amdgpu_ras_block_late_init_default function scope Maíra Canal 2022-02-22 13:16 ` Maíra Canal 2022-02-22 16:27 ` Alex Deucher 2022-02-22 16:27 ` Alex Deucher 2022-02-22 16:27 ` Alex Deucher 2022-02-22 13:16 ` [PATCH 02/10] drm/amdgpu: Remove tmp unused variable Maíra Canal 2022-02-22 13:16 ` Maíra Canal 2022-02-22 16:29 ` Alex Deucher 2022-02-22 16:29 ` Alex Deucher 2022-02-22 16:29 ` Alex Deucher 2022-02-22 13:16 ` [PATCH 03/10] drm/amdgpu: Remove unused get_umc_v8_7_channel_index function Maíra Canal 2022-02-22 13:16 ` Maíra Canal 2022-02-22 16:29 ` Alex Deucher 2022-02-22 16:29 ` Alex Deucher 2022-02-22 16:29 ` Alex Deucher 2022-02-22 13:16 ` [PATCH 04/10] drm/amd/display: Remove unused temp variable Maíra Canal 2022-02-22 13:16 ` Maíra Canal 2022-02-22 16:31 ` Alex Deucher 2022-02-22 16:31 ` Alex Deucher 2022-02-22 16:31 ` Alex Deucher 2022-02-22 13:16 ` Maíra Canal [this message] 2022-02-22 13:16 ` [PATCH 05/10] drm/amd/display: Remove unused dcn316_smu_set_voltage_via_phyclk function Maíra Canal 2022-02-22 16:32 ` Alex Deucher 2022-02-22 16:32 ` Alex Deucher 2022-02-22 16:32 ` Alex Deucher 2022-02-22 13:16 ` [PATCH 06/10] drm/amd/display: Remove vupdate_int_entry definition Maíra Canal 2022-02-22 13:16 ` Maíra Canal 2022-02-22 16:38 ` Alex Deucher 2022-02-22 16:38 ` Alex Deucher 2022-02-22 16:38 ` Alex Deucher 2022-02-22 13:16 ` [PATCH 07/10] drm/amd/display: Remove unused dmub_outbox_irq_info_funcs variable Maíra Canal 2022-02-22 13:16 ` Maíra Canal 2022-02-22 16:38 ` Alex Deucher 2022-02-22 16:38 ` Alex Deucher 2022-02-22 16:38 ` Alex Deucher 2022-02-22 13:16 ` [PATCH 08/10] drm/amd/display: Remove unused variable Maíra Canal 2022-02-22 13:16 ` Maíra Canal 2022-02-22 16:40 ` Alex Deucher 2022-02-22 16:40 ` Alex Deucher 2022-02-22 16:40 ` Alex Deucher 2022-02-22 13:17 ` [PATCH 09/10] drm/amd/display: Add missing prototypes to dcn201_init Maíra Canal 2022-02-22 13:17 ` Maíra Canal 2022-02-22 16:41 ` Alex Deucher 2022-02-22 16:41 ` Alex Deucher 2022-02-22 16:41 ` Alex Deucher 2022-02-22 13:17 ` [PATCH 10/10] drm/amd/display: Turn global functions into static functions Maíra Canal 2022-02-22 13:17 ` Maíra Canal 2022-02-22 16:45 ` Alex Deucher 2022-02-22 16:45 ` Alex Deucher 2022-02-22 16:45 ` Alex Deucher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220222131701.356117-6-maira.canal@usp.br \ --to=maira.canal@usp.br \ --cc=Anthony.Koo@amd.com \ --cc=Dennis.Li@amd.com \ --cc=Hawking.Zhang@amd.com \ --cc=Rodrigo.Siqueira@amd.com \ --cc=Stanley.Yang@amd.com \ --cc=Xinhui.Pan@amd.com \ --cc=YiPeng.Chai@amd.com \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=harry.wentland@amd.com \ --cc=isabbasso@riseup.net \ --cc=john.clements@amd.com \ --cc=linux-kernel@vger.kernel.org \ --cc=luben.tuikov@amd.com \ --cc=magalilemes00@gmail.com \ --cc=mukul.joshi@amd.com \ --cc=mwen@igalia.com \ --cc=sunpeng.li@amd.com \ --cc=tao.zhou1@amd.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.