* Re: [PATCH] media: cec: seco: Drop pointless include
2022-02-22 16:01 [PATCH] media: cec: seco: Drop pointless include Linus Walleij
@ 2022-02-22 19:56 ` kernel test robot
2022-02-22 21:38 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-02-22 19:56 UTC (permalink / raw)
To: Linus Walleij, Hans Verkuil, linux-media
Cc: kbuild-all, Linus Walleij, Ettore Chimenti
Hi Linus,
I love your patch! Yet something to improve:
[auto build test ERROR on media-tree/master]
[also build test ERROR on v5.17-rc5 next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Linus-Walleij/media-cec-seco-Drop-pointless-include/20220223-000503
base: git://linuxtv.org/media_tree.git master
config: ia64-randconfig-r004-20220221 (https://download.01.org/0day-ci/archive/20220223/202202230327.ikz5OXY1-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3b2630b860ba004410fd27ad657355bcc0b9bd72
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Linus-Walleij/media-cec-seco-Drop-pointless-include/20220223-000503
git checkout 3b2630b860ba004410fd27ad657355bcc0b9bd72
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/media/cec/platform/seco/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/ia64/include/asm/pgtable.h:153,
from include/linux/pgtable.h:6,
from arch/ia64/include/asm/uaccess.h:40,
from include/linux/uaccess.h:11,
from arch/ia64/include/asm/sections.h:11,
from include/linux/interrupt.h:21,
from drivers/media/cec/platform/seco/seco-cec.c:15:
arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
arch/ia64/include/asm/mmu_context.h:127:48: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
127 | unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
| ^~~~~~~
drivers/media/cec/platform/seco/seco-cec.c: In function 'secocec_acpi_probe':
>> drivers/media/cec/platform/seco/seco-cec.c:553:42: error: 'GPIOF_IN' undeclared (first use in this function); did you mean 'GPIOD_IN'?
553 | gpio = devm_gpiod_get(dev, NULL, GPIOF_IN);
| ^~~~~~~~
| GPIOD_IN
drivers/media/cec/platform/seco/seco-cec.c:553:42: note: each undeclared identifier is reported only once for each function it appears in
vim +553 drivers/media/cec/platform/seco/seco-cec.c
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 546
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 547 static int secocec_acpi_probe(struct secocec_data *sdev)
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 548 {
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 549 struct device *dev = sdev->dev;
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 550 struct gpio_desc *gpio;
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 551 int irq = 0;
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 552
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 @553 gpio = devm_gpiod_get(dev, NULL, GPIOF_IN);
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 554 if (IS_ERR(gpio)) {
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 555 dev_err(dev, "Cannot request interrupt gpio");
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 556 return PTR_ERR(gpio);
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 557 }
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 558
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 559 irq = gpiod_to_irq(gpio);
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 560 if (irq < 0) {
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 561 dev_err(dev, "Cannot find valid irq");
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 562 return -ENODEV;
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 563 }
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 564 dev_dbg(dev, "irq-gpio is bound to IRQ %d", irq);
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 565
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 566 sdev->irq = irq;
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 567
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 568 return 0;
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 569 }
b03c2fb97adcc6 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 570
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: cec: seco: Drop pointless include
2022-02-22 16:01 [PATCH] media: cec: seco: Drop pointless include Linus Walleij
2022-02-22 19:56 ` kernel test robot
@ 2022-02-22 21:38 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2022-02-22 21:38 UTC (permalink / raw)
To: Linus Walleij, Hans Verkuil, linux-media
Cc: llvm, kbuild-all, Linus Walleij, Ettore Chimenti
Hi Linus,
I love your patch! Yet something to improve:
[auto build test ERROR on media-tree/master]
[also build test ERROR on v5.17-rc5 next-20220217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Linus-Walleij/media-cec-seco-Drop-pointless-include/20220223-000503
base: git://linuxtv.org/media_tree.git master
config: i386-randconfig-a014-20220221 (https://download.01.org/0day-ci/archive/20220223/202202230527.2mRa4oUA-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3b2630b860ba004410fd27ad657355bcc0b9bd72
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Linus-Walleij/media-cec-seco-Drop-pointless-include/20220223-000503
git checkout 3b2630b860ba004410fd27ad657355bcc0b9bd72
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/media/cec/platform/seco/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/media/cec/platform/seco/seco-cec.c:553:35: error: use of undeclared identifier 'GPIOF_IN'; did you mean 'GPIOD_IN'?
gpio = devm_gpiod_get(dev, NULL, GPIOF_IN);
^~~~~~~~
GPIOD_IN
include/linux/gpio/consumer.h:51:2: note: 'GPIOD_IN' declared here
GPIOD_IN = GPIOD_FLAGS_BIT_DIR_SET,
^
1 error generated.
vim +553 drivers/media/cec/platform/seco/seco-cec.c
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 546
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 547 static int secocec_acpi_probe(struct secocec_data *sdev)
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 548 {
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 549 struct device *dev = sdev->dev;
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 550 struct gpio_desc *gpio;
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 551 int irq = 0;
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 552
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 @553 gpio = devm_gpiod_get(dev, NULL, GPIOF_IN);
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 554 if (IS_ERR(gpio)) {
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 555 dev_err(dev, "Cannot request interrupt gpio");
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 556 return PTR_ERR(gpio);
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 557 }
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 558
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 559 irq = gpiod_to_irq(gpio);
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 560 if (irq < 0) {
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 561 dev_err(dev, "Cannot find valid irq");
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 562 return -ENODEV;
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 563 }
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 564 dev_dbg(dev, "irq-gpio is bound to IRQ %d", irq);
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 565
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 566 sdev->irq = irq;
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 567
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 568 return 0;
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 569 }
b03c2fb97adcc65 drivers/media/platform/seco-cec/seco-cec.c Ettore Chimenti 2018-10-21 570
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread