* [PATCH] bus: imx-weim: fix NULL but dereferenced coccicheck error
@ 2022-02-23 3:51 ` Wan Jiabing
0 siblings, 0 replies; 6+ messages in thread
From: Wan Jiabing @ 2022-02-23 3:51 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Ivan Bornyakov, Wan Jiabing, linux-arm-kernel,
linux-kernel
Cc: jiabing.wan
Fix following coccicheck warning:
./drivers/bus/imx-weim.c:355:18-21: ERROR: pdev is NULL but dereferenced.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/bus/imx-weim.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 60fbd42041dd..2ea0a51f79f6 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -352,8 +352,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
pdev = of_find_device_by_node(rd->dn);
if (!pdev) {
- dev_err(&pdev->dev,
- "Could not find platform device for '%pOF'\n",
+ pr_err("Could not find platform device for '%pOF'\n",
rd->dn);
ret = notifier_from_errno(-EINVAL);
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] bus: imx-weim: fix NULL but dereferenced coccicheck error
@ 2022-02-23 3:51 ` Wan Jiabing
0 siblings, 0 replies; 6+ messages in thread
From: Wan Jiabing @ 2022-02-23 3:51 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Ivan Bornyakov, Wan Jiabing, linux-arm-kernel,
linux-kernel
Cc: jiabing.wan
Fix following coccicheck warning:
./drivers/bus/imx-weim.c:355:18-21: ERROR: pdev is NULL but dereferenced.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/bus/imx-weim.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 60fbd42041dd..2ea0a51f79f6 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -352,8 +352,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
pdev = of_find_device_by_node(rd->dn);
if (!pdev) {
- dev_err(&pdev->dev,
- "Could not find platform device for '%pOF'\n",
+ pr_err("Could not find platform device for '%pOF'\n",
rd->dn);
ret = notifier_from_errno(-EINVAL);
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] bus: imx-weim: fix NULL but dereferenced coccicheck error
2022-02-23 3:51 ` Wan Jiabing
@ 2022-02-23 6:58 ` Ivan Bornyakov
-1 siblings, 0 replies; 6+ messages in thread
From: Ivan Bornyakov @ 2022-02-23 6:58 UTC (permalink / raw)
To: Wan Jiabing
Cc: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-arm-kernel, linux-kernel, jiabing.wan
On Wed, Feb 23, 2022 at 11:51:45AM +0800, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/bus/imx-weim.c:355:18-21: ERROR: pdev is NULL but dereferenced.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/bus/imx-weim.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 60fbd42041dd..2ea0a51f79f6 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -352,8 +352,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
>
> pdev = of_find_device_by_node(rd->dn);
> if (!pdev) {
> - dev_err(&pdev->dev,
> - "Could not find platform device for '%pOF'\n",
> + pr_err("Could not find platform device for '%pOF'\n",
> rd->dn);
>
> ret = notifier_from_errno(-EINVAL);
> --
> 2.35.1
>
Acked-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] bus: imx-weim: fix NULL but dereferenced coccicheck error
@ 2022-02-23 6:58 ` Ivan Bornyakov
0 siblings, 0 replies; 6+ messages in thread
From: Ivan Bornyakov @ 2022-02-23 6:58 UTC (permalink / raw)
To: Wan Jiabing
Cc: Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, linux-arm-kernel, linux-kernel, jiabing.wan
On Wed, Feb 23, 2022 at 11:51:45AM +0800, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/bus/imx-weim.c:355:18-21: ERROR: pdev is NULL but dereferenced.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/bus/imx-weim.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 60fbd42041dd..2ea0a51f79f6 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -352,8 +352,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
>
> pdev = of_find_device_by_node(rd->dn);
> if (!pdev) {
> - dev_err(&pdev->dev,
> - "Could not find platform device for '%pOF'\n",
> + pr_err("Could not find platform device for '%pOF'\n",
> rd->dn);
>
> ret = notifier_from_errno(-EINVAL);
> --
> 2.35.1
>
Acked-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] bus: imx-weim: fix NULL but dereferenced coccicheck error
2022-02-23 6:58 ` Ivan Bornyakov
@ 2022-04-06 12:48 ` Shawn Guo
-1 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2022-04-06 12:48 UTC (permalink / raw)
To: Ivan Bornyakov
Cc: Wan Jiabing, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, linux-arm-kernel, linux-kernel,
jiabing.wan
On Wed, Feb 23, 2022 at 09:58:15AM +0300, Ivan Bornyakov wrote:
> On Wed, Feb 23, 2022 at 11:51:45AM +0800, Wan Jiabing wrote:
> > Fix following coccicheck warning:
> > ./drivers/bus/imx-weim.c:355:18-21: ERROR: pdev is NULL but dereferenced.
> >
> > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bus: imx-weim: fix NULL but dereferenced coccicheck error
@ 2022-04-06 12:48 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2022-04-06 12:48 UTC (permalink / raw)
To: Ivan Bornyakov
Cc: Wan Jiabing, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, linux-arm-kernel, linux-kernel,
jiabing.wan
On Wed, Feb 23, 2022 at 09:58:15AM +0300, Ivan Bornyakov wrote:
> On Wed, Feb 23, 2022 at 11:51:45AM +0800, Wan Jiabing wrote:
> > Fix following coccicheck warning:
> > ./drivers/bus/imx-weim.c:355:18-21: ERROR: pdev is NULL but dereferenced.
> >
> > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-06 15:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23 3:51 [PATCH] bus: imx-weim: fix NULL but dereferenced coccicheck error Wan Jiabing
2022-02-23 3:51 ` Wan Jiabing
2022-02-23 6:58 ` Ivan Bornyakov
2022-02-23 6:58 ` Ivan Bornyakov
2022-04-06 12:48 ` Shawn Guo
2022-04-06 12:48 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.