* [Intel-gfx] [PATCH] drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK
@ 2022-02-23 10:10 Jani Nikula
2022-02-23 10:17 ` Ville Syrjälä
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Jani Nikula @ 2022-02-23 10:10 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Use REG_FIELD_PREP for completeness, and to avoid bitwise operations
with different sizes.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 5af16ca4dabd..3411ebaa767f 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5930,7 +5930,7 @@ static void skl_write_wm_level(struct drm_i915_private *dev_priv,
val |= PLANE_WM_EN;
if (level->ignore_lines)
val |= PLANE_WM_IGNORE_LINES;
- val |= level->blocks;
+ val |= REG_FIELD_PREP(PLANE_WM_BLOCKS_MASK, level->blocks);
val |= REG_FIELD_PREP(PLANE_WM_LINES_MASK, level->lines);
intel_de_write_fw(dev_priv, reg, val);
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK
2022-02-23 10:10 [Intel-gfx] [PATCH] drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK Jani Nikula
@ 2022-02-23 10:17 ` Ville Syrjälä
2022-02-23 10:36 ` Jani Nikula
2022-02-23 10:35 ` [Intel-gfx] [PATCH v2] drm/i915/wm: use REG_FIELD_{PREP, GET} " Jani Nikula
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Ville Syrjälä @ 2022-02-23 10:17 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Feb 23, 2022 at 12:10:23PM +0200, Jani Nikula wrote:
> Use REG_FIELD_PREP for completeness, and to avoid bitwise operations
> with different sizes.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 5af16ca4dabd..3411ebaa767f 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5930,7 +5930,7 @@ static void skl_write_wm_level(struct drm_i915_private *dev_priv,
> val |= PLANE_WM_EN;
> if (level->ignore_lines)
> val |= PLANE_WM_IGNORE_LINES;
> - val |= level->blocks;
> + val |= REG_FIELD_PREP(PLANE_WM_BLOCKS_MASK, level->blocks);
> val |= REG_FIELD_PREP(PLANE_WM_LINES_MASK, level->lines);
>
> intel_de_write_fw(dev_priv, reg, val);a
skl_wm_level_from_reg_val() could use similar treatment for symmetry.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> --
> 2.30.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/wm: use REG_FIELD_{PREP, GET} for PLANE_WM_BLOCKS_MASK
2022-02-23 10:10 [Intel-gfx] [PATCH] drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK Jani Nikula
2022-02-23 10:17 ` Ville Syrjälä
@ 2022-02-23 10:35 ` Jani Nikula
2022-02-23 10:40 ` Ville Syrjälä
2022-02-23 19:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK (rev2) Patchwork
2022-02-24 4:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 1 reply; 8+ messages in thread
From: Jani Nikula @ 2022-02-23 10:35 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
Use REG_FIELD_{PREP,GET} for completeness, and to avoid bitwise
operations with different sizes.
v2: Also use REG_FIELD_GET in skl_wm_level_from_reg_val() (Ville)
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 5af16ca4dabd..f7fabcabf805 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5930,7 +5930,7 @@ static void skl_write_wm_level(struct drm_i915_private *dev_priv,
val |= PLANE_WM_EN;
if (level->ignore_lines)
val |= PLANE_WM_IGNORE_LINES;
- val |= level->blocks;
+ val |= REG_FIELD_PREP(PLANE_WM_BLOCKS_MASK, level->blocks);
val |= REG_FIELD_PREP(PLANE_WM_LINES_MASK, level->lines);
intel_de_write_fw(dev_priv, reg, val);
@@ -6578,7 +6578,7 @@ static void skl_wm_level_from_reg_val(u32 val, struct skl_wm_level *level)
{
level->enable = val & PLANE_WM_EN;
level->ignore_lines = val & PLANE_WM_IGNORE_LINES;
- level->blocks = val & PLANE_WM_BLOCKS_MASK;
+ level->blocks = REG_FIELD_GET(PLANE_WM_BLOCKS_MASK, val);
level->lines = REG_FIELD_GET(PLANE_WM_LINES_MASK, val);
}
--
2.30.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK
2022-02-23 10:17 ` Ville Syrjälä
@ 2022-02-23 10:36 ` Jani Nikula
0 siblings, 0 replies; 8+ messages in thread
From: Jani Nikula @ 2022-02-23 10:36 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Wed, 23 Feb 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Feb 23, 2022 at 12:10:23PM +0200, Jani Nikula wrote:
>> Use REG_FIELD_PREP for completeness, and to avoid bitwise operations
>> with different sizes.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_pm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> index 5af16ca4dabd..3411ebaa767f 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -5930,7 +5930,7 @@ static void skl_write_wm_level(struct drm_i915_private *dev_priv,
>> val |= PLANE_WM_EN;
>> if (level->ignore_lines)
>> val |= PLANE_WM_IGNORE_LINES;
>> - val |= level->blocks;
>> + val |= REG_FIELD_PREP(PLANE_WM_BLOCKS_MASK, level->blocks);
>> val |= REG_FIELD_PREP(PLANE_WM_LINES_MASK, level->lines);
>>
>> intel_de_write_fw(dev_priv, reg, val);a
>
> skl_wm_level_from_reg_val() could use similar treatment for symmetry.
Aye. v2 sent.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>> --
>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/wm: use REG_FIELD_{PREP, GET} for PLANE_WM_BLOCKS_MASK
2022-02-23 10:35 ` [Intel-gfx] [PATCH v2] drm/i915/wm: use REG_FIELD_{PREP, GET} " Jani Nikula
@ 2022-02-23 10:40 ` Ville Syrjälä
2022-03-01 12:37 ` Jani Nikula
0 siblings, 1 reply; 8+ messages in thread
From: Ville Syrjälä @ 2022-02-23 10:40 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Wed, Feb 23, 2022 at 12:35:17PM +0200, Jani Nikula wrote:
> Use REG_FIELD_{PREP,GET} for completeness, and to avoid bitwise
> operations with different sizes.
>
> v2: Also use REG_FIELD_GET in skl_wm_level_from_reg_val() (Ville)
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 5af16ca4dabd..f7fabcabf805 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5930,7 +5930,7 @@ static void skl_write_wm_level(struct drm_i915_private *dev_priv,
> val |= PLANE_WM_EN;
> if (level->ignore_lines)
> val |= PLANE_WM_IGNORE_LINES;
> - val |= level->blocks;
> + val |= REG_FIELD_PREP(PLANE_WM_BLOCKS_MASK, level->blocks);
> val |= REG_FIELD_PREP(PLANE_WM_LINES_MASK, level->lines);
>
> intel_de_write_fw(dev_priv, reg, val);
> @@ -6578,7 +6578,7 @@ static void skl_wm_level_from_reg_val(u32 val, struct skl_wm_level *level)
> {
> level->enable = val & PLANE_WM_EN;
> level->ignore_lines = val & PLANE_WM_IGNORE_LINES;
> - level->blocks = val & PLANE_WM_BLOCKS_MASK;
> + level->blocks = REG_FIELD_GET(PLANE_WM_BLOCKS_MASK, val);
> level->lines = REG_FIELD_GET(PLANE_WM_LINES_MASK, val);
> }
>
> --
> 2.30.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK (rev2)
2022-02-23 10:10 [Intel-gfx] [PATCH] drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK Jani Nikula
2022-02-23 10:17 ` Ville Syrjälä
2022-02-23 10:35 ` [Intel-gfx] [PATCH v2] drm/i915/wm: use REG_FIELD_{PREP, GET} " Jani Nikula
@ 2022-02-23 19:05 ` Patchwork
2022-02-24 4:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-02-23 19:05 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 10525 bytes --]
== Series Details ==
Series: drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK (rev2)
URL : https://patchwork.freedesktop.org/series/100626/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11274 -> Patchwork_22369
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_22369 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_22369, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/index.html
Participating hosts (49 -> 45)
------------------------------
Missing (4): fi-ctg-p8600 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22369:
### IGT changes ###
#### Warnings ####
* igt@i915_selftest@live@gt_lrc:
- fi-bsw-n3050: [DMESG-FAIL][1] ([i915#2373]) -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
Known issues
------------
Here are the changes found in Patchwork_22369 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@fork-compute0:
- fi-blb-e6850: NOTRUN -> [SKIP][3] ([fdo#109271]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-blb-e6850/igt@amdgpu/amd_cs_nop@fork-compute0.html
* igt@gem_huc_copy@huc-copy:
- fi-skl-6600u: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-skl-6600u/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@verify-random:
- fi-skl-6600u: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-skl-6600u/igt@gem_lmem_swapping@verify-random.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [PASS][6] -> [DMESG-FAIL][7] ([i915#4494] / [i915#4957])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
- fi-bdw-5557u: NOTRUN -> [INCOMPLETE][8] ([i915#3921])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-bdw-5557u/igt@i915_selftest@live@hangcheck.html
* igt@kms_busy@basic@modeset:
- bat-adlp-4: [PASS][9] -> [DMESG-WARN][10] ([i915#3576])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/bat-adlp-4/igt@kms_busy@basic@modeset.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/bat-adlp-4/igt@kms_busy@basic@modeset.html
* igt@kms_chamelium@vga-edid-read:
- fi-skl-6600u: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-skl-6600u/igt@kms_chamelium@vga-edid-read.html
- fi-bdw-5557u: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-bdw-5557u/igt@kms_chamelium@vga-edid-read.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-skl-6600u: NOTRUN -> [SKIP][13] ([fdo#109271]) +21 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-skl-6600u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [PASS][14] -> [DMESG-WARN][15] ([i915#4269])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-6600u: NOTRUN -> [SKIP][16] ([fdo#109271] / [i915#533])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-skl-6600u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_psr@cursor_plane_move:
- fi-bdw-5557u: NOTRUN -> [SKIP][17] ([fdo#109271]) +13 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-bdw-5557u/igt@kms_psr@cursor_plane_move.html
* igt@runner@aborted:
- fi-bsw-n3050: NOTRUN -> [FAIL][18] ([fdo#109271] / [i915#1436] / [i915#3428] / [i915#4312])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-bsw-n3050/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-skl-6600u: [INCOMPLETE][19] ([i915#4547]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/fi-skl-6600u/igt@gem_exec_suspend@basic-s3@smem.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-skl-6600u/igt@gem_exec_suspend@basic-s3@smem.html
- {fi-rkl-11600}: [INCOMPLETE][21] ([i915#5127]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-rkl-11600/igt@gem_exec_suspend@basic-s3@smem.html
* igt@i915_selftest@live@gem_contexts:
- fi-kbl-soraka: [DMESG-WARN][23] ([i915#4391]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/fi-kbl-soraka/igt@i915_selftest@live@gem_contexts.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-kbl-soraka/igt@i915_selftest@live@gem_contexts.html
* igt@i915_selftest@live@hangcheck:
- {fi-tgl-dsi}: [DMESG-FAIL][25] ([i915#2927]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/fi-tgl-dsi/igt@i915_selftest@live@hangcheck.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-tgl-dsi/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [DMESG-FAIL][27] -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/fi-blb-e6850/igt@i915_selftest@live@requests.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-blb-e6850/igt@i915_selftest@live@requests.html
* igt@kms_busy@basic@modeset:
- {bat-adlp-6}: [DMESG-WARN][29] ([i915#3576]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/bat-adlp-6/igt@kms_busy@basic@modeset.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/bat-adlp-6/igt@kms_busy@basic@modeset.html
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- bat-adlp-4: [DMESG-WARN][31] ([i915#3576]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/bat-adlp-4/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/bat-adlp-4/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
#### Warnings ####
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][33] ([i915#3303]) -> [INCOMPLETE][34] ([i915#4785])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_11274 -> Patchwork_22369
CI-20190529: 20190529
CI_DRM_11274: 57f06c1ce02294a7c56befb10dda74f2f5e35878 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6354: 7146765b80919e3f134398ba433b36a56377e4c9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22369: eecbb188c1499c7449f338ccf27a1b19954a3e79 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
eecbb188c149 drm/i915/wm: use REG_FIELD_{PREP, GET} for PLANE_WM_BLOCKS_MASK
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/index.html
[-- Attachment #2: Type: text/html, Size: 11644 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK (rev2)
2022-02-23 10:10 [Intel-gfx] [PATCH] drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK Jani Nikula
` (2 preceding siblings ...)
2022-02-23 19:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK (rev2) Patchwork
@ 2022-02-24 4:55 ` Patchwork
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-02-24 4:55 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30287 bytes --]
== Series Details ==
Series: drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK (rev2)
URL : https://patchwork.freedesktop.org/series/100626/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11274_full -> Patchwork_22369_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22369_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_cursor_crc@pipe-b-cursor-128x128-offscreen:
- {shard-dg1}: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-dg1-13/igt@kms_cursor_crc@pipe-b-cursor-128x128-offscreen.html
Known issues
------------
Here are the changes found in Patchwork_22369_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [PASS][2] -> [SKIP][3] ([i915#4525])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-iclb2/igt@gem_exec_balancer@parallel-balancer.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb6/igt@gem_exec_balancer@parallel-balancer.html
* igt@gem_exec_balancer@parallel-out-fence:
- shard-kbl: NOTRUN -> [DMESG-WARN][4] ([i915#5076])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl7/igt@gem_exec_balancer@parallel-out-fence.html
* igt@gem_exec_fair@basic-deadline:
- shard-skl: NOTRUN -> [FAIL][5] ([i915#2846])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][6] ([fdo#109271]) +248 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl2/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-glk4/igt@gem_exec_fair@basic-pace@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-glk7/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_lmem_swapping@heavy-random:
- shard-skl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4613]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl4/igt@gem_lmem_swapping@heavy-random.html
* igt@gem_lmem_swapping@parallel-multi:
- shard-apl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-apl3/igt@gem_lmem_swapping@parallel-multi.html
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-kbl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4613])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl3/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-skl: NOTRUN -> [FAIL][16] ([i915#644])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl4/igt@gem_ppgtt@flink-and-close-vma-leak.html
* igt@gem_pread@exhaustion:
- shard-skl: NOTRUN -> [WARN][17] ([i915#2658])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl6/igt@gem_pread@exhaustion.html
* igt@gem_render_copy@y-tiled-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][18] ([i915#768])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb3/igt@gem_render_copy@y-tiled-to-vebox-yf-tiled.html
* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][19] ([i915#4991])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl4/igt@gem_userptr_blits@input-checking.html
* igt@i915_pm_dc@dc6-psr:
- shard-skl: NOTRUN -> [FAIL][20] ([i915#454])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl4/igt@i915_pm_dc@dc6-psr.html
* igt@i915_query@query-topology-known-pci-ids:
- shard-iclb: NOTRUN -> [SKIP][21] ([fdo#109303])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb6/igt@i915_query@query-topology-known-pci-ids.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][22] -> [INCOMPLETE][23] ([i915#3921])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-snb4/igt@i915_selftest@live@hangcheck.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-snb4/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@mock@hugepages:
- shard-skl: NOTRUN -> [INCOMPLETE][24] ([i915#5123])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl1/igt@i915_selftest@mock@hugepages.html
* igt@kms_atomic@atomic_plane_damage:
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#4765])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb3/igt@kms_atomic@atomic_plane_damage.html
* igt@kms_big_fb@linear-32bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][26] ([fdo#110725] / [fdo#111614])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb3/igt@kms_big_fb@linear-32bpp-rotate-270.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-skl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3777]) +7 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][28] ([i915#3763]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#3777]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][30] ([i915#3743])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl9/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#110723]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb3/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3886])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-apl7/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3886]) +10 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl2/igt@kms_ccs@pipe-b-crc-primary-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl1/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][35] ([fdo#109278] / [i915#3886]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb7/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@hdmi-hpd-storm:
- shard-kbl: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +4 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl3/igt@kms_chamelium@hdmi-hpd-storm.html
* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][37] ([fdo#109271] / [fdo#111827]) +16 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl9/igt@kms_chamelium@hdmi-hpd-storm-disable.html
* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-apl7/igt@kms_chamelium@vga-hpd-after-suspend.html
* igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#109284] / [fdo#111827]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-tglb3/igt@kms_color_chamelium@pipe-c-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-c-degamma:
- shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109284] / [fdo#111827])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb3/igt@kms_color_chamelium@pipe-c-degamma.html
* igt@kms_content_protection@atomic:
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109300] / [fdo#111066])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb3/igt@kms_content_protection@atomic.html
* igt@kms_cursor_crc@pipe-a-cursor-32x10-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#3359]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-tglb3/igt@kms_cursor_crc@pipe-a-cursor-32x10-rapid-movement.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic:
- shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109274] / [fdo#109278])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb6/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][44] -> [INCOMPLETE][45] ([i915#180] / [i915#1982])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-apl3/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-rmfb:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109274]) +1 similar issue
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb3/igt@kms_flip@2x-flip-vs-rmfb.html
* igt@kms_flip@flip-vs-fences-interruptible@b-vga1:
- shard-snb: [PASS][47] -> [DMESG-FAIL][48] ([i915#5000])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-snb7/igt@kms_flip@flip-vs-fences-interruptible@b-vga1.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-snb2/igt@kms_flip@flip-vs-fences-interruptible@b-vga1.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [PASS][49] -> [DMESG-WARN][50] ([i915#180])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-glk: [PASS][51] -> [FAIL][52] ([i915#4911]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-glk1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling:
- shard-iclb: [PASS][53] -> [SKIP][54] ([i915#3701])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-iclb5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling:
- shard-iclb: NOTRUN -> [SKIP][55] ([i915#2587])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109280]) +7 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-render:
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#109280] / [fdo#111825])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-render.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#533])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl3/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#533])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-apl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes:
- shard-snb: [PASS][60] -> [SKIP][61] ([fdo#109271])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-snb5/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-snb6/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-kbl: [PASS][62] -> [DMESG-WARN][63] ([i915#180]) +5 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][64] ([fdo#108145] / [i915#265]) +3 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][65] ([fdo#108145] / [i915#265])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-apl3/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-kbl: NOTRUN -> [FAIL][66] ([fdo#108145] / [i915#265]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl3/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_cursor@pipe-d-primary-size-64:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109278]) +6 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb6/igt@kms_plane_cursor@pipe-d-primary-size-64.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-kbl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#658])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
- shard-skl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#658]) +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl9/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][70] -> [SKIP][71] ([fdo#109441]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
* igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-c:
- shard-iclb: NOTRUN -> [SKIP][72] ([i915#5030]) +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb7/igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-c.html
* igt@kms_setmode@basic:
- shard-glk: [PASS][73] -> [FAIL][74] ([i915#31])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-glk5/igt@kms_setmode@basic.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-glk4/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-d-query-forked-busy:
- shard-kbl: NOTRUN -> [SKIP][75] ([fdo#109271]) +76 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl3/igt@kms_vblank@pipe-d-query-forked-busy.html
* igt@kms_vblank@pipe-d-ts-continuation-idle:
- shard-apl: NOTRUN -> [SKIP][76] ([fdo#109271]) +52 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-apl7/igt@kms_vblank@pipe-d-ts-continuation-idle.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-skl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#2437]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl9/igt@kms_writeback@writeback-invalid-parameters.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-kbl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#2437])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl3/igt@kms_writeback@writeback-pixel-formats.html
* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#2530])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb6/igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame.html
* igt@perf@gen12-oa-tlb-invalidate:
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109289]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb3/igt@perf@gen12-oa-tlb-invalidate.html
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109291])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb6/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html
* igt@syncobj_timeline@invalid-transfer-non-existent-point:
- shard-kbl: NOTRUN -> [DMESG-WARN][82] ([i915#5098])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl3/igt@syncobj_timeline@invalid-transfer-non-existent-point.html
* igt@sysfs_clients@busy:
- shard-skl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#2994]) +3 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl4/igt@sysfs_clients@busy.html
* igt@sysfs_clients@split-25:
- shard-kbl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2994])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl3/igt@sysfs_clients@split-25.html
#### Possible fixes ####
* igt@gem_eio@in-flight-10ms:
- shard-tglb: [TIMEOUT][85] ([i915#3063]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-tglb2/igt@gem_eio@in-flight-10ms.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-tglb5/igt@gem_eio@in-flight-10ms.html
* igt@gem_exec_capture@pi@vcs0:
- shard-iclb: [INCOMPLETE][87] ([i915#3371]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-iclb5/igt@gem_exec_capture@pi@vcs0.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb3/igt@gem_exec_capture@pi@vcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: [FAIL][89] ([i915#2842]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl3/igt@gem_exec_fair@basic-none@vecs0.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl7/igt@gem_exec_fair@basic-none@vecs0.html
- shard-apl: [FAIL][91] ([i915#2842]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-apl7/igt@gem_exec_fair@basic-none@vecs0.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-apl7/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][93] ([i915#2842]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [SKIP][95] ([i915#2190]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-tglb7/igt@gem_huc_copy@huc-copy.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-tglb1/igt@gem_huc_copy@huc-copy.html
* igt@i915_selftest@live@hangcheck:
- {shard-dg1}: [DMESG-FAIL][97] ([i915#4494] / [i915#4957]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-dg1-19/igt@i915_selftest@live@hangcheck.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-dg1-19/igt@i915_selftest@live@hangcheck.html
* igt@kms_big_fb@linear-32bpp-rotate-0:
- {shard-tglu}: [DMESG-WARN][99] ([i915#1982] / [i915#402]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-tglu-1/igt@kms_big_fb@linear-32bpp-rotate-0.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-tglu-6/igt@kms_big_fb@linear-32bpp-rotate-0.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][101] ([i915#2346] / [i915#533]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [INCOMPLETE][103] ([i915#180] / [i915#636]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl7/igt@kms_fbcon_fbt@fbc-suspend.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl3/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][105] ([i915#79]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [DMESG-WARN][107] ([i915#180]) -> [PASS][108] +2 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-apl2/igt@kms_flip@flip-vs-suspend@a-dp1.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-apl7/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip@plain-flip-ts-check@b-edp1:
- shard-skl: [FAIL][109] ([i915#2122]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-skl4/igt@kms_flip@plain-flip-ts-check@b-edp1.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-skl8/igt@kms_flip@plain-flip-ts-check@b-edp1.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][111] ([i915#180]) -> [PASS][112] +4 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl6/igt@kms_hdr@bpc-switch-suspend.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-kbl3/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-snb: [SKIP][113] ([fdo#109271]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-snb5/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-snb6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [SKIP][115] ([i915#4525]) -> [DMESG-WARN][116] ([i915#5076]) +2 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-iclb8/igt@gem_exec_balancer@parallel-contexts.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb4/igt@gem_exec_balancer@parallel-contexts.html
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [DMESG-FAIL][117] ([i915#5076]) -> [SKIP][118] ([i915#4525])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-iclb2/igt@gem_exec_balancer@parallel-ordering.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb6/igt@gem_exec_balancer@parallel-ordering.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-iclb: [FAIL][119] ([i915#2849]) -> [FAIL][120] ([i915#2842])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-iclb8/igt@gem_exec_fair@basic-none-solo@rcs0.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb1/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][121] ([i915#2684]) -> [WARN][122] ([i915#1804] / [i915#2684])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-iclb1/igt@i915_pm_rc6_residency@rc6-fence.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@kms_frontbuffer_tracking@fbcpsr-farfromfence-mmap-gtt:
- shard-glk: [SKIP][123] ([fdo#109271]) -> [SKIP][124] ([fdo#109271] / [i915#1888])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-glk7/igt@kms_frontbuffer_tracking@fbcpsr-farfromfence-mmap-gtt.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-glk2/igt@kms_frontbuffer_tracking@fbcpsr-farfromfence-mmap-gtt.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [FAIL][125] ([i915#4148]) -> [SKIP][126] ([fdo#109642] / [fdo#111068] / [i915#658])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/shard-iclb6/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145]) ([fdo#109271] / [i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#4312] / [i915#602] / [i915#92]) -> ([FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156], [FAIL][157], [FAIL][158], [FAIL][159], [FAIL][160], [FAIL][161], [FAIL][162], [FAIL][163], [FAIL][164]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#4312] / [i915#602])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl4/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl4/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl3/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl1/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl7/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl1/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl6/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl4/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl3/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl6/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl4/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11274/shard-kbl7/igt@runn
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22369/index.html
[-- Attachment #2: Type: text/html, Size: 33975 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/wm: use REG_FIELD_{PREP, GET} for PLANE_WM_BLOCKS_MASK
2022-02-23 10:40 ` Ville Syrjälä
@ 2022-03-01 12:37 ` Jani Nikula
0 siblings, 0 replies; 8+ messages in thread
From: Jani Nikula @ 2022-03-01 12:37 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Wed, 23 Feb 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Feb 23, 2022 at 12:35:17PM +0200, Jani Nikula wrote:
>> Use REG_FIELD_{PREP,GET} for completeness, and to avoid bitwise
>> operations with different sizes.
>>
>> v2: Also use REG_FIELD_GET in skl_wm_level_from_reg_val() (Ville)
>>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Pushed (yesterday), thanks for the review.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/intel_pm.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> index 5af16ca4dabd..f7fabcabf805 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -5930,7 +5930,7 @@ static void skl_write_wm_level(struct drm_i915_private *dev_priv,
>> val |= PLANE_WM_EN;
>> if (level->ignore_lines)
>> val |= PLANE_WM_IGNORE_LINES;
>> - val |= level->blocks;
>> + val |= REG_FIELD_PREP(PLANE_WM_BLOCKS_MASK, level->blocks);
>> val |= REG_FIELD_PREP(PLANE_WM_LINES_MASK, level->lines);
>>
>> intel_de_write_fw(dev_priv, reg, val);
>> @@ -6578,7 +6578,7 @@ static void skl_wm_level_from_reg_val(u32 val, struct skl_wm_level *level)
>> {
>> level->enable = val & PLANE_WM_EN;
>> level->ignore_lines = val & PLANE_WM_IGNORE_LINES;
>> - level->blocks = val & PLANE_WM_BLOCKS_MASK;
>> + level->blocks = REG_FIELD_GET(PLANE_WM_BLOCKS_MASK, val);
>> level->lines = REG_FIELD_GET(PLANE_WM_LINES_MASK, val);
>> }
>>
>> --
>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-03-01 12:37 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23 10:10 [Intel-gfx] [PATCH] drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK Jani Nikula
2022-02-23 10:17 ` Ville Syrjälä
2022-02-23 10:36 ` Jani Nikula
2022-02-23 10:35 ` [Intel-gfx] [PATCH v2] drm/i915/wm: use REG_FIELD_{PREP, GET} " Jani Nikula
2022-02-23 10:40 ` Ville Syrjälä
2022-03-01 12:37 ` Jani Nikula
2022-02-23 19:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/wm: use REG_FIELD_PREP for PLANE_WM_BLOCKS_MASK (rev2) Patchwork
2022-02-24 4:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.