* [PATCH net] net: sparx5: Add #include to remove warning
@ 2022-02-25 12:43 Casper Andersson
2022-02-28 11:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Casper Andersson @ 2022-02-25 12:43 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Lars Povlsen, Steen Hegelund,
UNGLinuxDriver
Cc: netdev
main.h uses NUM_TARGETS from main_regs.h, but
the missing include never causes any errors
because everywhere main.h is (currently)
included, main_regs.h is included before.
But since it is dependent on main_regs.h
it should always be included.
Signed-off-by: Casper Andersson <casper.casan@gmail.com>
Reviewed-by: Joacim Zetterling <joacim.zetterling@westermo.com>
---
Should I perhaps remove all additional
#include "sparx5_main_regs.h"
since it now comes with main.h?
I didn't include a Fixes tag since this
does not affect any functionality.
drivers/net/ethernet/microchip/sparx5/sparx5_main.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
index a1acc9b461f2..d40e18ce3293 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
@@ -16,6 +16,8 @@
#include <linux/phylink.h>
#include <linux/hrtimer.h>
+#include "sparx5_main_regs.h"
+
/* Target chip type */
enum spx5_target_chiptype {
SPX5_TARGET_CT_7546 = 0x7546, /* SparX-5-64 Enterprise */
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: sparx5: Add #include to remove warning
2022-02-25 12:43 [PATCH net] net: sparx5: Add #include to remove warning Casper Andersson
@ 2022-02-28 11:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-28 11:50 UTC (permalink / raw)
To: Casper Andersson
Cc: davem, kuba, lars.povlsen, Steen.Hegelund, UNGLinuxDriver, netdev
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 25 Feb 2022 13:43:27 +0100 you wrote:
> main.h uses NUM_TARGETS from main_regs.h, but
> the missing include never causes any errors
> because everywhere main.h is (currently)
> included, main_regs.h is included before.
> But since it is dependent on main_regs.h
> it should always be included.
>
> [...]
Here is the summary with links:
- [net] net: sparx5: Add #include to remove warning
https://git.kernel.org/netdev/net/c/90d402528574
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-28 11:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-25 12:43 [PATCH net] net: sparx5: Add #include to remove warning Casper Andersson
2022-02-28 11:50 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.