Re: [igt-dev] [v7 6/8] tests/kms_plane_scaling: Add negative test to check num of scalers

* Re: [igt-dev] [v7 6/8] tests/kms_plane_scaling: Add negative test to check num of scalers
  2022-02-25 14:44 ` [igt-dev] [v7 6/8] tests/kms_plane_scaling: Add negative test to check num of scalers Swati Sharma
@ 2022-02-25 14:41   ` Petri Latvala
  2022-02-25 15:50     ` Petri Latvala
  0 siblings, 1 reply; 14+ messages in thread
From: Petri Latvala @ 2022-02-25 14:41 UTC (permalink / raw)
  To: Swati Sharma; +Cc: igt-dev

On Fri, Feb 25, 2022 at 08:14:34PM +0530, Swati Sharma wrote:
> To validate i915 supports max of 2 scalers, applied upscaling on
> 3 planes simultaneously. This is a negative test and commit is expected
> to fail.
> 
> v2: -add check for min 2 scalers
>     -add igt_require() for overlay planes, fixes CRASH on KBL
> v3: -rebase
> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>  tests/kms_plane_scaling.c | 73 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 73 insertions(+)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 6fc10d59..5df9ba24 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -652,6 +652,71 @@ test_planes_scaling_combo(data_t *d, int w1, int h1, int w2, int h2,
>  	igt_remove_fb(display->drm_fd, &d->fb[2]);
>  }
>  
> +static void
> +test_invalid_num_scalers(data_t *d, enum pipe pipe, igt_output_t *output)
> +{
> +	igt_display_t *display = &d->display;
> +	igt_pipe_t *pipe_obj = &display->pipes[pipe];
> +	int width, height, width1, height1;
> +	drmModeModeInfo *mode;
> +
> +	cleanup_crtc(d);
> +
> +	igt_output_set_pipe(output, pipe);
> +
> +	width = height = 20;
> +	mode = igt_output_get_mode(output);
> +	width1 = mode->hdisplay;
> +	height1 = mode->vdisplay;
> +
> +	d->plane1 = igt_pipe_get_plane_type_index(pipe_obj, DRM_PLANE_TYPE_OVERLAY, 0);
> +	igt_require(d->plane1);
> +	d->plane2 = igt_pipe_get_plane_type_index(pipe_obj, DRM_PLANE_TYPE_OVERLAY, 1);
> +	igt_require(d->plane2);
> +	d->plane3 = igt_pipe_get_plane_type_index(pipe_obj, DRM_PLANE_TYPE_OVERLAY, 2);
> +	igt_require(d->plane3);
> +
> +	igt_create_color_pattern_fb(display->drm_fd,
> +                                    width, height,
> +                                    DRM_FORMAT_XRGB8888,
> +                                    I915_TILING_NONE,
> +                                    1.0, 0.0, 0.0, &d->fb[1]);
> +	igt_create_color_pattern_fb(display->drm_fd,
> +                                    width, height,
> +                                    DRM_FORMAT_XRGB8888,
> +                                    I915_TILING_NONE,
> +                                    0.0, 1.0, 0.0, &d->fb[2]);
> +	igt_create_color_pattern_fb(display->drm_fd,
> +                                    width, height,
> +                                    DRM_FORMAT_XRGB8888,
> +                                    I915_TILING_NONE,
> +                                    0.0, 0.0, 1.0, &d->fb[3]);
> +
> +	igt_plane_set_fb(d->plane1, &d->fb[1]);
> +	igt_plane_set_fb(d->plane2, &d->fb[2]);
> +	igt_plane_set_fb(d->plane3, &d->fb[3]);
> +
> +	/* first plane upscaling */
> +	igt_plane_set_size(d->plane1, width1, height1);
> +	/* second plane upscaling */
> +	igt_plane_set_size(d->plane2, width1, height1);
> +	/* third plane upscaling */
> +	igt_plane_set_size(d->plane3, width1, height1);
> +
> +	/* This commit is expectd to fail as we can have max 2 scalers/pipe
> +	 * In dmesg, you can find: Too many scaling requests 3 > 2
> +	 * */

That assumption only holds for i915 devices, and that can possibly
change in the future.

As the goal is to test that too many scalings is rejected with EINVAL,
this assumption needs to be written down:

igt_require(get_num_scalers(d, pipe) < 3);

done preferably before creating the fbs to save some time.

-- 
Petri Latvala

> +	igt_assert_eq(igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL), -EINVAL);
> +
> +	/* cleanup */
> +	igt_plane_set_fb(d->plane1, NULL);
> +	igt_plane_set_fb(d->plane2, NULL);
> +	igt_plane_set_fb(d->plane3, NULL);
> +	igt_remove_fb(display->drm_fd, &d->fb[1]);
> +	igt_remove_fb(display->drm_fd, &d->fb[2]);
> +	igt_remove_fb(display->drm_fd, &d->fb[3]);
> +}
> +
>  static void test_scaler_with_multi_pipe_plane(data_t *d)
>  {
>  	igt_display_t *display = &d->display;
> @@ -990,6 +1055,14 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>  				}
>  			}
>  		}
> +
> +		igt_describe("Negative test for number of scalers per pipe.");
> +		igt_subtest_with_dynamic("invalid-num-scalers") {
> +			for_each_pipe_with_valid_output(&data.display, pipe, output)
> +				igt_dynamic_f("pipe-%s-%s-invalid-num-scalers",
> +					       kmstest_pipe_name(pipe), igt_output_name(output))
> +					test_invalid_num_scalers(&data, pipe, output);
> +		}
>  	}
>  
>  	igt_describe("Tests scaling with multi-pipe scenario.");
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread