From: Bjorn Helgaas <helgaas@kernel.org> To: "Marek Behún" <kabel@kernel.org> Cc: "Pali Rohár" <pali@kernel.org>, "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>, "Bjorn Helgaas" <bhelgaas@google.com>, "Rob Herring" <robh+dt@kernel.org>, "Andrew Lunn" <andrew@lunn.ch>, "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>, "Krzysztof Wilczyński" <kw@linux.com>, "Russell King" <rmk+kernel@armlinux.org.uk>, "Gregory Clement" <gregory.clement@bootlin.com>, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] PCI: Add PCI_EXP_SLTCAP_*_SHIFT macros Date: Fri, 25 Feb 2022 11:51:11 -0600 [thread overview] Message-ID: <20220225175111.GA367168@bhelgaas> (raw) In-Reply-To: <20220225182216.2fcf5455@thinkpad> On Fri, Feb 25, 2022 at 06:22:16PM +0100, Marek Behún wrote: > On Fri, 25 Feb 2022 09:37:56 -0600 > Bjorn Helgaas <helgaas@kernel.org> wrote: > > Yes, it's a mix. For some recent additions, I've resisted adding the > > _SHIFT macros on the theory that they clutter the file, they never > > change, and the main point of the #defines is readability and so > > grep/tags/etc can find things. > > > > There are a *few* users of FIELD_PREP() and FIELD_GET(): > > > > git grep -E "FIELD_(GET|PREP)\(PCI_EXP" > > > > and I'm inclined to go that direction in the future. What do you > > think? > > I am also pro that direction. > > Would you also like to convert current usages in the .c driver files? > > We can't remove the existing macros since they are in UAPI, but we can > convert drivers so that they don't use _SHIFT macros. Certainly not a high priority, but it actually looks like there aren't *that* many uses in drivers/pci/, so I'd be OK with converting them. Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org> To: "Marek Behún" <kabel@kernel.org> Cc: "Pali Rohár" <pali@kernel.org>, "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>, "Bjorn Helgaas" <bhelgaas@google.com>, "Rob Herring" <robh+dt@kernel.org>, "Andrew Lunn" <andrew@lunn.ch>, "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>, "Krzysztof Wilczyński" <kw@linux.com>, "Russell King" <rmk+kernel@armlinux.org.uk>, "Gregory Clement" <gregory.clement@bootlin.com>, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] PCI: Add PCI_EXP_SLTCAP_*_SHIFT macros Date: Fri, 25 Feb 2022 11:51:11 -0600 [thread overview] Message-ID: <20220225175111.GA367168@bhelgaas> (raw) In-Reply-To: <20220225182216.2fcf5455@thinkpad> On Fri, Feb 25, 2022 at 06:22:16PM +0100, Marek Behún wrote: > On Fri, 25 Feb 2022 09:37:56 -0600 > Bjorn Helgaas <helgaas@kernel.org> wrote: > > Yes, it's a mix. For some recent additions, I've resisted adding the > > _SHIFT macros on the theory that they clutter the file, they never > > change, and the main point of the #defines is readability and so > > grep/tags/etc can find things. > > > > There are a *few* users of FIELD_PREP() and FIELD_GET(): > > > > git grep -E "FIELD_(GET|PREP)\(PCI_EXP" > > > > and I'm inclined to go that direction in the future. What do you > > think? > > I am also pro that direction. > > Would you also like to convert current usages in the .c driver files? > > We can't remove the existing macros since they are in UAPI, but we can > convert drivers so that they don't use _SHIFT macros. Certainly not a high priority, but it actually looks like there aren't *that* many uses in drivers/pci/, so I'd be OK with converting them. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-25 17:51 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-22 16:31 [PATCH 0/6] PCI: mvebu: Slot support Pali Rohár 2022-02-22 16:31 ` Pali Rohár 2022-02-22 16:31 ` [PATCH 1/6] PCI: Add PCI_EXP_SLTCTL_ASPL_DISABLE macro Pali Rohár 2022-02-22 16:31 ` Pali Rohár 2022-02-24 20:13 ` Bjorn Helgaas 2022-02-24 20:13 ` Bjorn Helgaas 2022-02-22 16:31 ` [PATCH 2/6] PCI: Add PCI_EXP_SLTCAP_*_SHIFT macros Pali Rohár 2022-02-22 16:31 ` Pali Rohár 2022-02-24 20:28 ` Bjorn Helgaas 2022-02-24 20:28 ` Bjorn Helgaas 2022-02-25 12:24 ` Pali Rohár 2022-02-25 12:24 ` Pali Rohár 2022-02-25 15:37 ` Bjorn Helgaas 2022-02-25 15:37 ` Bjorn Helgaas 2022-02-25 17:22 ` Marek Behún 2022-02-25 17:22 ` Marek Behún 2022-02-25 17:51 ` Bjorn Helgaas [this message] 2022-02-25 17:51 ` Bjorn Helgaas 2022-02-22 16:31 ` [PATCH 3/6] dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property Pali Rohár 2022-02-22 16:31 ` Pali Rohár 2022-02-22 17:24 ` Marek Behún 2022-02-22 17:24 ` Marek Behún 2022-02-22 17:53 ` Pali Rohár 2022-02-22 17:53 ` Pali Rohár 2022-02-22 16:31 ` [PATCH 4/6] PCI: Add function for parsing 'slot-power-limit-milliwatt' DT property Pali Rohár 2022-02-22 16:31 ` Pali Rohár 2022-02-24 20:47 ` Bjorn Helgaas 2022-02-24 20:47 ` Bjorn Helgaas 2022-02-25 12:30 ` Pali Rohár 2022-02-25 12:30 ` Pali Rohár 2022-02-25 15:51 ` Bjorn Helgaas 2022-02-25 15:51 ` Bjorn Helgaas 2022-02-25 17:58 ` Pali Rohár 2022-02-25 17:58 ` Pali Rohár 2022-02-22 16:31 ` [PATCH 5/6] PCI: mvebu: Add support for sending Set_Slot_Power_Limit message Pali Rohár 2022-02-22 16:31 ` Pali Rohár 2022-02-24 21:28 ` Bjorn Helgaas 2022-02-24 21:28 ` Bjorn Helgaas 2022-02-25 12:54 ` Pali Rohár 2022-02-25 12:54 ` Pali Rohár 2022-02-25 16:57 ` Bjorn Helgaas 2022-02-25 16:57 ` Bjorn Helgaas 2022-03-01 9:47 ` Pali Rohár 2022-03-01 9:47 ` Pali Rohár 2022-02-25 17:02 ` Bjorn Helgaas 2022-02-25 17:02 ` Bjorn Helgaas 2022-03-01 9:50 ` Pali Rohár 2022-03-01 9:50 ` Pali Rohár 2022-02-22 16:31 ` [PATCH 6/6] ARM: dts: turris-omnia: Set PCIe slot-power-limit-milliwatt properties Pali Rohár 2022-02-22 16:31 ` Pali Rohár 2022-02-28 16:13 ` Gregory CLEMENT 2022-02-28 16:13 ` Gregory CLEMENT
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220225175111.GA367168@bhelgaas \ --to=helgaas@kernel.org \ --cc=andrew@lunn.ch \ --cc=bhelgaas@google.com \ --cc=gregory.clement@bootlin.com \ --cc=kabel@kernel.org \ --cc=kw@linux.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=pali@kernel.org \ --cc=rmk+kernel@armlinux.org.uk \ --cc=robh+dt@kernel.org \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.