* [PATCH] ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string
@ 2022-02-26 3:36 Marek Vasut
2022-02-26 12:53 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Marek Vasut @ 2022-02-26 3:36 UTC (permalink / raw)
To: u-boot
Cc: Marek Vasut, Fabio Estevam, Marcel Ziswiler, Peng Fan, Stefano Babic
The correct compatible string for i.MX8MP variant of DWC EQoS MAC
is "nxp,imx8mp-dwmac-eqos", use it. Drop the two current users of
the current wrong compatible string to avoid breaking them.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@denx.de>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
---
arch/arm/dts/imx8mp-evk-u-boot.dtsi | 1 -
arch/arm/dts/imx8mp-verdin-u-boot.dtsi | 1 -
drivers/net/dwc_eth_qos.c | 2 +-
3 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/arm/dts/imx8mp-evk-u-boot.dtsi b/arch/arm/dts/imx8mp-evk-u-boot.dtsi
index ab849ebaaca..7c3789273da 100644
--- a/arch/arm/dts/imx8mp-evk-u-boot.dtsi
+++ b/arch/arm/dts/imx8mp-evk-u-boot.dtsi
@@ -112,7 +112,6 @@
};
&eqos {
- compatible = "fsl,imx-eqos";
/delete-property/ assigned-clocks;
/delete-property/ assigned-clock-parents;
/delete-property/ assigned-clock-rates;
diff --git a/arch/arm/dts/imx8mp-verdin-u-boot.dtsi b/arch/arm/dts/imx8mp-verdin-u-boot.dtsi
index a57ad45ed63..26140a79ebe 100644
--- a/arch/arm/dts/imx8mp-verdin-u-boot.dtsi
+++ b/arch/arm/dts/imx8mp-verdin-u-boot.dtsi
@@ -30,7 +30,6 @@
};
&eqos {
- compatible = "fsl,imx-eqos";
/delete-property/ assigned-clocks;
/delete-property/ assigned-clock-parents;
/delete-property/ assigned-clock-rates;
diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
index 22dad5b2030..ea0c2cfa5b2 100644
--- a/drivers/net/dwc_eth_qos.c
+++ b/drivers/net/dwc_eth_qos.c
@@ -2032,7 +2032,7 @@ static const struct udevice_id eqos_ids[] = {
#endif
#if IS_ENABLED(CONFIG_DWC_ETH_QOS_IMX)
{
- .compatible = "fsl,imx-eqos",
+ .compatible = "nxp,imx8mp-dwmac-eqos",
.data = (ulong)&eqos_imx_config
},
#endif
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string
2022-02-26 3:36 [PATCH] ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string Marek Vasut
@ 2022-02-26 12:53 ` Fabio Estevam
2022-02-27 23:31 ` Marcel Ziswiler
2022-04-12 18:43 ` sbabic
2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2022-02-26 12:53 UTC (permalink / raw)
To: Marek Vasut; +Cc: u-boot, Marcel Ziswiler, Peng Fan, Stefano Babic
Hi Marek,
On 26/02/2022 00:36, Marek Vasut wrote:
> The correct compatible string for i.MX8MP variant of DWC EQoS MAC
> is "nxp,imx8mp-dwmac-eqos", use it. Drop the two current users of
> the current wrong compatible string to avoid breaking them.
Yes, "nxp,imx8mp-dwmac-eqos" is the documented property in the upstream
kernel:
Reviewed-by: Fabio Estevam <festevam@denx.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string
2022-02-26 3:36 [PATCH] ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string Marek Vasut
2022-02-26 12:53 ` Fabio Estevam
@ 2022-02-27 23:31 ` Marcel Ziswiler
2022-03-03 7:54 ` Ramon Fried
2022-04-12 18:43 ` sbabic
2 siblings, 1 reply; 5+ messages in thread
From: Marcel Ziswiler @ 2022-02-27 23:31 UTC (permalink / raw)
To: marex, u-boot; +Cc: peng.fan, festevam, sbabic
On Sat, 2022-02-26 at 04:36 +0100, Marek Vasut wrote:
> The correct compatible string for i.MX8MP variant of DWC EQoS MAC
> is "nxp,imx8mp-dwmac-eqos", use it. Drop the two current users of
> the current wrong compatible string to avoid breaking them.
Thanks, Marek, for fixing this.
> Signed-off-by: Marek Vasut <marex@denx.de>
Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> arch/arm/dts/imx8mp-evk-u-boot.dtsi | 1 -
> arch/arm/dts/imx8mp-verdin-u-boot.dtsi | 1 -
> drivers/net/dwc_eth_qos.c | 2 +-
> 3 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/arm/dts/imx8mp-evk-u-boot.dtsi b/arch/arm/dts/imx8mp-evk-u-boot.dtsi
> index ab849ebaaca..7c3789273da 100644
> --- a/arch/arm/dts/imx8mp-evk-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mp-evk-u-boot.dtsi
> @@ -112,7 +112,6 @@
> };
>
> &eqos {
> - compatible = "fsl,imx-eqos";
> /delete-property/ assigned-clocks;
> /delete-property/ assigned-clock-parents;
> /delete-property/ assigned-clock-rates;
> diff --git a/arch/arm/dts/imx8mp-verdin-u-boot.dtsi b/arch/arm/dts/imx8mp-verdin-u-boot.dtsi
> index a57ad45ed63..26140a79ebe 100644
> --- a/arch/arm/dts/imx8mp-verdin-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mp-verdin-u-boot.dtsi
> @@ -30,7 +30,6 @@
> };
>
> &eqos {
> - compatible = "fsl,imx-eqos";
> /delete-property/ assigned-clocks;
> /delete-property/ assigned-clock-parents;
> /delete-property/ assigned-clock-rates;
> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
> index 22dad5b2030..ea0c2cfa5b2 100644
> --- a/drivers/net/dwc_eth_qos.c
> +++ b/drivers/net/dwc_eth_qos.c
> @@ -2032,7 +2032,7 @@ static const struct udevice_id eqos_ids[] = {
> #endif
> #if IS_ENABLED(CONFIG_DWC_ETH_QOS_IMX)
> {
> - .compatible = "fsl,imx-eqos",
> + .compatible = "nxp,imx8mp-dwmac-eqos",
> .data = (ulong)&eqos_imx_config
> },
> #endif
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string
2022-02-27 23:31 ` Marcel Ziswiler
@ 2022-03-03 7:54 ` Ramon Fried
0 siblings, 0 replies; 5+ messages in thread
From: Ramon Fried @ 2022-03-03 7:54 UTC (permalink / raw)
To: Marcel Ziswiler; +Cc: marex, u-boot, peng.fan, festevam, sbabic
On Mon, Feb 28, 2022 at 1:31 AM Marcel Ziswiler
<marcel.ziswiler@toradex.com> wrote:
>
> On Sat, 2022-02-26 at 04:36 +0100, Marek Vasut wrote:
> > The correct compatible string for i.MX8MP variant of DWC EQoS MAC
> > is "nxp,imx8mp-dwmac-eqos", use it. Drop the two current users of
> > the current wrong compatible string to avoid breaking them.
>
> Thanks, Marek, for fixing this.
>
> > Signed-off-by: Marek Vasut <marex@denx.de>
>
> Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> > Cc: Fabio Estevam <festevam@denx.de>
> > Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > Cc: Peng Fan <peng.fan@nxp.com>
> > Cc: Stefano Babic <sbabic@denx.de>
> > ---
> > arch/arm/dts/imx8mp-evk-u-boot.dtsi | 1 -
> > arch/arm/dts/imx8mp-verdin-u-boot.dtsi | 1 -
> > drivers/net/dwc_eth_qos.c | 2 +-
> > 3 files changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/dts/imx8mp-evk-u-boot.dtsi b/arch/arm/dts/imx8mp-evk-u-boot.dtsi
> > index ab849ebaaca..7c3789273da 100644
> > --- a/arch/arm/dts/imx8mp-evk-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mp-evk-u-boot.dtsi
> > @@ -112,7 +112,6 @@
> > };
> >
> > &eqos {
> > - compatible = "fsl,imx-eqos";
> > /delete-property/ assigned-clocks;
> > /delete-property/ assigned-clock-parents;
> > /delete-property/ assigned-clock-rates;
> > diff --git a/arch/arm/dts/imx8mp-verdin-u-boot.dtsi b/arch/arm/dts/imx8mp-verdin-u-boot.dtsi
> > index a57ad45ed63..26140a79ebe 100644
> > --- a/arch/arm/dts/imx8mp-verdin-u-boot.dtsi
> > +++ b/arch/arm/dts/imx8mp-verdin-u-boot.dtsi
> > @@ -30,7 +30,6 @@
> > };
> >
> > &eqos {
> > - compatible = "fsl,imx-eqos";
> > /delete-property/ assigned-clocks;
> > /delete-property/ assigned-clock-parents;
> > /delete-property/ assigned-clock-rates;
> > diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
> > index 22dad5b2030..ea0c2cfa5b2 100644
> > --- a/drivers/net/dwc_eth_qos.c
> > +++ b/drivers/net/dwc_eth_qos.c
> > @@ -2032,7 +2032,7 @@ static const struct udevice_id eqos_ids[] = {
> > #endif
> > #if IS_ENABLED(CONFIG_DWC_ETH_QOS_IMX)
> > {
> > - .compatible = "fsl,imx-eqos",
> > + .compatible = "nxp,imx8mp-dwmac-eqos",
> > .data = (ulong)&eqos_imx_config
> > },
> > #endif
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string
2022-02-26 3:36 [PATCH] ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string Marek Vasut
2022-02-26 12:53 ` Fabio Estevam
2022-02-27 23:31 ` Marcel Ziswiler
@ 2022-04-12 18:43 ` sbabic
2 siblings, 0 replies; 5+ messages in thread
From: sbabic @ 2022-04-12 18:43 UTC (permalink / raw)
To: Marek Vasut, u-boot
> The correct compatible string for i.MX8MP variant of DWC EQoS MAC
> is "nxp,imx8mp-dwmac-eqos", use it. Drop the two current users of
> the current wrong compatible string to avoid breaking them.
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
> Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-12 18:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-26 3:36 [PATCH] ARM: dts: net: dwc_eth_qos: Fix i.MX8MP compatible string Marek Vasut
2022-02-26 12:53 ` Fabio Estevam
2022-02-27 23:31 ` Marcel Ziswiler
2022-03-03 7:54 ` Ramon Fried
2022-04-12 18:43 ` sbabic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.