All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm: Use strtobool for param parsing
@ 2022-02-27 18:10 Dr. David Alan Gilbert
  2022-02-27 21:51 ` Andrew Morton
  0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2022-02-27 18:10 UTC (permalink / raw)
  To: akpm, pasha.tatashin, songmuchun
  Cc: linux-mm, linux-kernel, Dr. David Alan Gilbert

Use strtobool rather than open coding "on" and "off" parsing in
mm/hugetlb_vmemmap.c and mm/page_table_check.c.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 mm/hugetlb_vmemmap.c  | 12 +-----------
 mm/page_table_check.c | 10 +---------
 2 files changed, 2 insertions(+), 20 deletions(-)

diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
index c540c21e26f5b..919411386e547 100644
--- a/mm/hugetlb_vmemmap.c
+++ b/mm/hugetlb_vmemmap.c
@@ -192,17 +192,7 @@ static int __init early_hugetlb_free_vmemmap_param(char *buf)
 		return 0;
 	}
 
-	if (!buf)
-		return -EINVAL;
-
-	if (!strcmp(buf, "on"))
-		hugetlb_free_vmemmap_enabled = true;
-	else if (!strcmp(buf, "off"))
-		hugetlb_free_vmemmap_enabled = false;
-	else
-		return -EINVAL;
-
-	return 0;
+	return strtobool(buf, &hugetlb_free_vmemmap_enabled);
 }
 early_param("hugetlb_free_vmemmap", early_hugetlb_free_vmemmap_param);
 
diff --git a/mm/page_table_check.c b/mm/page_table_check.c
index 3763bd077861a..2458281bff893 100644
--- a/mm/page_table_check.c
+++ b/mm/page_table_check.c
@@ -23,15 +23,7 @@ EXPORT_SYMBOL(page_table_check_disabled);
 
 static int __init early_page_table_check_param(char *buf)
 {
-	if (!buf)
-		return -EINVAL;
-
-	if (strcmp(buf, "on") == 0)
-		__page_table_check_enabled = true;
-	else if (strcmp(buf, "off") == 0)
-		__page_table_check_enabled = false;
-
-	return 0;
+	return strtobool(buf, &__page_table_check_enabled);
 }
 
 early_param("page_table_check", early_page_table_check_param);
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] mm: Use strtobool for param parsing
  2022-02-27 18:10 [PATCH] mm: Use strtobool for param parsing Dr. David Alan Gilbert
@ 2022-02-27 21:51 ` Andrew Morton
  2022-02-28 12:18   ` Dr. David Alan Gilbert
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2022-02-27 21:51 UTC (permalink / raw)
  To: Dr. David Alan Gilbert; +Cc: pasha.tatashin, songmuchun, linux-mm, linux-kernel

On Sun, 27 Feb 2022 18:10:39 +0000 "Dr. David Alan Gilbert" <linux@treblig.org> wrote:

> Use strtobool rather than open coding "on" and "off" parsing in
> mm/hugetlb_vmemmap.c and mm/page_table_check.c.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  mm/hugetlb_vmemmap.c  | 12 +-----------
>  mm/page_table_check.c | 10 +---------
>  2 files changed, 2 insertions(+), 20 deletions(-)
> 
> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
> index c540c21e26f5b..919411386e547 100644
> --- a/mm/hugetlb_vmemmap.c
> +++ b/mm/hugetlb_vmemmap.c
> @@ -192,17 +192,7 @@ static int __init early_hugetlb_free_vmemmap_param(char *buf)
>  		return 0;
>  	}
>  
> -	if (!buf)
> -		return -EINVAL;
> -
> -	if (!strcmp(buf, "on"))
> -		hugetlb_free_vmemmap_enabled = true;
> -	else if (!strcmp(buf, "off"))
> -		hugetlb_free_vmemmap_enabled = false;
> -	else
> -		return -EINVAL;
> -
> -	return 0;
> +	return strtobool(buf, &hugetlb_free_vmemmap_enabled);
>  }
>  early_param("hugetlb_free_vmemmap", early_hugetlb_free_vmemmap_param);

This part falls afoul of the changes in
https://lkml.kernel.org/r/20211101031651.75851-3-songmuchun@bytedance.com

> diff --git a/mm/page_table_check.c b/mm/page_table_check.c
> index 3763bd077861a..2458281bff893 100644
> --- a/mm/page_table_check.c
> +++ b/mm/page_table_check.c
> @@ -23,15 +23,7 @@ EXPORT_SYMBOL(page_table_check_disabled);
>  
>  static int __init early_page_table_check_param(char *buf)
>  {
> -	if (!buf)
> -		return -EINVAL;
> -
> -	if (strcmp(buf, "on") == 0)
> -		__page_table_check_enabled = true;
> -	else if (strcmp(buf, "off") == 0)
> -		__page_table_check_enabled = false;
> -
> -	return 0;
> +	return strtobool(buf, &__page_table_check_enabled);
>  }

But this works OK.

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] mm: Use strtobool for param parsing
  2022-02-27 21:51 ` Andrew Morton
@ 2022-02-28 12:18   ` Dr. David Alan Gilbert
  0 siblings, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2022-02-28 12:18 UTC (permalink / raw)
  To: Andrew Morton; +Cc: pasha.tatashin, songmuchun, linux-mm, linux-kernel

* Andrew Morton (akpm@linux-foundation.org) wrote:
> On Sun, 27 Feb 2022 18:10:39 +0000 "Dr. David Alan Gilbert" <linux@treblig.org> wrote:
> 
> > Use strtobool rather than open coding "on" and "off" parsing in
> > mm/hugetlb_vmemmap.c and mm/page_table_check.c.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  mm/hugetlb_vmemmap.c  | 12 +-----------
> >  mm/page_table_check.c | 10 +---------
> >  2 files changed, 2 insertions(+), 20 deletions(-)
> > 
> > diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
> > index c540c21e26f5b..919411386e547 100644
> > --- a/mm/hugetlb_vmemmap.c
> > +++ b/mm/hugetlb_vmemmap.c
> > @@ -192,17 +192,7 @@ static int __init early_hugetlb_free_vmemmap_param(char *buf)
> >  		return 0;
> >  	}
> >  
> > -	if (!buf)
> > -		return -EINVAL;
> > -
> > -	if (!strcmp(buf, "on"))
> > -		hugetlb_free_vmemmap_enabled = true;
> > -	else if (!strcmp(buf, "off"))
> > -		hugetlb_free_vmemmap_enabled = false;
> > -	else
> > -		return -EINVAL;
> > -
> > -	return 0;
> > +	return strtobool(buf, &hugetlb_free_vmemmap_enabled);
> >  }
> >  early_param("hugetlb_free_vmemmap", early_hugetlb_free_vmemmap_param);
> 
> This part falls afoul of the changes in
> https://lkml.kernel.org/r/20211101031651.75851-3-songmuchun@bytedance.com

Hmm, yes that's quite different.

> > diff --git a/mm/page_table_check.c b/mm/page_table_check.c
> > index 3763bd077861a..2458281bff893 100644
> > --- a/mm/page_table_check.c
> > +++ b/mm/page_table_check.c
> > @@ -23,15 +23,7 @@ EXPORT_SYMBOL(page_table_check_disabled);
> >  
> >  static int __init early_page_table_check_param(char *buf)
> >  {
> > -	if (!buf)
> > -		return -EINVAL;
> > -
> > -	if (strcmp(buf, "on") == 0)
> > -		__page_table_check_enabled = true;
> > -	else if (strcmp(buf, "off") == 0)
> > -		__page_table_check_enabled = false;
> > -
> > -	return 0;
> > +	return strtobool(buf, &__page_table_check_enabled);
> >  }
> 
> But this works OK.

Thanks for taking it.

Dave

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-28 12:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-27 18:10 [PATCH] mm: Use strtobool for param parsing Dr. David Alan Gilbert
2022-02-27 21:51 ` Andrew Morton
2022-02-28 12:18   ` Dr. David Alan Gilbert

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.