From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> To: jassisinghbrar@gmail.com, robh+dt@kernel.org, shawnguo@kernel.org Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, krzysztof.kozlowski@canonical.com, daniel.baluta@nxp.com, Peng Fan <peng.fan@nxp.com> Subject: [PATCH V5 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 MU support Date: Mon, 28 Feb 2022 10:40:10 +0800 [thread overview] Message-ID: <20220228024013.2866386-3-peng.fan@oss.nxp.com> (raw) In-Reply-To: <20220228024013.2866386-1-peng.fan@oss.nxp.com> From: Peng Fan <peng.fan@nxp.com> Similar to i.MX8ULP S4 MU, i.MX93 MU is dedicated for communication between Sentinel and Cortex-A cores from hardware design, it could not be reused for other purpose. However i.MX93 S4 MU use separate tx/rx interrupt, so update interrupts and add interrupt-names property. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> --- Hi Rob, For dual entries, I tested below with dt_binding_check and dtbs_check " + s4muap: s4muap@47520000 { + compatible = "fsl,imx93-mu-s4"; + reg = <0x47520000 0x10000>; + interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "tx", "rx"; + #mbox-cells = <2>; + status = "okay"; + }; + + s4muap1: s4muap@48520000 { + compatible = "fsl,imx8ulp-mu-s4"; + reg = <0x48520000 0x10000>; + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "tx", "rx"; + #mbox-cells = <2>; + status = "okay"; + }; " .../devicetree/bindings/mailbox/fsl,mu.yaml | 28 ++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml index 6d056d5e16bf..82ce0280add9 100644 --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml @@ -29,6 +29,7 @@ properties: - const: fsl,imx8ulp-mu - const: fsl,imx8-mu-scu - const: fsl,imx8-mu-seco + - const: fsl,imx93-mu-s4 - const: fsl,imx8ulp-mu-s4 - items: - const: fsl,imx93-mu @@ -55,7 +56,14 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1 + maxItems: 2 + + interrupt-names: + minItems: 1 + items: + - const: tx + - const: rx "#mbox-cells": description: | @@ -90,6 +98,24 @@ required: - interrupts - "#mbox-cells" +allOf: + - if: + properties: + compatible: + enum: + - fsl,imx93-mu-s4 + then: + properties: + interrupt-names: + minItems: 2 + interrupts: + minItems: 2 + + else: + properties: + interrupts: + maxItems: 1 + additionalProperties: false examples: -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> To: jassisinghbrar@gmail.com, robh+dt@kernel.org, shawnguo@kernel.org Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, krzysztof.kozlowski@canonical.com, daniel.baluta@nxp.com, Peng Fan <peng.fan@nxp.com> Subject: [PATCH V5 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 MU support Date: Mon, 28 Feb 2022 10:40:10 +0800 [thread overview] Message-ID: <20220228024013.2866386-3-peng.fan@oss.nxp.com> (raw) In-Reply-To: <20220228024013.2866386-1-peng.fan@oss.nxp.com> From: Peng Fan <peng.fan@nxp.com> Similar to i.MX8ULP S4 MU, i.MX93 MU is dedicated for communication between Sentinel and Cortex-A cores from hardware design, it could not be reused for other purpose. However i.MX93 S4 MU use separate tx/rx interrupt, so update interrupts and add interrupt-names property. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> --- Hi Rob, For dual entries, I tested below with dt_binding_check and dtbs_check " + s4muap: s4muap@47520000 { + compatible = "fsl,imx93-mu-s4"; + reg = <0x47520000 0x10000>; + interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "tx", "rx"; + #mbox-cells = <2>; + status = "okay"; + }; + + s4muap1: s4muap@48520000 { + compatible = "fsl,imx8ulp-mu-s4"; + reg = <0x48520000 0x10000>; + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "tx", "rx"; + #mbox-cells = <2>; + status = "okay"; + }; " .../devicetree/bindings/mailbox/fsl,mu.yaml | 28 ++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml index 6d056d5e16bf..82ce0280add9 100644 --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml @@ -29,6 +29,7 @@ properties: - const: fsl,imx8ulp-mu - const: fsl,imx8-mu-scu - const: fsl,imx8-mu-seco + - const: fsl,imx93-mu-s4 - const: fsl,imx8ulp-mu-s4 - items: - const: fsl,imx93-mu @@ -55,7 +56,14 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1 + maxItems: 2 + + interrupt-names: + minItems: 1 + items: + - const: tx + - const: rx "#mbox-cells": description: | @@ -90,6 +98,24 @@ required: - interrupts - "#mbox-cells" +allOf: + - if: + properties: + compatible: + enum: + - fsl,imx93-mu-s4 + then: + properties: + interrupt-names: + minItems: 2 + interrupts: + minItems: 2 + + else: + properties: + interrupts: + maxItems: 1 + additionalProperties: false examples: -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-28 2:38 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-28 2:40 [PATCH V5 0/5] mailbox: imx: support i.MX93 Peng Fan (OSS) 2022-02-28 2:40 ` Peng Fan (OSS) 2022-02-28 2:40 ` [PATCH V5 1/5] dt-bindings: mailbox: imx-mu: add i.MX93 MU Peng Fan (OSS) 2022-02-28 2:40 ` Peng Fan (OSS) 2022-02-28 2:40 ` Peng Fan (OSS) [this message] 2022-02-28 2:40 ` [PATCH V5 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 MU support Peng Fan (OSS) 2022-03-01 15:42 ` Rob Herring 2022-03-01 15:42 ` Rob Herring 2022-02-28 2:40 ` [PATCH V5 3/5] mailbox: imx: extend irq to an array Peng Fan (OSS) 2022-02-28 2:40 ` Peng Fan (OSS) 2022-02-28 2:40 ` [PATCH V5 4/5] mailbox: imx: support dual interrupts Peng Fan (OSS) 2022-02-28 2:40 ` Peng Fan (OSS) 2022-02-28 2:40 ` [PATCH V5 5/5] mailbox: imx: support i.MX93 S401 MU Peng Fan (OSS) 2022-02-28 2:40 ` Peng Fan (OSS)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220228024013.2866386-3-peng.fan@oss.nxp.com \ --to=peng.fan@oss.nxp.com \ --cc=daniel.baluta@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=jassisinghbrar@gmail.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski@canonical.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=peng.fan@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.