All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: linux-input@vger.kernel.org
Cc: Stephen Boyd <swboyd@chromium.org>,
	benjamin.tissoires@redhat.com, Jiri Kosina <jikos@kernel.org>,
	Sean O'Brien <seobrien@chromium.org>,
	"Douglas Anderson linux-kernel @ vger . kernel . org" 
	<dianders@chromium.org>
Subject: [PATCH v5 0/5] Input/HID: Consolidate ChromeOS Vivaldi keyboard logic
Date: Sun, 27 Feb 2022 23:54:41 -0800	[thread overview]
Message-ID: <20220228075446.466016-1-dmitry.torokhov@gmail.com> (raw)

This is a follow-on to this thread[1] where we discussed the need to
support the vivaldi keyboard function row keys in the google hammer
driver. I've extracted the common code into a new vivaldi-fmap.c file
that can be used by the various keyboard drivers used on ChromeOS
devices to expose the function_row_physmap sysfs attribute. Then we make
another file to keep the HID parsing logic common for the vivaldi and
hammer keyboards. Finally, we add support for the function row physmap
attribute to the hammer driver.

NOTE: I dropped Tested-by and Acked-by as patches have been reworked,
please give them another spin.

Changed from v4 (dtor):
(https://lore.kernel.org/r/20220216195901.1326924-1-swboyd@chromium.org):
 * The series is on top of [PATCH] HID: vivaldi: fix sysfs attributes
   leak (https://lore.kernel.org/r/YhmAAjNeTjiNoLlJ@google.com)
 * Added patch to used devm for keyboard backlight LED in hammer driver
 * Avoid putting HID-specific stuff in input header, instead introduce
   new private hid-vivaldi-common.h
 * More code sharing between hid-google-hammer.c and hid-vivaldi.c by
   mandating that vivaldi data instance should be the very first or the
   only driver-private data.

Changes from v3
(https://lore.kernel.org/r/20220211012510.1198155-1-swboyd@chromium.org):
 * Changed vivaldi-keymap to vivaldi-fmap

Changes from v2
(https://lore.kernel.org/r/20220209225556.3992827-1-swboyd@chromium.org):
 * Drop first patch to change to u16
 * Change array type to u32 in vivaldi_data

Changes from v1
(https://lore.kernel.org/r/20220204202021.895426-1-swboyd@chromium.org):
 * Yet another new file for HID part to fix compilation problems

Dmitry Torokhov (1):
  HID: google: switch to devm when registering keyboard backlight LED

Stephen Boyd (3):
  Input: extract ChromeOS vivaldi physmap show function
  HID: google: extract Vivaldi hid feature mapping for use in hid-hammer
  HID: google: Add support for vivaldi to hid-hammer

Zhengqiao Xia (1):
  HID: google: modify HID device groups of eel

 drivers/hid/Kconfig                   |  11 ++
 drivers/hid/Makefile                  |   1 +
 drivers/hid/hid-google-hammer.c       |  51 +++++-----
 drivers/hid/hid-vivaldi-common.c      | 140 ++++++++++++++++++++++++++
 drivers/hid/hid-vivaldi-common.h      |  16 +++
 drivers/hid/hid-vivaldi.c             | 121 +---------------------
 drivers/input/Kconfig                 |   7 ++
 drivers/input/Makefile                |   1 +
 drivers/input/keyboard/Kconfig        |   2 +
 drivers/input/keyboard/atkbd.c        |  27 ++---
 drivers/input/keyboard/cros_ec_keyb.c |  43 +++-----
 drivers/input/vivaldi-fmap.c          |  39 +++++++
 include/linux/input/vivaldi-fmap.h    |  27 +++++
 13 files changed, 296 insertions(+), 190 deletions(-)
 create mode 100644 drivers/hid/hid-vivaldi-common.c
 create mode 100644 drivers/hid/hid-vivaldi-common.h
 create mode 100644 drivers/input/vivaldi-fmap.c
 create mode 100644 include/linux/input/vivaldi-fmap.h

-- 
2.35.1.574.g5d30c73bfb-goog


             reply	other threads:[~2022-02-28  7:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28  7:54 Dmitry Torokhov [this message]
2022-02-28  7:54 ` [PATCH v5 1/5] HID: google: switch to devm when registering keyboard backlight LED Dmitry Torokhov
2022-02-28  7:54 ` [PATCH v5 2/5] Input: extract ChromeOS vivaldi physmap show function Dmitry Torokhov
2022-02-28  7:54 ` [PATCH v5 3/5] HID: google: extract Vivaldi hid feature mapping for use in hid-hammer Dmitry Torokhov
2022-02-28 20:56   ` Stephen Boyd
2022-02-28  7:54 ` [PATCH v5 4/5] HID: google: Add support for vivaldi to hid-hammer Dmitry Torokhov
2022-02-28  7:54 ` [PATCH v5 5/5] HID: google: modify HID device groups of eel Dmitry Torokhov
2022-02-28 20:57   ` Stephen Boyd
2022-03-01  6:55     ` Dmitry Torokhov
2022-03-02  1:52 ` [PATCH v5 0/5] Input/HID: Consolidate ChromeOS Vivaldi keyboard logic Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220228075446.466016-1-dmitry.torokhov@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dianders@chromium.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=seobrien@chromium.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.