From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: linux-input@vger.kernel.org,
Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>,
benjamin.tissoires@redhat.com, Jiri Kosina <jikos@kernel.org>,
Sean O'Brien <seobrien@chromium.org>,
"Douglas Anderson linux-kernel @ vger . kernel . org"
<dianders@chromium.org>, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH v5 5/5] HID: google: modify HID device groups of eel
Date: Mon, 28 Feb 2022 22:55:20 -0800 [thread overview]
Message-ID: <Yh3DWP3Nyk2XcidE@google.com> (raw)
In-Reply-To: <CAE-0n50nS_y740FWAJZF5q_NtawoFeDqE1C-ENLKBaCYmMfiJA@mail.gmail.com>
On Mon, Feb 28, 2022 at 12:57:56PM -0800, Stephen Boyd wrote:
> Quoting Dmitry Torokhov (2022-02-27 23:54:46)
> > From: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
> >
> > If HID_GROUP of eel is set to HID_GROUP_GENERIC, Whiskers Tablet Mode
> > Switch of eel hammer will not be detected by system because the
> > hid-vivaldi driver probes the device. When it is set to
> > HID_GROUP_VIVALDI, system will detect Whiskers Tablet Mode Switch
> > successfully and also support the vivaldi keyboard layout.
> >
> > Tested-by: "Sean O'Brien" <seobrien@chromium.org>
> > Acked-by: Jiri Kosina <jkosina@suse.cz>
> > Signed-off-by: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
> > [swboyd@chromium.org: Expand on commit text]
> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> > Link: https://lore.kernel.org/r/20220216195901.1326924-5-swboyd@chromium.org
> > Patchwork-Id: 12748989
>
> Should this patchwork id be removed?
Yeah, this is leftover from my scripts, they will drop it when applying.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2022-03-01 6:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 7:54 [PATCH v5 0/5] Input/HID: Consolidate ChromeOS Vivaldi keyboard logic Dmitry Torokhov
2022-02-28 7:54 ` [PATCH v5 1/5] HID: google: switch to devm when registering keyboard backlight LED Dmitry Torokhov
2022-02-28 7:54 ` [PATCH v5 2/5] Input: extract ChromeOS vivaldi physmap show function Dmitry Torokhov
2022-02-28 7:54 ` [PATCH v5 3/5] HID: google: extract Vivaldi hid feature mapping for use in hid-hammer Dmitry Torokhov
2022-02-28 20:56 ` Stephen Boyd
2022-02-28 7:54 ` [PATCH v5 4/5] HID: google: Add support for vivaldi to hid-hammer Dmitry Torokhov
2022-02-28 7:54 ` [PATCH v5 5/5] HID: google: modify HID device groups of eel Dmitry Torokhov
2022-02-28 20:57 ` Stephen Boyd
2022-03-01 6:55 ` Dmitry Torokhov [this message]
2022-03-02 1:52 ` [PATCH v5 0/5] Input/HID: Consolidate ChromeOS Vivaldi keyboard logic Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh3DWP3Nyk2XcidE@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dianders@chromium.org \
--cc=jikos@kernel.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=seobrien@chromium.org \
--cc=swboyd@chromium.org \
--cc=xiazhengqiao@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.