All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: laurent@vivier.eu, pbonzini@redhat.com, fam@euphon.net,
	qemu-devel@nongnu.org
Subject: [PATCH 05/10] macfb: set initial value of mode control registers in macfb_common_realize()
Date: Mon, 28 Feb 2022 22:25:22 +0000	[thread overview]
Message-ID: <20220228222527.8234-6-mark.cave-ayland@ilande.co.uk> (raw)
In-Reply-To: <20220228222527.8234-1-mark.cave-ayland@ilande.co.uk>

If booting Linux directly in the q800 machine using -kernel rather than using a
MacOS toolbox ROM, the mode control registers are never initialised,
causing macfb_mode_write() to fail to determine the current resolution after
migration. Resolve this by always setting the initial values of the mode control
registers based upon the initial macfb properties during realize.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/display/macfb.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/hw/display/macfb.c b/hw/display/macfb.c
index f9ceea532e..bcfb2d0dab 100644
--- a/hw/display/macfb.c
+++ b/hw/display/macfb.c
@@ -647,6 +647,14 @@ static bool macfb_common_realize(DeviceState *dev, MacfbState *s, Error **errp)
         return false;
     }
 
+    /*
+     * Set mode control registers to match the mode found above so that
+     * macfb_mode_write() does the right thing if no MacOS toolbox ROM
+     * is present to initialise them
+     */
+    s->regs[DAFB_MODE_CTRL1 >> 2] = s->mode->mode_ctrl1;
+    s->regs[DAFB_MODE_CTRL2 >> 2] = s->mode->mode_ctrl2;
+
     s->con = graphic_console_init(dev, 0, &macfb_ops, s);
     surface = qemu_console_surface(s->con);
 
-- 
2.20.1



  parent reply	other threads:[~2022-02-28 22:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 22:25 [PATCH 00/10] q800: migration fixes Mark Cave-Ayland
2022-02-28 22:25 ` [PATCH 01/10] macfb: add VMStateDescription for MacfbNubusState and MacfbSysBusState Mark Cave-Ayland
2022-02-28 22:25 ` [PATCH 02/10] macfb: don't use special irq_state and irq_mask variables in MacfbState Mark Cave-Ayland
2022-02-28 23:11   ` Philippe Mathieu-Daudé
2022-02-28 22:25 ` [PATCH 03/10] macfb: increase number of registers saved " Mark Cave-Ayland
2022-03-02  9:11   ` Mark Cave-Ayland
2022-02-28 22:25 ` [PATCH 04/10] macfb: add VMStateDescription fields for display type and VBL timer Mark Cave-Ayland
2022-02-28 22:25 ` Mark Cave-Ayland [this message]
2022-02-28 22:25 ` [PATCH 06/10] esp: introduce esp_set_pdma_cb() function Mark Cave-Ayland
2022-02-28 23:06   ` Philippe Mathieu-Daudé
2022-02-28 22:25 ` [PATCH 07/10] esp: introduce esp_pdma_cb() function Mark Cave-Ayland
2022-02-28 23:06   ` Philippe Mathieu-Daudé
2022-02-28 22:25 ` [PATCH 08/10] esp: convert ESPState pdma_cb from a function pointer to an integer Mark Cave-Ayland
2022-02-28 23:10   ` Philippe Mathieu-Daudé
2022-03-02  9:17     ` Mark Cave-Ayland
2022-02-28 22:25 ` [PATCH 09/10] esp: include the current PDMA callback in the migration stream Mark Cave-Ayland
2022-02-28 22:25 ` [PATCH 10/10] esp: recreate ESPState current_req after migration Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220228222527.8234-6-mark.cave-ayland@ilande.co.uk \
    --to=mark.cave-ayland@ilande.co.uk \
    --cc=fam@euphon.net \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.