Re: [PATCH 03/10] macfb: increase number of registers saved in MacfbState

[Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>]

On 28/02/2022 22:25, Mark Cave-Ayland wrote:

> The MacOS toolbox ROM accesses a number of addresses between 0x0 and 0x200 during
> initialisation and resolution changes. Whilst the function of many of these
> registers is unknown, it is worth the minimal cost of saving these extra values as
> part of migration to help future-proof the migration stream for the q800 machine
> as it starts to stabilise.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>   include/hw/display/macfb.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/display/macfb.h b/include/hw/display/macfb.h
> index 6d9f0f7869..c0e2df8dc6 100644
> --- a/include/hw/display/macfb.h
> +++ b/include/hw/display/macfb.h
> @@ -48,7 +48,7 @@ typedef struct MacFbMode {
>       uint32_t offset;
>   } MacFbMode;
>   
> -#define MACFB_NUM_REGS      8
> +#define MACFB_NUM_REGS      (0x200 / sizeof(uint32_t))
>   
>   typedef struct MacfbState {
>       MemoryRegion mem_vram;

Sigh. This patch isn't right: it's missing a later commit in my local branch that 
needs to be squashed into it, and even then I can now see a bug in that implementation.

I'll send an updated version of this patch in v2.


ATB,

Mark.