All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] power: supply: ab8500: Remove unused variable
@ 2022-03-01  5:28 Souptick Joarder
  2022-03-04 21:24 ` Sebastian Reichel
  0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2022-03-01  5:28 UTC (permalink / raw)
  To: sre; +Cc: linux-pm, linux-kernel, Souptick Joarder (HPE), kernel test robot

From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>

Kernel test robot reported below warning ->
drivers/power/supply/ab8500_chargalg.c:790:13: warning:
variable 'delta_i_ua' set but not used [-Wunused-but-set-variable]

Remove unused variable delta_i_ua.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
---
 drivers/power/supply/ab8500_chargalg.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/power/supply/ab8500_chargalg.c b/drivers/power/supply/ab8500_chargalg.c
index b5a3096e78a1..f73d29c09caf 100644
--- a/drivers/power/supply/ab8500_chargalg.c
+++ b/drivers/power/supply/ab8500_chargalg.c
@@ -793,13 +793,10 @@ static void init_maxim_chg_curr(struct ab8500_chargalg *di)
  */
 static enum maxim_ret ab8500_chargalg_chg_curr_maxim(struct ab8500_chargalg *di)
 {
-	int delta_i_ua;
 
 	if (!di->bm->maxi->ena_maxi)
 		return MAXIM_RET_NOACTION;
 
-	delta_i_ua = di->ccm.original_iset_ua - di->batt_data.inst_curr_ua;
-
 	if (di->events.vbus_collapsed) {
 		dev_dbg(di->dev, "Charger voltage has collapsed %d\n",
 				di->ccm.wait_cnt);
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] power: supply: ab8500: Remove unused variable
  2022-03-01  5:28 [PATCH] power: supply: ab8500: Remove unused variable Souptick Joarder
@ 2022-03-04 21:24 ` Sebastian Reichel
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2022-03-04 21:24 UTC (permalink / raw)
  To: Souptick Joarder; +Cc: Linus Walleij, linux-pm, linux-kernel, kernel test robot

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

Hi,

On Tue, Mar 01, 2022 at 10:58:50AM +0530, Souptick Joarder wrote:
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
> 
> Kernel test robot reported below warning ->
> drivers/power/supply/ab8500_chargalg.c:790:13: warning:
> variable 'delta_i_ua' set but not used [-Wunused-but-set-variable]
> 
> Remove unused variable delta_i_ua.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/ab8500_chargalg.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/power/supply/ab8500_chargalg.c b/drivers/power/supply/ab8500_chargalg.c
> index b5a3096e78a1..f73d29c09caf 100644
> --- a/drivers/power/supply/ab8500_chargalg.c
> +++ b/drivers/power/supply/ab8500_chargalg.c
> @@ -793,13 +793,10 @@ static void init_maxim_chg_curr(struct ab8500_chargalg *di)
>   */
>  static enum maxim_ret ab8500_chargalg_chg_curr_maxim(struct ab8500_chargalg *di)
>  {
> -	int delta_i_ua;
>  
>  	if (!di->bm->maxi->ena_maxi)
>  		return MAXIM_RET_NOACTION;
>  
> -	delta_i_ua = di->ccm.original_iset_ua - di->batt_data.inst_curr_ua;
> -
>  	if (di->events.vbus_collapsed) {
>  		dev_dbg(di->dev, "Charger voltage has collapsed %d\n",
>  				di->ccm.wait_cnt);
> -- 
> 2.25.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-03-04 21:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-01  5:28 [PATCH] power: supply: ab8500: Remove unused variable Souptick Joarder
2022-03-04 21:24 ` Sebastian Reichel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.