* [PATCH] power: supply: axp20x_usb_power: fix platform_get_irq.cocci warnings
@ 2022-03-02 2:34 Yihao Han
2022-03-04 21:04 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Yihao Han @ 2022-03-02 2:34 UTC (permalink / raw)
To: Sebastian Reichel, Chen-Yu Tsai, linux-pm, linux-kernel; +Cc: kernel, Yihao Han
Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
drivers/power/supply/axp20x_usb_power.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c
index a1d110f7ddce..75170fe79cbf 100644
--- a/drivers/power/supply/axp20x_usb_power.c
+++ b/drivers/power/supply/axp20x_usb_power.c
@@ -638,8 +638,6 @@ static int axp20x_usb_power_probe(struct platform_device *pdev)
for (i = 0; i < axp_data->num_irq_names; i++) {
irq = platform_get_irq_byname(pdev, axp_data->irq_names[i]);
if (irq < 0) {
- dev_err(&pdev->dev, "No IRQ for %s: %d\n",
- axp_data->irq_names[i], irq);
return irq;
}
power->irqs[i] = regmap_irq_get_virq(axp20x->regmap_irqc, irq);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: supply: axp20x_usb_power: fix platform_get_irq.cocci warnings
2022-03-02 2:34 [PATCH] power: supply: axp20x_usb_power: fix platform_get_irq.cocci warnings Yihao Han
@ 2022-03-04 21:04 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2022-03-04 21:04 UTC (permalink / raw)
To: Yihao Han; +Cc: Chen-Yu Tsai, linux-pm, linux-kernel, kernel
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
Hi,
On Tue, Mar 01, 2022 at 06:34:51PM -0800, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
Thanks, queued (slightly modified to remove the now useless {}).
-- Sebastian
> drivers/power/supply/axp20x_usb_power.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c
> index a1d110f7ddce..75170fe79cbf 100644
> --- a/drivers/power/supply/axp20x_usb_power.c
> +++ b/drivers/power/supply/axp20x_usb_power.c
> @@ -638,8 +638,6 @@ static int axp20x_usb_power_probe(struct platform_device *pdev)
> for (i = 0; i < axp_data->num_irq_names; i++) {
> irq = platform_get_irq_byname(pdev, axp_data->irq_names[i]);
> if (irq < 0) {
> - dev_err(&pdev->dev, "No IRQ for %s: %d\n",
> - axp_data->irq_names[i], irq);
> return irq;
> }
> power->irqs[i] = regmap_irq_get_virq(axp20x->regmap_irqc, irq);
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-04 21:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 2:34 [PATCH] power: supply: axp20x_usb_power: fix platform_get_irq.cocci warnings Yihao Han
2022-03-04 21:04 ` Sebastian Reichel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.