* Re: Re: [PATCH] ASoC: fsi: Add check for clk_enable
@ 2022-03-02 3:11 ` Jiasheng Jiang
0 siblings, 0 replies; 2+ messages in thread
From: Jiasheng Jiang @ 2022-03-02 3:11 UTC (permalink / raw)
To: broonie
Cc: lgirdwood, perex, tiwai, ast, daniel, andrii, kafai,
songliubraving, yhs, john.fastabend, kpsingh, f.suligoi,
kuninori.morimoto.gx, alsa-devel, linux-kernel, netdev, bpf,
Jiasheng Jiang
On Tue, Mar 01, 2022 at 08:44:12PM +0800, Mark Brown wrote:
>> +err:
>> + clk_disable(clock->xck);
>> + clk_disable(clock->ick);
>> + clk_disable(clock->div);
>
> You need separate labels for each enable so that we don't end up
> disabling clocks we didn't enable, that would also be a bug.
Thanks, I have submitted a v2 to fix it.
Jiang
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Re: [PATCH] ASoC: fsi: Add check for clk_enable
@ 2022-03-02 3:11 ` Jiasheng Jiang
0 siblings, 0 replies; 2+ messages in thread
From: Jiasheng Jiang @ 2022-03-02 3:11 UTC (permalink / raw)
To: broonie
Cc: alsa-devel, songliubraving, Jiasheng Jiang, ast,
kuninori.morimoto.gx, daniel, lgirdwood, linux-kernel, bpf,
john.fastabend, andrii, tiwai, netdev, kpsingh, yhs, f.suligoi,
kafai
On Tue, Mar 01, 2022 at 08:44:12PM +0800, Mark Brown wrote:
>> +err:
>> + clk_disable(clock->xck);
>> + clk_disable(clock->ick);
>> + clk_disable(clock->div);
>
> You need separate labels for each enable so that we don't end up
> disabling clocks we didn't enable, that would also be a bug.
Thanks, I have submitted a v2 to fix it.
Jiang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-02 3:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 3:11 Re: [PATCH] ASoC: fsi: Add check for clk_enable Jiasheng Jiang
2022-03-02 3:11 ` Jiasheng Jiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.